Commit Graph

15707 Commits

Author SHA1 Message Date
Owen Leonard ebec24f9cf Bug 8398 - Missing image file in staff global css
This patch fixes a regression introduced by the fix for
Bug 6855 (bullet point showing in wrong place on error message)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855

The patch removes the re-introduced reference to a
background image which has since been removed. Testers should
check that this patch does not re-introduce Bug 6855.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I checked the styling of the error messages in Chromium and Firefox.
The logs are no longer complaining about the missing image.
Looks good to me.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6b80d0d681)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:42:53 -04:00
Owen Leonard 2f13698f3f Fix for Bug 6855 - List bullet showing in wrong place on error message
Added some more specific CSS to help Webkit browsers display
the lists bullets correctly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 9 June 2012. Signing off as well, since the rebase and test
were trivial.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bfcb15eeed)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:42:40 -04:00
wajasu 746ea848b6 Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e66b380ead)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:40:34 -04:00
Katrin Fischer d2d119b0d9 Bug 6394: purchase order has French strings hard coded in
On the purchase order it said 'publié par' - instead of 'published by'.

The layout files for PDF generation in basket groups contain lots of English
strings, this change makes the template more consistent.

Currently the files are not translatable. The only way is to add translated
files to your installation.

To test:
Print a basket group as PDF. Verify string is ok for both possible settings
of system preference OrderPdfFormat:
- pdfformat::layout3pages
- pdfformat::layout2pages

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fa238b1856)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:40:26 -04:00
Dobrica Pavlinusic 2625b8521c Bug 8315 - remove use C4::* version
This patch touches a lot of code, but basically it removes version
information from use C4::* in our code.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
All script still compiles after the patch (confirmed by pre-applypatch hook)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:40:03 -04:00
Robin Sheat 90a827841f Bug 8235 - allow a whitelist of modules that aren't in Debian
This allows modules that aren't in the main debian repos to be handled
by the list-deps script when building a control file.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5cb0834f4d)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:35:48 -04:00
Jared Camins-Esakov bb208e9852 Bug 8383: Add test to check that Perl scripts compile
This patch adds t/db_dependent/00-strict.pl which tests that all Perl
scripts compile. I chose to use Test::Strict so that in the future we
can also have the test check that "use strict" and "use warnings" are
enabled.

To test:
1. Run t/db_dependent/00-strict.pl.
2. Run around waving your arms in the air that we have a couple of
   scripts that don't compile.
3. Actually, that's about it. You could test my patch for bug 8384 next.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Moved test to t/db_dependent

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	C4/Installer/PerlDependencies.pm
(cherry picked from commit 4e2b90506d)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:32:25 -04:00
Mirko Tietgen 845a48898b Bug 7143 – Bug for tracking changes to the about page
This patch updates the German translators. To be applied after attachment 10681.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 67ead476aa)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:32:15 -04:00
Chris Cormack 01a2061276 Bug 7143 : Adding Stacey Walker to the history
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:32:02 -04:00
Mark Tompsett 652a8018f0 Bug 8356 - moveitem.tt and linkitem.tt have cataloging typo Changed urls from cataloging to cataloguing
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
correct typo

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2c2f919b8a)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:31:01 -04:00
Jared Camins-Esakov a9433b4b8d Bug 8384: Some Perl scripts do not compile
Fix syntax errors preventing the scripts misc/translator/text-extract2.pl
and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling.

Remove misc/migration_tools/build6xx.pl entirely since it refers to
columns that no longer exist in the Koha database, and has seemingly
had broken encoding since Koha switched from CVS to git (or before!).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Rebased as the TalkingTech code doesn't exist in 3.8.x
(cherry picked from commit f6e45171ba)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:30:48 -04:00
Alex Arnaud ec46db8009 Bug 7299 pass itemnumber in ILSDI holditem service
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bc42bf97cb)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:29:28 -04:00
Marc Veron 3c958ab16f Bug 8335 - Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl
Add PR.png (renamed file music.png from http://famfamfam.com/lab/icons/ )

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 29b1860526)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:24:36 -04:00
Chris Hall 4d35106b44 Bug 8323 fixing year sorting of a list
Signed-off-by: Marc Veron <veron@veron.ch>

Works as expected.

Caveat: If you edit the list in Opac, change the sort and then klick 'Save',
the List always is displayed in title order. This is du to the fact that
save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults
to 'title').
If you go back to lists, choose the list from List name, the param is
correct and the list displays in expected order.

It took quite a time to track  that down, I first thought that opac-shelves.pl
was broken.

However, current bug 8323 is not affected, signing off.

Marc

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2b8b926783)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:24:24 -04:00
David Cook aab7cafbcb Bug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:22:56 -04:00
Chris Cormack ebcede353d Bug 5327 : Follow up for TTParser test
(cherry picked from commit 0351ea525e)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:21:10 -04:00
Duncan Tyler 2eb76ec047 Bug 5327 : Added coverage to unit test for TTParser
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 796127e4b9)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:20:50 -04:00
Stacey Walker d43e8c42d4 bug 5327: added some tests for C4/Items.pm
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a44b3652d2)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:15:36 -04:00
Paul Poulain e1f804a4a7 bug 7630 follow-up : welcome #186 Mark Tompsett
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fc28be8ac3)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:09:52 -04:00
Mark Tompsett 8a2d3c9c66 Bug 7630 - Warning on moremember.pl about param without key Move "$error => 1," to its own conditional $template->param()
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-08-02 17:08:52 -04:00
Mark Tompsett 975c5c8980 Bug 8489: Revise Ubuntu install files
1) Changed ubuntu-pkg-check.sh to use lsb_release to determine version
   of ubuntu.{version}.packages file. If a versioned file does not
   exist, the user is warned, and ubuntu.packages is used. Told the
   user which file is being used. Caught apt-cache policy errors nicely.
   NOTE: ubuntu.packages MUST BE A COPY OF THE
   LATEST ubuntu.{version}.packages FILE!
2) Moved: ubuntu.packages -> ubuntu.10.04.packages
          ubuntu_maverick.packages -> ubuntu.10.10.packages
          ubuntu.precise.packages -> ubuntu.12.04 packages
             (last file created new, but effectively supersedes bug 8488)
3) Tweaked ubuntu.12.04.packages:
   * changed yaz3 references to yaz4
   * dropped libmysqlclient16-dev
   * changed libmysqlclient16 to libmysqlclient18
4) Copied the ubuntu.12.04.packages file to ubuntu.packages

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-07-21 12:16:53 -04:00
Jared Camins-Esakov 634f83aceb Don't run testcritic on directories that can't pass 2012-07-13 09:14:03 -04:00
Paul Poulain a30aeeaa53 bug 6350 (history.txt) fixing typo
decmember is not a month afaik ;-)
(cherry picked from commit 9285b2899f)
2012-07-13 09:14:02 -04:00
Chris Cormack 87ca800708 Bug 6350 : Updating history
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	docs/history.txt
(cherry picked from commit 42a46b481a)
2012-07-13 09:14:01 -04:00
Mason James 69c3f794a9 Bug 8315 - fix 'C4::Output 3.02' errors in Koha
modified:   opac/opac-ratings-ajax.pl
	modified:   opac/opac-tags.pl
	modified:   tags/review.pl

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-07-13 09:14:00 -04:00
Sophie Meynieux 6b9680b212 Bug 8191 : Adding a new value to 8 position of coded data field 100
From july 2012, unimarc norm evolves and the value k "monograph with both publication date and print date" must be added for this position.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked the new value shows up and is correctly copied into the field.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 83874c6214)
2012-07-13 09:13:59 -04:00
Marcel de Rooy 7656f3dc7d Bug 7143 Followup for timeline
Fixes few tabs within date; adds a regex to fix mistakes with spaces.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ee53a0c6fa)
2012-07-13 09:13:59 -04:00
Matthias Meusburger 6b1ca78dd3 Bug 8282: Bug in modules list in about.pl
Last modules were not displayed if the number of modules did not match the number of rows of the table (when $number_of_modules % 4 != 0)

Signed-off-by: Marc Veron <veron@veron.ch>

Added some code to about.tt to have empty the last remaining cells, not sure if an other signoff is needed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7d237f22ad)
2012-07-13 09:13:58 -04:00
Paul Poulain 645783c253 Bug 8289 Upgrading from 2.2 does not work anymore
The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4cb0aa5d30)
2012-07-13 09:13:57 -04:00
Maxime Pelletier bda0612fcc Bug 6634 : 3 more cases of manager_id not populated
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d43ec92b6c)
2012-07-13 09:13:56 -04:00
Chris Cormack 18c047f4e4 Fixing whitespace issues. Note to Paul, docs/history.txt is a tab
separated text file.
(cherry picked from commit e4acd9e24f)
2012-07-13 09:13:55 -04:00
Paul Poulain 8bde392a56 Adding Claire Hernandez as contributor + adding missing contributors in about.tt
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-07-13 09:11:32 -04:00
Claire Hernandez 13cc8c20a1 Bug 7994: Fix pref yaml errors
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-07-12 22:31:37 -04:00
Claire Hernandez 7715c3e97f Bug 7994: scripts to check yaml files
$ prove yaml_valid.t
checks a closed list of files
$ perl yaml_valid.pl -f myfile.yaml
try to load a yaml file with YAML::LoadFile and show errors

(both files pertidied)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5cb8c9f6e4)
2012-07-12 22:29:54 -04:00
Colin Campbell 29c50ccbf0 Bug 8216: Allow SIP modules to pass critic tests
Add C4/SIP to perlcritic tests. Fix those issues that were
generating perlcritic errors

Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-07-12 22:29:29 -04:00
Jared Camins-Esakov b79a3e1b3f Bug 6720: show authority type in auth details
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Authority type on detail page in staff now shows correctly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4b38fb0d43)
2012-07-12 22:26:15 -04:00
Katrin Fischer 64dce5ac62 Bug 8232: Comments in OPAC contain untranslatable javascript messages
To test:
- add a new comment to a record in the OPAC
- Your comment (preview, pending approval) is not translatable
- update po files by running 'perl translate update <language>'
- Open po file and check if strings are there, translate
- install language again by running 'perl translate install <language>'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-07-12 22:25:22 -04:00
Marcel de Rooy 97c0183f1e Bug 7367 Followup for opac-suggestions template
This small typo was found by Albert Oller.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Very trivial fix.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 89e115c4d9)
2012-07-12 22:24:29 -04:00
Marcel de Rooy 282097dec0 Bug 7368 Followup for history.txt Only correcting whitespace for correct placement in about form
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Very trivial.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	docs/history.txt

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-12 22:23:06 -04:00
Robin Sheat f449571a28 Bug 8222 - make the zipcode no longer mandatory
Having the zipcode field mandatory by default is a bit annoying for
places where no one cares about it. This patch stops it being the case
on new installs.

Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fe5214ba5e)
2012-07-12 22:20:37 -04:00
Mason James e7b43c6ff9 patch for Bug 8226 - 'OpacFooter' markup/css improvements
Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4b1666e0bd)
2012-07-12 22:20:28 -04:00
christophe croullebois f5b75e4a85 Bug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl
In rebuild_zebra.pl, if we are in "unimarc" ("marcflavour" syspref), the sub "fix_unimarc_100" is called and checks if 100$a lenght is equal to 35.
If it is not the case, the sub inserts the localtime and more, so we loose the datas in reindexing.
The standart lenght is 36.
I have just changed 35 to 36.

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 68c6e00f16)
2012-07-12 22:19:52 -04:00
Sophie Meynieux f74fa05ece Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d928740952)
2012-07-12 22:19:47 -04:00
Sophie Meynieux 89fe898ffe Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted beacause on loan.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 45784a7183)
2012-07-12 22:19:38 -04:00
Christophe Croullebois 9afc11a9eb Bug 7329: Items onloan are deleted when undoing import into catalog
this patch checks the "on loan" and "reserved" status before deleting item, and
do noting in this case, so the record can't be deleted due to existing item.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0b39f30a69)
2012-07-12 22:19:33 -04:00
Kyle M Hall 556eb39c49 Bug 6141 - html glitches causing problems to translator - 3.8.x
* opac-topissue.pl = untranslatable string removed
* authorities.pl missing _() in javascript

Rewrite of patch authored by Julian Maurice.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8403c9d2c7)
2012-07-12 22:18:05 -04:00
Dobrica Pavlinusic 8a2f03dc92 Bug 7952 - followup to fix t/Creators.t
Since we are now using temporary file, we are creating test.pdf
at end of test and checking if it exists and have non-zero size.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7526cc1042)
2012-07-12 22:17:14 -04:00
Dobrica Pavlinusic cbadc3ff96 Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser
Without name option to prFile, PDF::Reuse opens '-' file which is real
console STDOUT on plack so pdf file gets emited to terminal instead of
sending it to browser.

This change creates temporary file using File::Temp, pass it to PDF::Reuse
and then reads it back and prints it out for plack (or CGI) to pick up.

Test secenario:

1. Home › Tools › Patron Card Creator › Manage Card Batches
2. select batch checkbox and click Export
3. select template and click Export
4. click on pdf file to download it

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e2e80737d3)
2012-07-12 22:17:13 -04:00
Owen Leonard e80a0c3153 Bug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html
Implementing fix as suggested by Chris Cormack:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171#c4

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dc0cf0b329)
2012-07-12 22:16:18 -04:00
Frédéric Demians ecdb741b2b Bug 4838 Fix repeated authorities selection
How to test:

Create an authority, with more than one heading, for example a
UNIMARC multilingual author:

  200 $7 da
      $a 原
      $b 純輔
  200 $7 ba
      $a Hara
      $b Junsuke

In data entry form, on 700 field, you click on ... Search for the above author.
In auhtority search result page, you just have a 'Choose' link, and so you just
can select the first heading (in Chinesse writing).

Apply the patch. Repeat. Now you have, on result page, you have two links, and
can select one heading or the other.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c215ba8117)
2012-07-12 22:15:55 -04:00