gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 8383: Add test to check that Perl scripts compile 

This patch adds t/db_dependent/00-strict.pl which tests that all Perl
scripts compile. I chose to use Test::Strict so that in the future we
can also have the test check that "use strict" and "use warnings" are
enabled.

To test:
1. Run t/db_dependent/00-strict.pl.
2. Run around waving your arms in the air that we have a couple of
   scripts that don't compile.
3. Actually, that's about it. You could test my patch for bug 8384 next.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Moved test to t/db_dependent

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	C4/Installer/PerlDependencies.pm
(cherry picked from commit 4e2b90506d)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
Jared Camins-Esakov 2012-07-08 22:06:28 -04:00
parent 845a48898b
commit bb208e9852
3 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
C4/Installer/PerlDependencies.pm
View File

@ -489,6 +489,10 @@ our $PERL_DEPS = {
'required' => '1',
'min_ver' => '0.03',
},
'Test::Strict' => {
'usage' => 'Core',
'required' => '0.14',
}
};
1;

1
debian/control vendored
View File

@ -67,6 +67,7 @@ Build-Depends: libcgi-session-driver-memcached-perl,
libsms-send-perl,
libtemplate-perl,
libtest-simple-perl | perl-modules,
libtest-strict-perl,
libtext-csv-encoded-perl,
libtext-csv-perl,
libtext-csv-xs-perl,

24
t/db_dependent/00-strict.t Normal file
View File

@ -0,0 +1,24 @@
# This script is called by the pre-commit git hook to test modules compile
use strict;
use warnings;
use Test::More;
use Test::Strict;
use File::Spec;
use File::Find;
use lib("misc/translator");
use lib("installer");
my @dirs = ( 'acqui', 'admin', 'authorities', 'basket',
'catalogue', 'cataloguing', 'changelanguage.pl', 'circ', 'debian', 'docs',
'edithelp.pl', 'errors', 'fix-perl-path.PL', 'help.pl', 'installer',
'koha_perl_deps.pl', 'kohaversion.pl', 'labels',
'mainpage.pl', 'Makefile.PL', 'members', 'misc', 'offline_circ', 'opac',
'patroncards', 'reports', 'reserve', 'resetversion.pl', 'reviews',
'rewrite-config.PL', 'rotating_collections', 'serials', 'services', 'skel',
'sms', 'suggestion', 'svc', 'tags', 'tools', 'virtualshelves' );
$Test::Strict::TEST_STRICT = 0;
$Test::Strict::TEST_SKIP = [ 'misc/kohalib.pl', 'sms/sms_listen_windows_start.pl' ];
all_perl_files_ok(@dirs);