Commit Graph

9031 Commits

Author SHA1 Message Date
Michael Hafen e75ff02b6f bugfix: Add a message to circulation.pl if item is restricted
Don't know how this was missed.  If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.

This adds a message saying "item is restricted".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:39:24 +01:00
Henri-Damien LAURENT 54aba455fd Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:34:04 +01:00
Joe Atzberger 002804a7d3 Bug 2587 followup, updated test.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:30:01 +01:00
Joe Atzberger 4094f9522f Convert to C4::Debug, comment out unused Data::Dumper.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:29:49 +01:00
Andrew Moore ff0c8d1f31 bug 2628: fixing test script to deal with DESTDIR in Makefile.PL
Recently, there were changes to the Makefile.PL to make it install in a
DESTDIR that the OS (debian) may choose. This broke the test suite.
Since we're not installing the stuff in the t/ directory, we need to
ignore the DESTDIR specifiation before we write the test-config.txt.
So, this patch adds a call to the _strip_destdir function for all
directories written to the t/test-config.txt file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:29:32 +01:00
Joe Atzberger f2c1fc5793 Revising the stub for ILS/Transaction/FeePayment.pm
Obviously more implementation is needed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:29:18 +01:00
Galen Charlton c93c1fc8a1 bug 2625: finish fix by converting another array to hash
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:08:10 +01:00
Clay Fouts 4322e8bf2e bug 2625
Using the barcode as an index for assigning values to an array creates problems if
the numeric value of the barcode is sufficiently large to consume enough memory to
starve other processes. This patch changes return_failed from an indexed array into
an associative one, using the barcode as the key.

Signed-off-by: Ryan Higgins <rch@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:08:03 +01:00
Henri-Damien LAURENT e02214e1ee Altering system log search form to conform with other similar forms; escaping output of "info" variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>

Conflicts:

	koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tmpl
2008-11-12 12:08:41 +01:00
Joe Atzberger e934749b20 DHTMLcalendar should not be imported.
Changing these scripts as precursor to removing it from C4::Dates @EXPORT_OK

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 11:33:53 +01:00
Henri-Damien LAURENT 0ccdcbc058 Bug 2600 : escaping information in returns.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>

Conflicts:

	koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl
2008-11-12 11:30:46 +01:00
Henri-Damien LAURENT 32e23b8659 A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
and keep ability to hyperlink URL fields in MARC detail display
2008-11-12 11:23:37 +01:00
Henri-Damien LAURENT 3063d08e51 Bug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)
Using $item->{$hbranch} rather than $item->{homebranch}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 11:23:37 +01:00
Michael Hafen 74d7ce8ce6 bugfix: need to return something if an itemtype doesn't have an image
I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template.  I don't understand why, but this fixes it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 19:16:49 +01:00
Galen Charlton 492ff3a3c8 bug 2582 [1/2]: don't set issuedate during renewal
Changed so that issues.issuedate is never modified
during a renewal, since that column records the original
date of the loan.  Changed the name and interpretation
of the $issuedate parameter of AddRenewal() to
$lastreneweddate, allowing (e.g.) offline circulation
to set the date of the renewal without changing the
issue date.

As a result of the original bug, issues.issuedate can be
set to NULL for loans that were renewed via the OPAC,
self checkout, or the staff interface when explicitly
renewing a loan.  Loans that were renewed by checking
the item out to the same patron will have the issue date
changed to the date of the last renewal.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 19:15:54 +01:00
Galen Charlton 58d7bac4c1 fixing permission 2008-11-04 19:13:03 +01:00
Henri-Damien LAURENT 171c9f2fe4 Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 19:11:38 +01:00
Henri-Damien LAURENT 9c49d23515 Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 19:08:23 +01:00
Owen Leonard cec621ac16 Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 19:05:10 +01:00
Henri-Damien LAURENT 573db18e2e Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 19:04:07 +01:00
Henri-Damien LAURENT 40ebc9e5fd If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 19:01:52 +01:00
Joe Atzberger 0f4fde507d Minor SIP cleanup, conditionalize warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:53:41 +01:00
Henri-Damien LAURENT f24028da02 Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:51:45 +01:00
Jesse Weaver 369fcd22a5 Fix itemtype image problem in moremember.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:47:37 +01:00
Joe Atzberger 3a2ddbe050 issues_stats returns empty results if row/column = items.ccode/datetime
Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
    B&T Rental--Fiction
The Tidy error associated would be:
    line 574 column 29 - Error: general entity "T" not defined and no default entity

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:46:10 +01:00
Henri-Damien LAURENT 32796a847f fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>

Conflicts:

	C4/Koha.pm
	catalogue/search.pl
	opac/opac-search.pl
2008-11-04 18:44:35 +01:00
Vincent Danjean e1cd39b1a1 Removing strange dot file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:49:00 +01:00
Andrew Moore 0075446907 bug 2503: tests for C4::Circulation
I'm adding some tests for C4::Circulation methods that I'm altering
to allow the offline circulation tool to use C4::Circulation to upload
its data. These test a bit of the old functionality and try to show
that the new functionality does what I think it does.

C4::Circ::Addissue to tests issuedate
 these also test AddRenewal.
tests for C4::Circ::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:47:08 +01:00
Andrew Moore 3ab856ff35 bug 2503: adding dates to some C4:Circulation methods to allow offline circulation tool to specify dates other than today
When uploading an offline circulation file, some actions may need to take place
in the past. This patch adds date parameters to some C4::Circulation methods
to allow us to set dates on them

added issuedate to C4::Circulation::AddIssue
adding issuedate to C4::Circulation::AddRenewal
adding returdate to C4::Circulation::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:44:33 +01:00
Ryan Higgins 3db68bc704 bug 2530 : create new date object in javascript function instead of modifying passed-in reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:43:33 +01:00
Andrew Moore 644b97fe81 bug 2526: removing DEBUG flag from C4::Search
The DEBUG flag was left turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:40:38 +01:00
Henri-Damien LAURENT ebe3bf9dc2 Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:38:16 +01:00
Galen Charlton 7abfefa099 bug 2523: add columns to holds queue report
* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title

As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.

This patch includes the final component of the fix
for bug 2331.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:18:06 +01:00
Henri-Damien LAURENT bb3d3afe6e Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 23:29:37 +01:00
Galen Charlton 6c168bf22b bug 2341: OPAC title-level holds permitted when items are on-order
Changed so that the presence of an on-order item (items.notforloan =- -1)
permits a title-level hold request to be made.  Prior to this patch,
if all of the items linked to the bib were on-order, no title-level
request was permitted.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:53:15 +01:00
Galen Charlton 20c397cd38 bug 2520: don't change item-level requests to bib-level
Prior to this fix, changing the priority of any hold requests
in the queue of requests for a bib would convert
all item-level requests to title-level requests.

As part of this fix, improved display of the holds queue
so that item-level and bib-level requests can be more
clearly distinguished.

Documentation note: new screenshot of list of requests for
a bib in the staff interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:51:38 +01:00
Galen Charlton 1c69c063dc bug 2521: distinguish types of hold requests
Title-level and item-level requests are now more
clearly distinguished in the patron details page
and the patron checkout page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:51:06 +01:00
Galen Charlton 034dd5242e bug 2518: remove useless patron and branch lookups
AddIssue does not use the results of the lookup
of the patron whose hold request was preempted
by the issue.  This patch now leaves a no-op in
the '$restype eq "Waiting"' test, but I'm not going to
refactor the hold cancellation logic now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:50:50 +01:00
Galen Charlton f964d0eb4c bug 2519: clear waitingdate if request is moved off waiting status
* Changed C4::Reserves::ModReserve so that if using it to take an
  item off the hold shelf, reserves.waitingdate is cleared.
* Improved POD.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:49:56 +01:00
Owen Leonard 298b877b8f Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:12:18 +01:00
Michael Hafen 2abafc5562 Reduce logging from rebuild_zebra.pl with a command line option
This reduces the output of the script and zebraidx, and creates a -v
command line switch which will increase the logging to their former
states.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:11:39 +01:00
Owen Leonard 775768e895 Eliminate left-column margin on print view
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
paul 16c9060f27 BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Pianohacker 2b040e76de fix date formatting in overdue_notices.pl
This makes overdue_notices.pl format dates in fields that both start and end with 'date'.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Frederic Demians 57fcd4884e Bugfix #2630 2nd attempt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Owen Leonard 2dcee6f6e6 Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Frederic Demians 2f0e739c16 Bugfix #2633
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Galen Charlton a04345b1d8 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Galen Charlton 40d52ff8f7 bug 2609: display correct requested title
In databases where biblionumber is not necessarily
the same as biblioitemnumber, the title of
certain hold requests displayed by moremember.pl
could be drawn from the wrong record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Ryan Higgins 26d15ff50a Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00