bug 2518: remove useless patron and branch lookups
AddIssue does not use the results of the lookup of the patron whose hold request was preempted by the issue. This patch now leaves a no-op in the '$restype eq "Waiting"' test, but I'm not going to refactor the hold cancellation logic now. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This commit is contained in:
parent
f964d0eb4c
commit
034dd5242e
|
|
@ -904,18 +904,11 @@ sub AddIssue {
|
|||
# warn "Waiting";
|
||||
# The item is on reserve and waiting, but has been
|
||||
# reserved by some other patron.
|
||||
my ( $resborrower ) = GetMemberDetails( $resbor, 0 );
|
||||
my $branches = GetBranches();
|
||||
my $branchname =
|
||||
$branches->{ $res->{'branchcode'} }->{'branchname'};
|
||||
}
|
||||
elsif ( $restype eq "Reserved" ) {
|
||||
|
||||
# warn "Reserved";
|
||||
# The item is reserved by someone else.
|
||||
my ( $resborrower ) = GetMemberDetails( $resbor, 0 );
|
||||
my $branches = GetBranches();
|
||||
my $branchname = $branches->{ $res->{'branchcode'} }->{'branchname'};
|
||||
if ($cancelreserve) { # cancel reserves on this item
|
||||
CancelReserve( 0, $res->{'itemnumber'},
|
||||
$res->{'borrowernumber'} );
|
||||
|
|
|
|||
Loading…
Reference in New Issue