Commit Graph

9010 Commits

Author SHA1 Message Date
Joe Atzberger 0f4fde507d Minor SIP cleanup, conditionalize warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:53:41 +01:00
Henri-Damien LAURENT f24028da02 Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:51:45 +01:00
Jesse Weaver 369fcd22a5 Fix itemtype image problem in moremember.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:47:37 +01:00
Joe Atzberger 3a2ddbe050 issues_stats returns empty results if row/column = items.ccode/datetime
Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
    B&T Rental--Fiction
The Tidy error associated would be:
    line 574 column 29 - Error: general entity "T" not defined and no default entity

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 18:46:10 +01:00
Henri-Damien LAURENT 32796a847f fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>

Conflicts:

	C4/Koha.pm
	catalogue/search.pl
	opac/opac-search.pl
2008-11-04 18:44:35 +01:00
Vincent Danjean e1cd39b1a1 Removing strange dot file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:49:00 +01:00
Andrew Moore 0075446907 bug 2503: tests for C4::Circulation
I'm adding some tests for C4::Circulation methods that I'm altering
to allow the offline circulation tool to use C4::Circulation to upload
its data. These test a bit of the old functionality and try to show
that the new functionality does what I think it does.

C4::Circ::Addissue to tests issuedate
 these also test AddRenewal.
tests for C4::Circ::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:47:08 +01:00
Andrew Moore 3ab856ff35 bug 2503: adding dates to some C4:Circulation methods to allow offline circulation tool to specify dates other than today
When uploading an offline circulation file, some actions may need to take place
in the past. This patch adds date parameters to some C4::Circulation methods
to allow us to set dates on them

added issuedate to C4::Circulation::AddIssue
adding issuedate to C4::Circulation::AddRenewal
adding returdate to C4::Circulation::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:44:33 +01:00
Ryan Higgins 3db68bc704 bug 2530 : create new date object in javascript function instead of modifying passed-in reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:43:33 +01:00
Andrew Moore 644b97fe81 bug 2526: removing DEBUG flag from C4::Search
The DEBUG flag was left turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:40:38 +01:00
Henri-Damien LAURENT ebe3bf9dc2 Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:38:16 +01:00
Galen Charlton 7abfefa099 bug 2523: add columns to holds queue report
* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title

As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.

This patch includes the final component of the fix
for bug 2331.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 17:18:06 +01:00
Henri-Damien LAURENT bb3d3afe6e Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 23:29:37 +01:00
Galen Charlton 6c168bf22b bug 2341: OPAC title-level holds permitted when items are on-order
Changed so that the presence of an on-order item (items.notforloan =- -1)
permits a title-level hold request to be made.  Prior to this patch,
if all of the items linked to the bib were on-order, no title-level
request was permitted.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:53:15 +01:00
Galen Charlton 20c397cd38 bug 2520: don't change item-level requests to bib-level
Prior to this fix, changing the priority of any hold requests
in the queue of requests for a bib would convert
all item-level requests to title-level requests.

As part of this fix, improved display of the holds queue
so that item-level and bib-level requests can be more
clearly distinguished.

Documentation note: new screenshot of list of requests for
a bib in the staff interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:51:38 +01:00
Galen Charlton 1c69c063dc bug 2521: distinguish types of hold requests
Title-level and item-level requests are now more
clearly distinguished in the patron details page
and the patron checkout page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:51:06 +01:00
Galen Charlton 034dd5242e bug 2518: remove useless patron and branch lookups
AddIssue does not use the results of the lookup
of the patron whose hold request was preempted
by the issue.  This patch now leaves a no-op in
the '$restype eq "Waiting"' test, but I'm not going to
refactor the hold cancellation logic now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:50:50 +01:00
Galen Charlton f964d0eb4c bug 2519: clear waitingdate if request is moved off waiting status
* Changed C4::Reserves::ModReserve so that if using it to take an
  item off the hold shelf, reserves.waitingdate is cleared.
* Improved POD.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:49:56 +01:00
Owen Leonard 298b877b8f Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:12:18 +01:00
Michael Hafen 2abafc5562 Reduce logging from rebuild_zebra.pl with a command line option
This reduces the output of the script and zebraidx, and creates a -v
command line switch which will increase the logging to their former
states.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:11:39 +01:00
Owen Leonard 775768e895 Eliminate left-column margin on print view
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
paul 16c9060f27 BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Pianohacker 2b040e76de fix date formatting in overdue_notices.pl
This makes overdue_notices.pl format dates in fields that both start and end with 'date'.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Frederic Demians 57fcd4884e Bugfix #2630 2nd attempt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Owen Leonard 2dcee6f6e6 Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Frederic Demians 2f0e739c16 Bugfix #2633
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Galen Charlton a04345b1d8 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Galen Charlton 40d52ff8f7 bug 2609: display correct requested title
In databases where biblionumber is not necessarily
the same as biblioitemnumber, the title of
certain hold requests displayed by moremember.pl
could be drawn from the wrong record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Ryan Higgins 26d15ff50a Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Jesse Weaver de95e95c54 fix for bug 2556: Overlaying records sometimes creates new record
This makes "Try another search" in the Z39.50 search tool pass the biblionumber along, so that records are overlaid correctly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Owen Leonard fdb5179180 Corrections to fix javascript error in Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Owen Leonard 8a9be46d5b Altering system log search form to conform with other similar forms; escaping output of "info" variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:32 +01:00
Joe Atzberger 169669cb1c moredetail.pl is not an Exporter.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Ryan Higgins a4eccef1e9 Remove acquisitions permission requirement on catalogue/showmarc.pl
This script is linked to from z39.50 search as well as acquisitions.
cataloguing/z3950_search.pl requires only the 'catalogue' flag, so
requiring only that permission here.  A user without acquisitions permissions
would get a login instead of the record display without this change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Ryan Higgins 1c052fc398 Sort libraries by name in holds queue's select input.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Owen Leonard b0c30f6929 Change missing from previous commit re:Bug 2600.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Owen Leonard 6c6a405187 Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Owen Leonard 80fb54c58d Refining keyboard shortcuts javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Owen Leonard 14d59a3f7f Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Galen Charlton 1d34132f9d bug 2596: remove URL escaping added by previous patch
If URL in an href comes from a MARC record, it should not
be URL-escaped - otherwise, link is interpreted as relative
to MARCdetail.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Owen Leonard ce598a6e19 Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Owen Leonard 6bf60f4ba8 Fix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation of subfield descriptions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Danny Bouman bc1d872637 bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:31 +01:00
Owen Leonard 0afb3581de Can't escape title variable as HTML because of search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:30 +01:00
Owen Leonard 53aac3a662 Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:30 +01:00
Galen Charlton 816174a09c fix extra <td> introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:30 +01:00
Galen Charlton 0a99debd23 commenting out debug warns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:30 +01:00
Owen Leonard 1ebc415fe6 Correction to previous commit, removing debugging.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:30 +01:00
Owen Leonard 274e4049ff Formatting itemtype icon section with tabs to match authorized value interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:30 +01:00
Joe Atzberger 8c1bb827ff Remove double conditional, fix one FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00