Koha-clms/t/db_dependent
Tomas Cohen Arazi a9237380b5
Bug 20942: Split debit and credit lines
This patch splits the balance to match this object schema:

{
    balance             => #,
    outstanding_credits => {
        total => #,
        lines => [ credit_line_1, ..., credit_line_n ]
    },
    outstanding_debits  => {
        total => #,
        lines => [ debit_line_1, ..., debit_line_m ]
    }
}

This change is made to ease usage from the UI. Also because the
outstanding credits need to be applied to outstanding debits in order to
the balance value to make sense. So we still need to have each total.

Tests are added for this change, and the schema files are adjusted as
well.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: Tests pass!
- Sign off :-D

staff_id is changed into user_id as voted on the dev meeting the RFC got
approved.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit bb7c908dc0)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-08-02 14:43:03 +01:00
..
Acquisition Bug 20144: [sql_modes] Add default value for export_basket.description in tests 2018-02-13 13:58:57 -03:00
Auth
…
Authority Bug 14769: Put ControlledIndicators to work 2018-04-12 10:50:35 -03:00
Biblio Bug 20126: Add simple test for ModBiblioMarc 2018-02-02 12:08:42 -03:00
Circulation Bug 21023: Remove warning in t/db_dependent/Circulation/Chargelostitem.t 2018-07-15 20:14:01 +01:00
Creators Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests 2018-02-13 13:58:59 -03:00
Exporter Bug 18201: Tidy tests 2017-12-21 13:21:12 -03:00
Holds Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest 2018-02-13 13:02:23 -03:00
Illrequest Bug 7317: Remove traces of UnmediatedILL 2017-11-09 11:42:16 -03:00
Items Bug 20702: Add unit tests for GetHostItemsInfo 2018-06-27 09:50:15 +01:00
Koha Bug 20946: (QA follow-up) make outstanding_debits return the account lines only 2018-07-10 07:42:36 +01:00
LDAP
…
Labels Bug 20900: Add CPL branch in t_Batch.t too 2018-07-15 20:26:08 +01:00
Letters Bug 17561: (QA follow-up) Update existing unit tests 2018-06-05 12:47:35 +01:00
Members Bug 20531: (follow-up) Set the timestamps to the same value to get a correct order 2018-05-07 12:22:44 -03:00
OAI Bug 20665: Units tests for testing MySQL connection time zone 2018-05-03 12:46:55 -03:00
Patron Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly 2018-03-30 13:15:16 -03:00
Record
…
Reports Bug 20144: [sql_modes] Fix values when creating a sql report in tests 2018-02-13 13:59:00 -03:00
Reserves Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-05 12:47:18 +01:00
SIP Bug 18625: (QA follow-up) Unit tests 2018-04-11 16:45:10 -03:00
Search Bug 20144: [sql_modes] Fix search history tests 2018-02-13 13:59:00 -03:00
Serials Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:59:00 -03:00
Template/Plugin Bug 19655: Add tests 2017-11-26 12:59:31 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
XSLT_Handler
…
api/v1 Bug 20942: Split debit and credit lines 2018-08-02 14:43:03 +01:00
data
…
selenium Bug 19181: Do not screenshot 2018-05-14 10:36:12 -03:00
www Bug 18336: Full stack tests for supplemental UTF-8 chars 2018-02-16 17:53:42 -03:00
00-strict.t Bug 18055: (QA followup) Only print output if DEBUG 2018-03-28 15:53:12 -03:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 20906: Prevent test failures due to precision changes 2018-06-25 18:13:55 +01:00
Acquisition.t Bug 17457: Add tests for each marc flavour 2018-03-23 11:45:38 -03:00
AdditionalField.t Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:53 -03:00
Amazon.t
…
ArticleRequests.t Bug 20866: (QA follow-up) Use build_object and remove two tests 2018-06-11 09:56:30 +01:00
AudioAlerts.t
…
Auth.t Bug 20877: Do not consider DB user has permissions 2018-06-11 09:57:19 +01:00
Auth_with_cas.t Bug 19373: Update tests 2017-10-16 09:38:41 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t
…
BackgroundJob.t
…
Barcodes.t
…
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 9701: (follow-up) Adjust tests 2018-04-12 10:50:34 -03:00
Bookseller.t Bug 20906: Prevent test failures due to precision changes (2) 2018-06-25 18:13:55 +01:00
Breeding.t
…
Budgets.t Bug 18999: (QA followup) ModReceiveOrder expects a hashref 2017-09-29 13:03:38 -03:00
Calendar.t Bug 9031: (QA follow-up) Final changes to Calendar::days_between 2017-10-27 14:09:04 -03:00
Charset.t
…
Circulation.t Bug 20285: Unit Test 2018-06-15 13:13:00 +01:00
ClassSource.t
…
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
…
Context.t Bug 19788: Add a test 2017-12-22 13:15:37 -03:00
Contract.t
…
CourseReserves.t
…
DecreaseLoanHighHolds.t Bug 19705: Try to fix random failures from DecreaseLoanHighHolds.t 2018-01-23 17:01:29 -03:00
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
…
FrameworkPlugin.t Bug 20204: Add TestBuilder to replace CPL branch 2018-02-15 11:15:53 -03:00
Heading_MARC21.t
…
Hold.t Bug 18856: (QA follow-up) Rename method to avoid confusion 2018-05-17 11:40:03 -03:00
Holds.t Bug 19766: (bug 19058 follow-up) Fix Preview routing slip 2017-12-07 09:37:01 -03:00
HoldsQueue.t Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 21046: Return the correct borrowernumber when there is empty cardnumber(s) 2018-07-15 19:36:45 +01:00
Illrequestattributes.t Bug 7317: (followup) Make tests independent of data on the DB 2017-11-09 11:42:15 -03:00
Illrequests.t Bug 7317: (QA followup) Rename 'branch' for 'library' 2017-11-09 11:42:16 -03:00
ImportBatch.t Bug 20764: (QA follow-up) Fix path to sample plugins 2018-05-14 12:13:20 -03:00
Installer.t
…
Items.t Bug 18816: (QA follow-up) Convert param to hashref, fix typo 2018-04-06 14:51:15 -03:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz
…
Koha.t Bug 20144: [sql_modes] Correct quotes.timestamp values in tests 2018-02-13 13:58:54 -03:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 19581: Fix Koha_Elasticsearch.t 2018-04-09 17:44:20 -03:00
Koha_Elasticsearch_Indexer.t Bug 19581: Unit tests 2018-04-09 16:15:18 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 19502: Retrieve index.max_result_window from ES 2018-07-15 19:50:53 +01:00
Languages.t
…
Letters.t Bug 19855: Move getalert, addalert and delalert to Koha::Subscription 2018-04-23 14:22:15 -03:00
LibraryGroups.t Bug 20838: Add 2 small tests to check ref 2018-06-05 12:23:39 +01:00
Linker_FirstMatch.t
…
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t Bug 19069: Fix 'does not match' behaviour in MARC modification template 2017-10-27 14:09:01 -03:00
Members.t Bug 20590: Fix Members.t 2018-04-20 10:17:49 -03:00
MungeMarcPrice.t
…
NewsChannels.t
…
Overdues.t
…
Passwordrecovery.t Bug 20474: Mimick Letters.t 2018-03-27 12:21:44 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 9302: (QA follow-up) Consistency follow-up 2018-04-20 13:34:41 -03:00
Plugins.t Bug 20764: Fix Plugins.t 2018-05-14 13:09:37 -03:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t Bug 20097: (follow-up) Add a unit test 2018-03-19 13:54:50 -03:00
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
…
Reserves.t Bug 17561: (QA follow-up) Update existing unit tests 2018-06-05 12:47:35 +01:00
RotatingCollections.t Bug 16735: Migrate library search groups into the new hierarchical groups 2018-02-12 15:41:25 -03:00
Search.t Bug 19873: Add unit tests 2018-04-20 13:34:41 -03:00
Serials.t Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:56 -03:00
Serials_2.t
…
Service.t
…
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t Bug 17770: Perltidy 2017-12-21 13:09:16 -03:00
Stats.t Bug 20510: Remove unused sub TotalPaid from C4::Stats 2018-04-05 14:17:36 -03:00
SuggestionEngine_ExplodedTerms.t Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t 2017-11-01 13:10:18 -03:00
Suggestions.t Bug 13287: (QA follow-up) Extend Suggestions.t for DelSuggestionsOlderThan 2018-02-26 13:24:45 -03:00
Tags.t
…
Templates.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
TestBuilder.t Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty 2018-01-23 16:05:54 -03:00
Upload.t Bug 20081: Set inline headers for uploaded pdfs 2018-03-26 17:31:17 -03:00
UsageStats.t Bug 20264: Remove syspref checkdigit 2018-03-23 11:45:38 -03:00
Virtualshelves.t Bug 11943: Add unit test for double accepts 2018-05-11 10:52:44 -03:00
XISBN.t Bug 20321: Remove get_biblionumber_from_isbn 2018-03-19 13:55:47 -03:00
XSLT_Handler.t Bug 17807: Add format parameter to XSLT_Handler->transform 2017-08-30 15:06:40 -03:00
check_kohastructure.t Bug 19783: Move check_kohastructure.t to db_dependent 2018-01-19 15:13:56 -03:00
check_sysprefs.t
…
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl
…
rollingloans.t Bug 20900: Add CPL test branch in rollingloans.t 2018-07-15 20:25:21 +01:00
sysprefs.t
…
zebra_config.pl
…