gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20877: Do not consider DB user has permissions 

Test plan:
0/ Do not apply the patch
1/ Confirm the new test fails
2/ Apply the patch
3/ Confirm the new test passes
4/ Test the installation process

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2018-06-04 15:45:22 -03:00 committed by Martin Renvoize
parent 2bae585fcd
commit 6fe2a10156
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
C4/Auth.pm
View File

@ -2030,11 +2030,6 @@ sub haspermission {
$sth->execute($userid);
my $row = $sth->fetchrow();
my $flags = getuserflags( $row, $userid );
if ( $userid eq C4::Context->config('user') ) {
# Super User Account from /etc/koha.conf
$flags->{'superlibrarian'} = 1;
}
return $flags if $flags->{superlibrarian};

8
t/db_dependent/Auth.t
View File

@ -37,7 +37,7 @@ $schema->storage->txn_begin;
subtest 'checkauth() tests' => sub {
plan tests => 2;
plan tests => 3;
my $patron = $builder->build({ source => 'Borrower', value => { flags => undef } })->{userid};
@ -63,6 +63,12 @@ subtest 'checkauth() tests' => sub {
});
( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
is ( $userid, undef, 'If DB user is used, it should not be logged in' );
my $is_allowed = C4::Auth::haspermission( $db_user_id, { can_do => 'everything' } );
# FIXME This belongs to t/db_dependent/Auth/haspermission.t but we do not want to c/p the pervious mock statements
ok( !$is_allowed, 'DB user should not have any permissions');
C4::Context->_new_userenv; # For next tests
};