gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/Koha
History
Jonathan Druart 86395f2282 Bug 15839: Koha::Reviews - Add Koha::Review[s] classes 
The subroutines in C4::Reviews are only doing CRUD operations.
This patch set moves them to 2 new Koha::Review[s] classes.

Test plan for the whole patch set:
0/ Set the reviewson syspref
1/ At the OPAC, create a couple of reviews for a record
Try and create a review without html tags different that br b i em big
small strong: You should get a warning.
2/ Edit a review
3/ On the Staff interface, you should see a "Comments pending approval"
link on the mainpage
4/ Approve 1 review and delete the other
5/ At the OPAC you should only see 1 review (the approved one) in the
"Comments" tab
6/ Modify the review
7/ The review should appear again in the "comments awaiting moderation"
tab.
Note that even the comment has not been changed, it will have to be
reapproved (FIXME later). This behavior already existed prior to this
patch.

Tested all patches together (with database updated)
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
 		2016-09-09 10:29:31 +00:00
..
Account Bug 15675: Fix conflict with bug 15446 (type vs _type) 2016-03-02 03:24:46 +00:00
Acquisition Bug 15531: (followup) Use a quantity of 1, not null, for standing orders 2016-04-29 13:07:18 +00:00
Authority Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
BiblioUtils Bug 12478: fix some issues on rebase 2016-04-26 20:20:09 +00:00
Cache Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language 2016-06-04 07:43:22 +00:00
Config Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
Edifact Bug 7736 [QA Followup] - Fix spelling and pod errors 2016-04-01 20:03:19 +00:00
ElasticSearch Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
Exporter Bug 15451: Do not considered a Resultset as a Result 2016-07-22 17:18:36 +00:00
Filter/MARC Bug 11592: Add should_hide_marc method to filter 2016-09-08 11:54:16 +00:00
Indexer Revert Bug 11081 - Port Koha::Contrib::Tamil indexer into Koha code base 2016-03-01 16:56:35 +00:00
Item Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s] 2016-09-02 13:56:03 +00:00
List
…
MetadataRecord Bug 16708 - (QA followup) Fix pod copy/paste error 2016-06-24 11:59:40 +00:00
Misc Bug 16011: $VERSION - Remove use vars qw(); 2016-03-24 17:20:39 +00:00
Number Bug 16768 - Add official number format for Switzerland: 1'234'567.89 2016-06-24 14:00:03 +00:00
OAI/Server Bug 15527: Add a stylesheet for OAI-PMH to aid usability 2016-03-24 17:28:38 +00:00
Old Bug 14695 [QA Followup] - Fix method names 'type' to '_type' 2016-09-03 00:21:22 +00:00
Patron Bug 16911: ->get_expiry_date accepts strings 2016-09-09 09:45:32 +00:00
Plugins Bug 16975 : @INC should not have '.' as its last entry 2016-08-04 19:39:11 +00:00
QueryParser/Driver Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
REST Bug 14868: (QA followup) POD fixes 2016-09-02 12:20:37 +00:00
RecordProcessor Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
SMS Bug 15548 [QA Followup] - More new uses of Koha::Borrower 2016-03-03 14:39:00 -07:00
Schema/Result Bug 16573 - Update Schema 2016-09-06 09:37:14 +00:00
SearchEngine Bug 16489: ES code incorrectly refers to Moose 2016-05-12 16:06:18 -06:00
Sitemapper Bug 11190: (QA followup) for tests on jenkins 2015-08-31 10:32:34 -03:00
Subscription Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
SuggestionEngine Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Template/Plugin Bug 16851: Move HasOverdues to Koha::Patron->has_overdues 2016-09-09 09:57:59 +00:00
Util Bug 8064: Merge several biblios 2015-11-09 15:08:57 -03:00
AdditionalField.pm Bug 10855: Remove additional field values when subscription is removed 2015-10-02 15:10:31 -03:00
AudioAlert.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
AudioAlerts.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
AuthUtils.pm Bug 16818: External auth redirect broken under Plack 2016-08-04 19:42:44 +00:00
AuthorisedValue.pm Bug 12478: Add Koha::AuthorisedValue[s] class 2016-04-26 20:20:10 +00:00
AuthorisedValues.pm Bug 12478: Add Koha::AuthorisedValue[s] class 2016-04-26 20:20:10 +00:00
Authorities.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Authority.pm Bug 16708: Fix authority reindex for ElasticSearch 2016-06-24 11:59:40 +00:00
Biblio.pm Bug 14694 - Make decreaseloanHighHolds more flexible 2016-03-07 17:48:51 +00:00
BiblioFramework.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
BiblioFrameworks.pm Bug 14889: Fix typo in Koha/BiblioFrameworks.pm 2016-03-03 20:32:47 +00:00
BiblioUtils.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
Biblioitem.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Biblioitems.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Biblios.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Cache.pm Bug 17189 [QA Followup] - Missing $ on $key var for unsafe variant 2016-09-08 12:19:30 +00:00
Caches.pm Bug 11921: (QA followup) Remove remaining unused var 2016-09-08 10:29:00 +00:00
Calendar.pm Bug 17189: Replace occurrences of 'use Koha::Cache' 2016-09-08 10:24:47 +00:00
Checkout.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
Checkouts.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
Cities.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
City.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Config.pm Bug 11921: (QA followup) Remove remaining unused var 2016-09-08 10:29:00 +00:00
CsvProfile.pm Bug 15451: Add the 2 new modules Koha::CsvProfile[s] 2016-07-22 17:18:34 +00:00
CsvProfiles.pm Bug 15451: Add the 2 new modules Koha::CsvProfile[s] 2016-07-22 17:18:34 +00:00
Database.pm Bug 16445: Revert changes made by bug 12478 to Koha/Database.pm 2016-05-05 19:51:01 +00:00
DateUtils.pm Bug 16848: Prevent invalid warning to be carped from output_pref 2016-08-10 13:43:34 +00:00
EDI.pm Bug 16288: Remove Reference to obsolete EAN syspref 2016-05-16 17:14:56 +00:00
Edifact.pm Bug 7736: Support Ordering via Edifact EDI messages 2016-04-01 20:03:17 +00:00
ElasticSearch.pm Bug 12478: Move mapping attributes to the join table 2016-04-26 20:20:11 +00:00
Email.pm
…
Exceptions.pm Bug 14048: Add RefundLostItemFeeRule table and classes 2016-07-07 10:37:01 -06:00
FrameworkPlugin.pm Bug 9006: Remove AUTOLOAD in C4::Context 2015-07-20 10:11:41 -03:00
Hold.pm Bug 14642: Make sure the log will be written only if the hold has been deleted 2016-08-17 18:43:13 +00:00
Holds.pm Bug 14695 [QA Followup] 2016-09-08 12:44:50 +00:00
I18N.pm
…
Issue.pm Bug 16086: Add Issues Koha object. 2016-04-07 00:31:21 +00:00
Issues.pm Bug 16086: Add Issues Koha object. 2016-04-07 00:31:21 +00:00
IssuingRule.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
IssuingRules.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Item.pm Bug 16686: Rename the transfer method to get_transfer 2016-09-02 13:56:03 +00:00
ItemType.pm Bug 12478: Add Koha::ItemType[s] classes 2016-04-26 20:20:10 +00:00
ItemTypes.pm Bug 12478: Add Koha::ItemType[s] classes 2016-04-26 20:20:10 +00:00
Items.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Libraries.pm Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library 2016-09-08 14:36:04 +00:00
Library.pm Bug 15446 [QA Followup] - Update new classes 2016-02-12 12:35:57 -07:00
LibraryCategories.pm Bug 15446 [QA Followup] - Update new classes 2016-02-12 12:35:57 -07:00
LibraryCategory.pm Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) 2016-02-24 03:55:05 +00:00
Linktracker.pm
…
Localization.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Localizations.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Logger.pm Bug 14167: (QA followup) use warn instead of just STDERR 2015-07-21 10:50:17 -03:00
MetaSearcher.pm Bug 17189: Use Koha::Caches instead of Koha::Cache in Koha::MetaSearcher 2016-09-08 10:24:47 +00:00
MetadataIterator.pm Bug 12478 - authorities can now be stored in ES 2016-04-26 20:20:03 +00:00
MetadataRecord.pm Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield 2016-09-02 14:00:11 +00:00
News.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
NewsItem.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
NorwegianPatronDB.pm Bug 16011: $VERSION - Remove comments 2016-03-24 17:20:29 +00:00
Object.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Objects.pm Bug 16889: Add Koha::Objects->columns 2016-07-15 18:12:12 +00:00
OldIssue.pm Bug 16087: Add Koha::OldIssues objects. 2016-04-07 00:18:40 +00:00
OldIssues.pm Bug 16087: Add Koha::OldIssues objects. 2016-04-07 00:18:40 +00:00
Patron.pm Bug 16851: Move HasOverdues to Koha::Patron->has_overdues 2016-09-09 09:57:59 +00:00
Patrons.pm Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Plugins.pm Bug 16975 : @INC should not have '.' as its last entry 2016-08-04 19:39:11 +00:00
Rating.pm Bug 17089: Mark out the boundaries of ratings 2016-09-09 09:31:30 +00:00
Ratings.pm Bug 17089: Koha::Ratings - Remove GetRating 2016-09-09 09:31:29 +00:00
RecordProcessor.pm Bug 15870: potential follow up to comment #8 2016-03-24 20:15:40 +00:00
RefundLostItemFeeRule.pm Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
RefundLostItemFeeRules.pm Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
Review.pm Bug 15839: Koha::Reviews - Add Koha::Review[s] classes 2016-09-09 10:29:31 +00:00
Reviews.pm Bug 15839: Koha::Reviews - Add Koha::Review[s] classes 2016-09-09 10:29:31 +00:00
Schema.pm
…
SearchEngine.pm Bug 12478: make things using SimpleSearch use the new version 2016-04-26 20:20:07 +00:00
SearchField.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
SearchFields.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
SearchMarcMap.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
SearchMarcMaps.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
Serial.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Serials.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
SimpleMARC.pm Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
Sitemapper.pm Bug 11190: (QA followup) for tests on jenkins 2015-08-31 10:32:34 -03:00
Subscription.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Subscriptions.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Suggestion.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
SuggestionEngine.pm Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Suggestions.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
Token.pm Bug 16929: [QA Follow-up] Shortcut methods and use statements 2016-08-10 13:26:00 +00:00
Upload.pm Bug 14686: [QA Follow-up] Move allows_add_by to Upload.pm 2016-04-27 16:14:18 +00:00
Virtualshelf.pm Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Virtualshelfcontent.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfcontents.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfshare.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfshares.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelves.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
XSLT_Handler.pm Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00