Bug 16489: ES code incorrectly refers to Moose
Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
This commit is contained in:
parent
c2ddc19600
commit
9d9f2efa94
|
|
@ -17,9 +17,10 @@ package Koha::SearchEngine::Zebra::QueryBuilder;
|
|||
# You should have received a copy of the GNU General Public License
|
||||
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
||||
|
||||
use base qw(Class::Accessor);
|
||||
use Modern::Perl;
|
||||
use Moose::Role;
|
||||
|
||||
use base qw(Class::Accessor);
|
||||
|
||||
use C4::Search;
|
||||
use C4::AuthoritiesMarc;
|
||||
|
||||
|
|
|
|||
|
|
@ -17,10 +17,6 @@ package Koha::SearchEngine::Zebra::Search;
|
|||
# You should have received a copy of the GNU General Public License
|
||||
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
||||
|
||||
# I don't think this ever worked right
|
||||
#use Moose::Role;
|
||||
#with 'Koha::SearchEngine::SearchRole';
|
||||
|
||||
use Modern::Perl;
|
||||
|
||||
use base qw(Class::Accessor);
|
||||
|
|
|
|||
Loading…
Reference in New Issue