gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Fridolyn SOMERS 5f4fce34b4 Bug 9504: URL escape in OPAC more searches 
OPACSearchForTitleIn is a syspref used to add links as "more searches" in OPAC record detail page.
The links can contain vars depending on record values like title, ISBN, ...
Thoses values must be URL-escaped because they can contain special characters that will brake URL and/or HTML.

This patch add a method C4::Output::parametrized_url() that replaces vars in URL usign escape and UTF-8 encoding.

Test plan :
- Define in OPACSearchForTitleIn a link with all possible vars : TITLE, AUTHOR, ISBN, ISSN, CONTROLNUMBER, BIBLIONUMBER
- Edit a record to add special characters in title : ", &, ? ...
- Go to OPAC detail pages of this record
=> Check that URL is well encoded
=> Click on link to check the term is well encoded (diacritical characters, ...)

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Nice test plan, thanks!

Verified bug and fix - both look good.
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
 		2013-03-29 19:44:19 +13:00
..
AuthoritiesMarc Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Barcodes Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm 2012-09-20 12:01:36 +02:00
ClassSortRoutine Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Creators Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm 2012-09-20 12:17:07 +02:00
External Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm 2012-09-20 11:38:45 +02:00
Form Talking Tech Support - Phase I - Followup - Fix Messaging Preferences 2012-06-10 17:46:58 +02:00
Heading Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ILSDI Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services 2012-10-05 17:39:21 +02:00
Installer Bug 9053: Test::MockModule and DBD::Mock should be required 2012-11-12 09:43:40 -05:00
Labels Bug 6448 [3/3] EAN-13 barcode labels 2012-08-02 18:41:36 +02:00
Linker Bug 8447: Make sure we have enough subfields for broader_headings 2012-09-14 14:56:48 +02:00
Members Bug 7955: Followup : Check the syspref value (avoid sql injection) 2012-08-01 16:06:38 +02:00
OAI Bug 6440: Implement OAI-PMH Sets 2012-03-20 11:38:26 +01:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Reports Bug 7993 follow-up to fix POD DOC 2012-09-19 12:12:43 +02:00
SIP Bug 9343: handles the new format of Debarred [3.10.x] 2013-02-04 10:39:37 +13:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Utils Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
VirtualShelves Bug 9174: Fix itemtype image display in OPAC lists 2013-02-02 19:37:10 +13:00
Accounts.pm Bug 9122: fix the problem when writing-off a fine 2012-11-23 09:09:53 -05:00
Acquisition.pm Bug 9454: Use placeholders when adding basket 2013-02-16 18:28:29 +13:00
Auth.pm Bug 9102 : Set HttpOnly on the CGISESSID cookie 2013-01-13 08:01:23 +13:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 8279: CAS Debugging improvements 2012-06-27 18:05:02 +02:00
Auth_with_ldap.pm Bug 8919 - ExtendedPatronAttributes not populated from LDAP 2012-11-08 12:42:52 -05:00
AuthoritiesMarc.pm BUG 9145: Authorities: standard language for UNIMARC 2013-02-21 18:44:16 +13:00
BackgroundJob.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm 2012-09-20 12:01:40 +02:00
Barcodes.pm Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm 2012-09-20 12:01:36 +02:00
Biblio.pm Bug 9147: OPAC hidden fields are not hidden in ISBD view 2013-02-01 20:59:53 +13:00
Bookseller.pm Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller 2012-06-20 11:12:29 +02:00
Boolean.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Branch.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm 2012-09-20 12:01:37 +02:00
Breeding.pm Normalize records imported from Z39.50 servers. 2012-10-08 18:46:56 +02:00
Budgets.pm Bug 5339: Invoices management improvement 2012-09-18 22:42:15 +02:00
Calendar.pm Bug 7351 : feature that allows to delete a range of dates 2012-09-28 12:19:45 +02:00
Category.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-28 17:54:25 +02:00
Charset.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Circulation.pm Bug 9423: Add notforloan value to issue confirmation or blocking message 2013-03-29 19:36:21 +13:00
ClassSortRoutine.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ClassSource.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Context.pm Bug 9085 - Installer will not run with DEBUG set 2012-11-20 06:50:08 -05:00
Contract.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Creators.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Csv.pm Bug 7986: Export issues for patron 2012-09-13 17:58:30 +02:00
Dates.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Debug.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Heading.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
HoldsQueue.pm Bug 8890: C4/HoldsQueue requires DB 2012-10-24 17:52:36 +02:00
Images.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ImportBatch.pm Bug 7368: Update GetXmlBiblio documentation 2012-12-28 09:04:19 +13:00
ImportExportFramework.pm Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm 2012-09-20 12:00:55 +02:00
Input.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Installer.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm 2012-09-20 12:17:03 +02:00
ItemCirculationAlertPreference.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm 2012-09-20 12:01:39 +02:00
ItemType.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-28 17:54:25 +02:00
Items.pm Bug 9116: Remove some useless tmp variables 2013-02-01 21:21:02 +13:00
Koha.pm Bug 9341: Problem with UNIMARC authors facets 2013-03-29 19:08:15 +13:00
Labels.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-20 14:39:56 -05:00
Letters.pm Bug 9348 - Format dates in HOLD notices consistently 2013-02-01 21:11:44 +13:00
Linker.pm Bug 7284: Fix unit test broken by erroneous POD 2012-03-08 15:24:18 +01:00
Log.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Maintainance.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Matcher.pm Bug 7475: Teach matching rules to handle authorities 2012-09-19 17:15:56 +02:00
Members.pm Bug 8682 - Renewals do not appear on quick slips 2013-03-11 21:45:54 +13:00
Message.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm 2012-09-20 12:01:39 +02:00
NewsChannels.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Output.pm Bug 9504: URL escape in OPAC more searches 2013-03-29 19:44:19 +13:00
Overdues.pm Bug 8939 : Fines being charged during the grace period 2012-10-26 17:26:07 +02:00
Patroncards.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Print.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm 2012-09-20 12:17:43 +02:00
Ratings.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Record.pm Bug 7986: Export issues for patron 2012-09-13 17:58:30 +02:00
Reports.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Reserves.pm Bug 8559 - conflicting item statuses - QA Followup 2012-11-29 20:39:32 +13:00
Review.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Ris.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
RotatingCollections.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
SMS.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
SQLHelper.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm 2012-09-20 12:01:38 +02:00
Scheduler.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Scrubber.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Search.pm Bug 9377 - itemtype in duplicate biblio search 2013-03-17 09:23:29 +13:00
Serials.pm Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm 2012-09-20 12:01:37 +02:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm 2012-09-20 12:01:37 +02:00
SocialData.pm bug 7470 follow-up, fix POD doc 2012-03-26 17:53:28 +02:00
Stats.pm Bug 4118 - Add Collection Code to Statistics Table 2012-09-13 18:42:46 +02:00
Suggestions.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
TTParser.pm Bug 5327 : Follow up for TTParser test 2012-07-12 16:06:21 +02:00
Tags.pm Bug 9136: C4::Tags not Plack-compatible 2012-12-27 08:40:31 +13:00
Templates.pm Bug 8623: Move YUI out of prog 2012-09-05 12:04:13 +02:00
TmplToken.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
TmplTokenType.pm Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm" 2012-09-20 13:29:59 +02:00
UploadedFile.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Utils.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm 2012-09-20 12:01:39 +02:00
VirtualShelves.pm Bug 9066: VirtualShelves db access not Plack+MariaDB compatible 2012-11-20 06:49:07 -05:00
XISBN.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
XSLT.pm Bug 8947: [SIGNED-OFF] XSLT fallback logic backwards 2012-10-26 17:41:08 +02:00
Z3950.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00