gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm 

Subroutine prototypes used at line 82, column 1.  See page 194 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 83, column 22.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This commit is contained in:
Mason James 2012-06-27 00:43:07 +12:00 committed by Paul Poulain
parent a42e5e6d3e
commit 8cfc1a0804
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
C4/External/BakerTaylor.pm vendored
View File

@ -50,26 +50,26 @@ sub initialize {
#"Mozilla/4.76 [en] (Win98; U)", # if for some reason you want to go stealth, you might prefer this
}
sub image_url (;$) {
($user and $pass) or return undef;
sub image_url {
($user and $pass) or return;
my $isbn = (@_ ? shift : '');
$isbn =~ s/(p|-)//g; # sanitize
return $image_url . $isbn;
}
sub link_url (;$) {
sub link_url {
my $isbn = (@_ ? shift : '');
$isbn =~ s/(p|-)//g; # sanitize
$link_url or return undef;
$link_url or return;
return $link_url . $isbn;
}
sub content_cafe_url ($) {
($user and $pass) or return undef;
sub content_cafe_url {
($user and $pass) or return;
my $isbn = (@_ ? shift : '');
$isbn =~ s/(p|-)//g; # sanitize
return "http://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=$user&Password=$pass&Options=Y&ItemKey=$isbn";
}
sub http_jacket_link ($) {
my $isbn = shift or return undef;
sub http_jacket_link {
my $isbn = shift or return;
$isbn =~ s/(p|-)//g; # sanitize
my $image = availability($isbn);
my $alt = "Buy this book";
@ -79,9 +79,9 @@ sub http_jacket_link ($) {
return sprintf qq(<a class="btlink" href="%s">%s</a>),$link,($image||$alt);
}
sub availability ($) {
my $isbn = shift or return undef;
($user and $pass) or return undef;
sub availability {
my $isbn = shift or return;
($user and $pass) or return;
$isbn =~ s/(p|-)//g; # sanitize
my $url = "http://contentcafe2.btol.com/ContentCafe/InventoryAvailability.asmx/CheckInventory?UserID=$user&Password=$pass&Value=$isbn";
$debug and warn __PACKAGE__ . " request:\n$url\n";