Koha-clms/misc
Andreas Jonsson e7e27a934a Bug 20478: Have the cronjob script advance_notices.pl send digest messages per branch.
Desired behavior of the script advance_notices.pl is that the sender
address on the notice message is that of the branch of the issues in
question.  Thus, the solution is to generate digest messages per
branch.

To test:
1) Inspect unit test in t/db_dependent/cronjobs/advance_notices_digest.t and note that:
   - There are three libraries
   - There is a borrower
   - The borrower is registered at library1
   - The borrower has message preference wants_digest set to 1
   - The borrower has message preference days_in_advance set to 1
   - The content of the letter PREDUEDGST is '<<count>> <<branches.branchname>>'
   - There are three items
   - There is one issue per item
   - There is one issues at library2
   - There are two issues at library3
   - The date_due of the issues are set to tomorrow
   - For the default case (no -digest-per-message)
      - It is asserted that there is one message in the message queue after running the script
      - It is asserted that there are three items in the message.
      - It is asserted that the branchname is that of the borrower's home library.
   - For the case where -digest-per-message is enabled
      - It is asserted that there are two messages in the message queue after running the script
      - It is asserted that the item count of the message corresponding to library2 is 1
      - It is asserted that the item count of the message corresponding to library3 is 2
      - It is asserted that the branchnames are correct.
2) Run unit test: prove t/db_dependent/cronjobs/advance_notices_digest.t

Sponsored-By: Bibliotek Mellansjö, which is a cooperation between
Sponsored-By: Gullspångs kommunbibliotek
Sponsored-By: Hjo stadsbibliotek
Sponsored-By: Karlsborgs bibliotek
Sponsored-By: Mariestads stadsbibliotek
Sponsored-By: Skövde stadsbibliotek
Sponsored-By: Tibro bibliotek
Sponsored-By: Tidaholms stadsbibliotek
Sponsored-By: Töreboda kommunbibliotek

Signed-off-by: Andreas Jonsson <andreas.jonsson@kreablo.se>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Adding the --digest-per-branch switch turns the digest into one digest per
library. I think it makes perfect sense to keep the default behaviour
and hide this new functionality behind a command line switch.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-22 19:46:31 +00:00
..
admin Bug 11998: Do not clear syspref cache in psgi file 2016-03-15 07:08:29 +00:00
bin Revert Bug 11081 - Port Koha::Contrib::Tamil indexer into Koha code base 2016-03-01 16:56:35 +00:00
cronjobs Bug 20478: Have the cronjob script advance_notices.pl send digest messages per branch. 2019-03-22 19:46:31 +00:00
devel Bug 22048: Use set_password in create_superlibrarian.pl 2019-01-25 20:15:30 +00:00
interface_customization Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong 2018-08-10 10:38:12 +00:00
load_testing Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
maintenance Bug 21683: (follow-up) Polish the change - based on feedback 2019-03-21 18:19:22 +00:00
migration_tools Bug 12488: Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE 2019-02-15 18:42:46 +00:00
release_notes Correct release notes encoding issues 2018-11-27 12:04:15 +00:00
search_tools Bug 19893: Add pods, remove syspref, add tests for serialization format 2018-11-16 11:04:59 +00:00
translator Bug 22236: Translation should generate tags with consistent attribute order 2019-02-04 14:40:46 +00:00
batchCompareMARCvsFrameworks.pl
…
batchDeleteUnusedSubfields.pl Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
batchImportMARCWithBiblionumbers.pl
…
batchRebuildBiblioTables.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
batchRebuildItemsTables.pl Bug 20893: batchRebuildItemsTables.pl has incorrect parameter 2018-06-29 19:40:16 +00:00
batchRepairMissingBiblionumbers.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
batchdeletebiblios.pl
…
check_sysprefs.pl Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
commit_file.pl
…
export_borrowers.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
export_records.pl Bug 20486: Add --marc_conditions option to export_records.pl 2018-11-08 02:23:29 +00:00
exportauth.pl
…
import_patrons.pl Bug 22299: Fix typo in option of import_patrons.pl 2019-02-15 18:42:48 +00:00
koha-install-log Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
kohalib.pl
…
link_bibs_to_authorities.pl Bug 19365: Fix several issues with the Elasticsearch code 2018-11-26 16:11:01 +00:00
mod_zebraqueue.pl
…
perlmodule_ls.pl
…
perlmodule_rm.pl
…
recreateIssueStatistics.pl Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
sax_parser_print.pl Bug 17626 (QA followup) 2016-11-22 11:29:07 +00:00
sax_parser_test.pl
…
sip_cli_emulator.pl Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing 2017-03-31 13:56:37 +00:00
stage_file.pl Bug 19164: (QA follow-up) Minor whitespace cleanup 2019-02-19 13:52:15 +00:00