gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 21683: (follow-up) Polish the change - based on feedback 

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Josef Moravec 2019-02-22 14:33:17 +00:00 committed by Nick Clemens
parent 6e3da5397e
commit bb231e6208
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
C4/Circulation.pm
View File

@ -2385,7 +2385,7 @@ sub _FixAccountForLostAndReturned {
accounttype => { -in => [ 'L', 'Rep', 'W' ] },
},
{
order_by => { -desc => [ 'date' ] }
order_by => { -desc => [ 'date', 'accountlines_id' ] }
}
);

4
misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl
View File

@ -98,13 +98,13 @@ foreach my $keeper (@$results) {
}
my $sql =
"DELETE FROM accountlines WHERE accountlines_id = ? LIMIT 1";
"DELETE FROM accountlines WHERE accountlines_id = ?";
$dbh->do( $sql, undef, $f->{'accountlines_id'} );
}
if ($has_changed) {
my $sql =
"UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ? LIMIT 1";
"UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ?";
$dbh->do(
$sql, undef,
$keeper->{'amountoutstanding'}, $keeper->{'accountlines_id'}

3
t/db_dependent/Stats.t
View File

@ -4,7 +4,7 @@ use Modern::Perl;
use C4::Stats;
use Koha::Database;
use Test::More tests => 18;
use Test::More tests => 19;
BEGIN {
use_ok('C4::Stats');
@ -119,6 +119,7 @@ is ($params->{other}, $line->{other}, "UpdateStats save other
is ($params->{itemtype}, $line->{itemtype}, "UpdateStats save itemtype param in itemtype field of statistics table");
is ($params->{location}, $line->{location}, "UpdateStats save location param in location field of statistics table");
is ($params->{ccode}, $line->{ccode}, "UpdateStats save ccode param in ccode field of statistics table");
is (undef, $line->{proccode}, "UpdateStats save no proccode param in proccode field of statistics table");
$dbh->do(q|DELETE FROM statistics|);
$params = {