Go to file
Kyle M Hall c2537558e0
Bug 21417: EDI ordering fails when basket and EAN libraries do not match
When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message will not be generated if aqbasket.branch does not match edifact_ean.branchcode. This failure does not generate any sort of error message, it just fails to produce a message.

We should allow ean's to not require a branch to be set, then if we don't find a branch specific each, we can look for the default version of the ean.

Test Plan:
1) Apply this patch set
2) Run updatedatabase
3) Verify you can create a Library EAN without setting a branchcode for it
4) Verify you can use this EAN to send an EDI order where the basket has a branchcode set

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 18674cfde3)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-10-15 12:48:46 +01:00
C4 Bug 20177: [sql_modes] Fix GROUP BY clause in GetCourses 2018-10-15 12:31:14 +01:00
Koha Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-15 12:48:46 +01:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 19271: Show vendor name on ordered/spent lists 2018-10-08 08:53:10 +01:00
admin Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-15 12:48:46 +01:00
api/v1 Bug 20942: Split debit and credit lines 2018-08-02 18:03:36 +01:00
authorities Bug 21455: Authority search options get shuffled around when you click on 'Search' 2018-10-15 12:44:23 +01:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-08-02 14:43:04 +01:00
catalogue Bug 21248: Fix COinS carp in MARC details page on unknown record 2018-09-17 14:30:27 +01:00
cataloguing Bug 14662: Add empty entries to pull downs in cataloguing form for mandatory subfields 2018-08-09 11:06:21 +01:00
circ Bug 21168: Handle deleted checked-in items on checking in 2018-09-05 10:42:26 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-01-30 14:18:21 -03:00
debian Bug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip format 2018-10-15 11:44:49 +01:00
docs Bug 7143: Update about page for new dev - Alberto Martinez 2018-09-27 14:33:31 +01:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-08-03 15:24:41 +01:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-05 13:10:31 +01:00
installer Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-15 12:48:46 +01:00
koha-tmpl Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-15 12:48:46 +01:00
labels Bug 20765: Fix search for items by acqdate in label batch 2018-09-17 14:54:42 +01:00
members Bug 21167: Fix price formatting on printed fee invoice and receipt 2018-10-05 12:41:01 +01:00
misc Bug 21322: process_message_queue.pl --type should take an argument 2018-10-08 09:49:54 +01:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-17 14:27:25 +01:00
opac Bug 20023: (QA follow-up) Tiny simplification 2018-09-27 13:28:25 +01:00
patron_lists Bug 19837: Add error feedback for duplicated or unfound cardnumbers 2018-02-18 16:48:46 -03:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-08-02 15:22:00 +01:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 16653: (QA follow-up) Avoid a warning and remove unused variables 2018-07-02 08:23:42 +01:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-05-16 10:53:13 -03:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-10-03 10:37:05 +01:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-09 11:20:29 +01:00
svc Bug 20760: Fill authorised values in svc framework 2018-06-15 13:10:13 +01:00
t Bug 21352: (qa followup) - correction to testplan 2018-10-08 13:46:44 +01:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 15971: Add biblioitems to available fields for serial claim notices and fix notices editor display 2018-10-08 08:31:40 +01:00
virtualshelves Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-25 18:13:55 +01:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20267: Add basic .gitignore 2018-03-26 17:31:16 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 5458: DBRev 18.05.04.001 2018-09-27 13:33:22 +01:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 20428: Display warning if the entry is empty 2018-05-14 11:14:40 -03:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
edithelp.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 20489: Remove warnings from the interface 2018-04-20 12:24:00 -03:00
rewrite-config.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo