gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 21248: Fix COinS carp in MARC details page on unknown record 

Looking up a nonexistent record in the MARC details -page causes
the COinS to carp. The fix is trivial, just move the COinS call
couple lines, after the record existence check.

TEST PLAN
---------
1) reset_all for kohadevbox
2) log in to staff client - admin/admin
3) search catalogue for green
4) tweak the top URL to have a bad biblionumber (eg. 9999)
5) cat /var/log/koha/kohadev/plack-err.log
   -- floody! with errors.
6) echo | sudo tee /var/log/koha/kohadev/plack-err.log
7) restart_all
8) repeat steps 2 through 5.
   -- just nice starting messages, not floody.
9) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

(cherry picked from commit 030047da42)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Pasi Kallinen 2018-08-20 07:30:45 +03:00 committed by Martin Renvoize
parent ee2d5ae04d
commit 7fe692bf0e
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
catalogue/MARCdetail.pl
View File

@ -90,7 +90,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
my $record = GetMarcBiblio({
biblionumber => $biblionumber,
embed_items => 1 });
$template->param( ocoins => GetCOinSBiblio($record) );
if ( not defined $record ) {
# biblionumber invalid -> report and exit
@ -101,6 +100,8 @@ if ( not defined $record ) {
exit;
}
$template->param( ocoins => GetCOinSBiblio($record) );
my $biblio_object = Koha::Biblios->find( $biblionumber ); # FIXME Should replace $biblio
my $tagslib = &GetMarcStructure(1,$frameworkcode);
my $biblio = GetBiblioData($biblionumber);