gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Kyle M Hall 98b9b0f9e5 Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 
Due to the way AddReturn and UpdateFine work, if you pass in a return
date to AddReturn, and that item has a calculated fine of 0, Koha will
insert the 0 amount fine into accountlines.

This is good behavior when we want to update an existing fine, but bad
behavior if there was no fine to begin with!

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Circulation.t
3) Note the test fails
4) Apply this patch
5) prove t/db_dependent/Circulation.t
6) Note the test passes

Signed-off-by: Jen DeMuth <jdemuth@roseville.ca.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Confirmed the problem in the staff interface and that the patch
fixes it. Also tested that fines still get calculated.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit faab00b88a)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
 		2015-04-06 20:24:58 +12:00
..
AuthoritiesMarc
…
Barcodes Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment 2015-02-14 21:28:06 +13:00
Bookseller Bug 10402 follow-up: choose contacts for claims 2014-08-26 11:45:59 -03:00
ClassSortRoutine Bug 8837: Dewey cn_sort inaccurate 2014-10-28 09:39:29 -03:00
Creators Bug 13407: Removing depricated code included in PDF::Reuse 2015-01-11 21:10:35 +13:00
External Bug 12858 [QA Followup] - Don't call webservice if we have no data 2015-02-23 12:12:17 +13:00
Form Bug 12100: ensure that messaging preferences displays saved Days in Advance 2014-04-28 21:35:18 +00:00
Heading Bug 10308 - local subjects can use authorities too 2014-09-01 10:45:07 -03:00
ILSDI Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. 2014-11-12 11:23:41 -03:00
Installer Bug 13645 [QA Followup] - Add DBIx::Connector to the list of dependancies 2015-03-11 07:59:33 +13:00
Labels Bug 10773 - Add item-level descriptions for Label Printing 2015-03-31 18:21:20 +13:00
Linker Bug 11650: multiplicated authorities after link_bibs_to_authorities.pl 2014-07-07 12:40:25 -03:00
Members Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD 2014-11-06 10:14:13 -03:00
OAI Bug 9295: Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. 2013-10-10 23:03:30 +00:00
Output
…
Patroncards Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken 2015-03-22 18:25:05 +13:00
Reports Bug 13141: Add ability for biblio_framework to be a dropdown in Guided Reports 2014-10-31 13:14:59 -03:00
SIP Bug 12820: [QA Followup] Tab and whitespace cleanup 2015-03-29 19:37:29 +13:00
Search Bug 10807: (follow-up) use 24-hour time when storing search times to session 2014-05-05 02:55:41 +00:00
Serials Bug 7688: (follow-up) update license statements 2013-10-30 02:56:32 +00:00
Utils Bug 12833: Patron search should search on extended attributes 2014-09-09 10:08:59 -03:00
VirtualShelves Bug 8521 - Error in warning message when deleting list 2014-08-05 20:44:28 -03:00
Accounts.pm Bug 12865 - 'Pay amount toward all fines' does not record payment note 2014-11-25 16:38:46 -03:00
Acquisition.pm Bug 13333: Fix Display basket group for already received orders 2015-02-11 10:45:46 +13:00
Auth.pm Bug 12887: User logged out on refresh after CAS authentication 2015-03-31 18:23:13 +13:00
Auth_cas_servers.yaml.orig
…
Auth_with_cas.pm Bug 12398: Fix CAS authentication validation 2014-08-01 10:13:49 -03:00
Auth_with_ldap.pm Bug 9165: (Followup) Tidied code slightly 2014-11-27 14:58:46 -03:00
Auth_with_shibboleth.pm BUG8446, QA Followup: Use DBIx::Class 2014-10-16 12:28:01 -03:00
AuthoritiesMarc.pm Bug 12861: (follow-up) Noisy warn in error logs 2015-02-01 16:34:52 +13:00
BackgroundJob.pm Bug 10601: (follow-up) improvements to ->set() and ->get() 2013-09-18 17:23:44 +00:00
Barcodes.pm
…
Biblio.pm Bug 12995 - script update_totalissues.pl stops on corrupted record 2014-10-31 14:14:24 -03:00
Bookseller.pm Bug 10402 follow-up: choose contacts for claims 2014-08-26 11:45:59 -03:00
Boolean.pm Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
Branch.pm Bug 9350: Making changes so that you can add the new fields to branches 2014-10-27 10:38:16 -03:00
Breeding.pm Bug 13296: (follow-up) permit grep on AUTHUNIMARC 2014-12-20 12:32:42 +13:00
Budgets.pm Bug 11714 - GetBudgetHierarchy needs optimization 2014-10-31 16:41:46 -03:00
Calendar.pm
…
Category.pm
…
Charset.pm Bug 13075: Silence warnings and improve Charset testing. 2014-11-14 09:35:44 -03:00
Circulation.pm Bug 12344: QA followup: use next instead of return 2015-03-31 18:33:47 +13:00
ClassSortRoutine.pm Bug 12424 - ddc sorting of call numbers truncates long Cutter parts 2014-10-18 10:50:07 -03:00
ClassSource.pm Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm 2013-08-09 15:32:22 +00:00
Context.pm Bug 13645: Use DBIx::Connector 2015-03-11 07:59:01 +13:00
Contract.pm Bug 12487 [QA Followup] - GetContract must return undef with no params 2014-07-30 10:44:45 -03:00
CourseReserves.pm bug 8215: (followup) rename GetItemReservesInfo 2013-05-21 15:51:03 -07:00
Creators.pm
…
Csv.pm Bug 10853: All existing routing to get a CSV should return a MARC csv 2013-10-11 02:16:33 +00:00
Dates.pm
…
Debug.pm
…
HTML5Media.pm
…
Heading.pm
…
HoldsQueue.pm Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy 2014-04-18 15:23:23 +00:00
Images.pm
…
ImportBatch.pm Bug 11876: (qa-followup) some minor changes 2014-10-31 14:25:13 -03:00
ImportExportFramework.pm Bug 11666: remove SQL as an option for MARC framework exports and imports 2014-02-05 19:48:27 +00:00
Input.pm Bug 766: remove disused routine buildCGISort 2014-05-04 23:03:24 +00:00
InstallAuth.pm Bug 11349: Remove unnecesary name translation 2014-07-17 11:05:58 -03:00
Installer.pm Bug 11593 - subtag_registry.sql files contain the same information for each language 2014-10-28 10:49:02 -03:00
ItemCirculationAlertPreference.pm
…
ItemType.pm Bug 10513: display a warning/message when returning a chosen item type 2013-09-16 17:45:31 +00:00
Items.pm Bug 13562: Fix item search on item MARC subfields 2015-02-13 10:43:45 +13:00
Koha.pm Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13 2015-01-06 12:02:32 +13:00
Labels.pm
…
Languages.pm Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac 2014-07-14 09:01:08 -03:00
Letters.pm Bug 12739: (QA followup) use 'UTF-8' instead of 'utf8' 2015-03-31 18:26:47 +13:00
Linker.pm Bug 11650: multiplicated authorities after link_bibs_to_authorities.pl 2014-07-07 12:40:25 -03:00
Log.pm Bug 11331 - CSV export for viewlog.pl is missing newlines 2014-08-05 20:23:26 -03:00
MarcModificationTemplates.pm Bug 11413: Fix field_numbers 2014-11-14 12:05:47 -03:00
Matcher.pm Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on 2014-05-05 19:31:00 +00:00
Members.pm Bug 13740: Fix null vs not null in the query 2015-04-03 16:40:30 +13:00
Message.pm Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices 2015-01-06 12:08:04 +13:00
NewsChannels.pm Bug 12507 - News does not always display in staff or OPAC 2014-08-24 12:37:06 -03:00
Output.pm Bug 12844: Remove the C4::Output::FormatNumber subroutine 2014-10-27 12:56:19 -03:00
Overdues.pm Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 2015-04-06 20:24:58 +12:00
Patroncards.pm
…
Print.pm
…
Ratings.pm Bug 12609: Add some unit tests for C4::Ratings 2014-09-17 22:08:57 -03:00
Record.pm Bug 13190: Reintroduce the checkouts export feature 2014-11-06 10:00:30 -03:00
Reports.pm Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm 2014-08-15 14:44:50 -03:00
Reserves.pm Bug 13636 - Staff search results item status incorrect for holds 2015-02-14 20:59:10 +13:00
Review.pm
…
Ris.pm Bug 13360: C4::Ris assumes that hash keys are ordered - KW 2014-12-30 10:37:18 +13:00
RotatingCollections.pm Bug 8836 [QA Followup] - Prevent multiple collections from having the same title 2014-11-06 15:12:20 -03:00
SMS.pm Bug 3186 [QA Followup] - Don't return undef, just return 2014-10-30 01:23:12 -03:00
SQLHelper.pm Bug 11425: Get column names using DBIX 2014-11-04 19:10:28 -03:00
Scheduler.pm
…
Scrubber.pm
…
Search.pm Bug 13636 - Staff search results item status incorrect for holds 2015-02-14 20:59:10 +13:00
Serials.pm Bug 13746: On creating a new subscription, notes fields get confused 2015-03-16 13:17:40 +13:00
Service.pm
…
ShelfBrowser.pm Bug 10856: (follow-up) if callnumbers are equal, order should be on itemnumber 2013-10-04 15:57:03 +00:00
SocialData.pm
…
Stats.pm Bug 10860 - Change "in-house use" to "on-site checkout" 2014-11-03 10:26:22 -03:00
Suggestions.pm Bug 13201: GetSuggestion takes suggestionid 2015-02-13 11:40:13 +13:00
TTParser.pm Bug 12207: fix TTparser's handling of TT directives that contain "]" 2014-05-23 15:23:20 +00:00
Tags.pm Bug 12916 - Use of uninitialized values $max and $min in C4/Tags.pm 2014-10-30 00:31:36 -03:00
Templates.pm Bug 13473 - Plugins fail 2015-03-12 19:59:16 +13:00
TmplToken.pm Bug 12131: Remove unused dependency on Exporter 2014-04-25 15:24:39 +00:00
TmplTokenType.pm
…
UploadedFile.pm
…
UsageStats.pm Bug 11926: Follow-up - remove SearchEngine pref / fix POD 2014-10-22 15:17:14 -03:00
VirtualShelves.pm Bug 8262: explicitly warn that database admin account cannot create lists 2014-04-20 22:55:22 +00:00
XISBN.pm Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
XSLT.pm Bug 12655 [Revised] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT 2014-10-30 09:35:12 +13:00