Bug 13746: On creating a new subscription, notes fields get confused
For every subscription we have 4 notes fields in Koha, 2 are in the
subscription itself and another 2 are in the subscription history.
When creating a new subscription, the notes fields from the
subscription get copied to the fields of the subscription history,
leading to doubled up display of notes in the OPAC.
To test:
- Add a new subscription without patch
- check manual history
- Fill in both notes fields
- Verify that the notes fields got also saved into the
subscription history (easy from the Summary tab)
- Apply patch
- Add another subscription, like above
- Verify now only the subscription notes fields are saved
- Edit subscription and notes - verify all is ok
- Edit subscription history (Planning tab) - verify all is ok
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit b5fac05bc3)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
parent
b4d77d7c78
commit
d04a97a342
|
|
@ -1490,11 +1490,11 @@ sub NewSubscription {
|
|||
# then create the 1st expected number
|
||||
$query = qq(
|
||||
INSERT INTO subscriptionhistory
|
||||
(biblionumber, subscriptionid, histstartdate, opacnote, librariannote)
|
||||
VALUES (?,?,?,?,?)
|
||||
(biblionumber, subscriptionid, histstartdate)
|
||||
VALUES (?,?,?)
|
||||
);
|
||||
$sth = $dbh->prepare($query);
|
||||
$sth->execute( $biblionumber, $subscriptionid, $startdate, $notes, $internalnotes );
|
||||
$sth->execute( $biblionumber, $subscriptionid, $startdate);
|
||||
|
||||
# reread subscription to get a hash (for calculation of the 1st issue number)
|
||||
my $subscription = GetSubscription($subscriptionid);
|
||||
|
|
|
|||
Loading…
Reference in New Issue