b0c502407d
Comments 43-51 identified a further problem with unconditionally coding a newly auto-created authority's 008/11 (and 040$f) from the source bib heading's thesaurus: when LinkerConsiderThesaurus is off (the default), the linker matches new headings to existing authorities by text alone, regardless of thesaurus. So a bib heading from one thesaurus (e.g. FAST) can auto-create an authority coded for that thesaurus, and a later bib heading with the *same* text but no thesaurus of its own (or a different one) can then link to that same authority purely on the text match. Saving that authority afterwards propagates its 008/11 and 040$f coding back onto every bib heading linked to it - silently adding indicators and subfields the cataloguer never set, on installs that never opted into thesaurus-aware behaviour. Before this bug, AutoCreateAuthorities always created LCSH-coded records, so that propagation was always onto the coding most sites already expect. This bug's earlier patches changed that default for every site regardless of whether they use LinkerConsiderThesaurus, which is what comments 43/45 (reproduced by Pedro Amorim) demonstrated as disruptive. Sites that haven't turned on LinkerConsiderThesaurus don't benefit from thesaurus-aware authority creation anyway, since their linker never searches by thesaurus - C4::Heading::_search and C4::Linker::Default already gate thesaurus-consideration on this same preference for matching. This change gates authority-creation coding on it too, so the behaviour introduced by this bug only applies to installs that already opted into thesaurus-aware linking. Test plan: 1. prove t/db_dependent/Biblio.t Note the new case 7 in the "codes new authorities with the source thesaurus" subtest: with LinkerConsiderThesaurus off, a FAST heading no longer codes the new authority as FAST, it keeps the MARCAuthorityControlField008 syspref default instead. 2. Librarian-facing regression check: with LinkerConsiderThesaurus off (the default), AutoLinkBiblios and AutoCreateAuthorities on, catalogue a 650 with ind2=7 $2=fast and save. The new authority's 008/11 should be whatever MARCAuthorityControlField008 says (LCSH 'a' by default), not 'z'. 3. Confirm the LinkerConsiderThesaurus=on cases from the earlier patches are unaffected: with it on, a FAST heading still codes 008/11='z' with 040$f=fast, and a MeSH heading still codes 008/11='c'. Sponsored-by: Heythrop Library <https://heythroplibrary.co.uk/> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> |
||
|---|---|---|
| .github/workflows | ||
| C4 | ||
| Koha | ||
| acqui | ||
| admin | ||
| api | ||
| authorities | ||
| basket | ||
| bin | ||
| bookings | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| clubs | ||
| course_reserves | ||
| debian | ||
| docs | ||
| erm | ||
| errors | ||
| etc | ||
| ill | ||
| installer | ||
| koha-tmpl | ||
| labels | ||
| lib | ||
| members | ||
| misc | ||
| offline_circ | ||
| opac | ||
| patron_lists | ||
| patroncards | ||
| plugins | ||
| pos | ||
| preservation | ||
| recalls | ||
| reports | ||
| reserve | ||
| reviews | ||
| rotating_collections | ||
| serials | ||
| services | ||
| sip2 | ||
| skel | ||
| suggestion | ||
| svc | ||
| t | ||
| tags | ||
| tools | ||
| virtualshelves | ||
| xt | ||
| .codespell-ignore | ||
| .editorconfig | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .htaccess | ||
| .mailmap | ||
| .nvmrc | ||
| .perlcriticrc | ||
| .perltidyrc | ||
| .prettierrc.js | ||
| .proverc.dist | ||
| .stylelintrc.json | ||
| INSTALL | ||
| Koha.pm | ||
| LICENSE | ||
| MANIFEST.SKIP | ||
| Makefile.PL | ||
| README | ||
| README.md | ||
| README.robots | ||
| SECURITY.md | ||
| about.pl | ||
| app.psgi | ||
| build-resources.PL | ||
| changelanguage.pl | ||
| cpanfile | ||
| cypress.config.ts | ||
| eslint.config.mjs | ||
| fix-perl-path.PL | ||
| gulpfile.js | ||
| help.pl | ||
| kohaversion.pl | ||
| mainpage.pl | ||
| package.json | ||
| rewrite-config.PL | ||
| rspack.config.js | ||
| tsconfig.json | ||
| yarn.lock | ||
README.md
Koha is a free software integrated library system (ILS).
Koha is distributed under the GNU GPL version 3 or later.
Note: Koha does not accept pull requests from git hosting sites.
Note: This project has its own bug tracker, to report a bug or submit a patch visit https://bugs.koha-community.org.
For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch
The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook
