Go to file
David Cook afbe6a0f2c Bug 10541: enable cross-browser AJAX in additem.js
Currently, the additem.js is using "indexOf" to search
for a value in an array. While this works in Chrome, Firefox,
and IE > 9, it fails miserably in IE 8 and 7 (which don't have
the indexOf method). This means that users aren't able to add
items using the acquisitions module!

Instead of using "indexOf", we should be using the jQuery function
$.inArray. It was added in jQuery v1.2 (3.8.0 uses v1.3.2 so even
our oldest supported release can use this method). It's perfectly
cross-browser compatible...works in Chrome, Firefox, and every
version of IE that I've tried (i.e. 7, 8, 9).

Test Plan:

Before applying patch:

0) Switch to Internet Explorer 7, or 8, or 9, or 10.

If you're using IE 9 or 10, you'll need to change the Document Mode to
IE7 standards or IE8 standards.

You can do this by opening Internet Explorer 9 or 10, pressing F12 (or
clicking on the gear in the top right corner and choosing
F12 Developer Tools), and then clicking on "Document Mode" on the
top toolbar. There, you can change to IE7 or IE8 standards.

N.B. This is not always a perfect emulation in every case, but this
time it does show you the bug.

1) Set the system preference AcqCreateItem to "receiving an order"
2) Go to Acquisitions
3) Either:
    a) Receive a shipment for a basket with items
    b) Create a new basket, create an order, close the basket, and
       then do 3a)
4) In the "Item" fieldset, fill out some fields such as barcode,
   Date acquiried, Public note, etc.
5) Click "Add" at the bottom of the fieldset
6) Note that while the item may have been added, the "Item" fieldset
is not being shown again. You may also notice a Javascript error
appearing in a pop-up window or you might see a yellow warning flag
on the bottom status bar.

APPLY THE PATCH

7) Do a full refresh of the page (hold down shift and press the refresh
button on the browser next to the address bar), and try adding items
again.
8) Note that you receive no warnings and that items are added correctly
as they would be in Firefox or Chrome.

OPTIONALLY

9) To be sure that I haven't broken anything, go through the same steps
in IE9 (with IE9 standards) or Chrome or Firefox. Everything should be
working.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Tested in IE10 in IE7 mode and IE9 mode. Also tested in Firefox.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, works as advertised.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 53f82b1d7d)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2013-08-13 13:27:52 -03:00
C4 Bug 9362: fix query that finds upcoming due loans 2013-08-13 13:25:12 -03:00
Koha Bug 10494: remove spurious warnings from the KohaBranchName plugin 2013-07-15 15:02:14 -03:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 10258: fix permissions check for setting basket group for order basket 2013-07-25 11:57:21 -03:00
admin Bug 9508: Standardize the dateformat value from C4::Auth 2013-05-21 20:02:23 -03:00
authorities Revert "Merge branch 'bug_6554' into 3.12-master" 2013-04-25 22:37:54 -04:00
basket Bug 9073 - Download option from the cart should match the menu button in lists 2012-11-25 18:08:46 -05:00
catalogue Bug 9665: QA follow up fixing tabs 2013-07-06 20:06:20 -03:00
cataloguing Bug 10504: Remove the unused C4::Acq::ModOrderItem routine 2013-07-25 12:35:31 -03:00
circ Bug 10221 - hold expiration doesn't show on patron's list of holds 2013-06-11 13:07:36 -03:00
debian Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 11:45:45 -03:00
docs Bug 7143: Updating history and about page 2013-07-25 11:25:12 -03:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 11:45:45 -03:00
install_misc Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!" 2013-05-12 21:15:34 -04:00
installer Increment version for 3.12.3 release 2013-07-29 13:14:32 -03:00
koha-tmpl Bug 10541: enable cross-browser AJAX in additem.js 2013-08-13 13:27:52 -03:00
labels Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-25 12:33:14 -03:00
members Bug 10507: improve warning about duplicate patron attribute value 2013-07-16 16:51:52 -03:00
misc Bug 10127 : Printoverdues.sh should tar only pdf files 2013-08-12 10:17:29 -03:00
offline_circ Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. 2013-03-21 20:35:37 -04:00
opac do some validation of the KohaOpacRecentSearches cookie 2013-07-28 10:41:38 -03:00
patroncards Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-25 12:33:14 -03:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 9508: Standardize the dateformat value from C4::Auth 2013-05-21 20:02:23 -03:00
reserve Bug 766: remove CGI::scrolling_list from request.pl 2013-07-02 14:45:19 -03:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 10484: serials-edit.pl not checking for barcode field before checking for barcode subfield 2013-07-15 15:04:38 -03:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 9226: Wrong branch filter after suggestion creation 2013-02-15 08:34:11 -05:00
svc Bug 9908 - Fixing OCLC Connexion Client 2013-03-29 21:29:10 -04:00
t move Auth_ParseSearchHistoryCookie.t to db_dependent directory 2013-07-28 18:06:59 -03:00
tags Bug 10022 - Multiple tags moderation doesn't work on translated page 2013-05-01 06:44:31 -04:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-25 12:33:14 -03:00
virtualshelves Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-22 12:06:26 +02:00
xt Bug 9802 - add test case to ensure man pages have correct XML 2013-03-20 15:11:10 -04:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.ubuntu.12.04 Bug 9267 - Ubuntu 12.04 install docs broken 2013-03-07 09:46:55 -05:00
INSTALL.ubuntu.lucid Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 11:45:45 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 11:45:45 -03:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl 7368 Typo in edithelp.pl warning 2013-04-18 09:48:30 -04:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 8949: Trying to view help on a page without any help results in a nasty error 2012-11-05 08:39:23 -05:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-16 14:54:30 -03:00
kohaversion.pl Increment version for 3.12.3 release 2013-07-29 13:14:32 -03:00
mainpage.pl Revert "Bug 7167: New version for updatedatabase" 2012-12-27 14:02:56 -05:00
rewrite-config.PL Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/