gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 10022 - Multiple tags moderation doesn't work on translated page 

When using a translated intranet, tags moderation using checkboxes and a
submit button doesn't work. You get a message "Unknown Operation on x
Term(s)" (translated of course).

This patch corrects by using name="op-[operation]" instead of name="op"
in each submit input.

Test plan :
- Create a new tag on a record
- Go to tags moderation in Tools
=> You should see your tag in pending terms
- Click on checkbox
- Click on Approve or Reject submit button at the bottom of the table
=> Without patch the tag is still pending
=> With patch operation is well performed, tag is not pending
- Test "Check lists" form
- Test Approve and Reject buttons from "Actions" column

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit 86511b380f)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
Fridolyn SOMERS 2013-04-10 12:37:54 +02:00 committed by Jared Camins-Esakov
parent 2fd425df26
commit 20b016beab
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
View File

@ -239,8 +239,8 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
</table>
[% END %]
[% IF ( tagloop ) %]<fieldset class="action">
<input type="submit" value="Approve" id="approve_button" name="op" />
<input type="submit" value="Reject" id="reject_button" name="op" />
<input type="submit" value="Approve" id="approve_button" name="op-approve" />
<input type="submit" value="Reject" id="reject_button" name="op-reject" />
</fieldset>[% END %]
</form>
</div>
@ -268,7 +268,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
<div class="description">Enter a word or phrase to check against approved/rejected lists: </div>
<form method="post" action="/cgi-bin/koha/tags/review.pl">
<input type="text" size="14" name="test" id="test" />
<fieldset class="action"><input type="submit" value="Test" id="test_button" name="op" /></fieldset>
<fieldset class="action"><input type="submit" value="Test" id="test_button" name="op-test" /></fieldset>
<div id="verdict">
[% IF ( test_term ) %]
[% IF ( verdict_ok ) %]

7
tags/review.pl
View File

@ -89,7 +89,12 @@ my ($template, $borrowernumber, $cookie) = get_template_and_user({
});
my ($op, @errors, @tags);
$op = lc($input->param('op')) || 'none';
foreach (qw( approve reject test )) {
$op = $_ if ( $input->param("op-$_") );
}
$op ||= 'none';
@tags = $input->param('tags');
$borrowernumber == 0 and push @errors, {op_zero=>1};