Koha-clms/t/db_dependent
Tomas Cohen Arazi aaf0d3dc47 Bug 19440: Identify overlimit problems in XISBN tests
This patch makes C4::XISBN::get_xisbns() return an errors hashref
including information of the failing fetches from xisbn services.

It tackles the situation of XISBN, which in some cases returns 'overlimit'
errors.

The patch makes the relevant functions check if the response->{stat} string
is 'ok' and returns the string in $errors otherwise.

This only happens when in list context. This allows to fix the randomly failing
tests while keeping the current behaviour.

All this code should be rewritten. It does the job bug doesn't have problems handling
or reoprting. This is just a band aid.

To test:
- Make sure
 k$ prove t/db_dependent/XISBN.t
=> SUCCESS :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit e908742418)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-10-17 09:00:31 +02:00
..
Acquisition Bug 19024 Fix some infelicities of phrasing in test messages 2017-10-03 11:16:35 +02:00
Auth
…
Authorities Bug 9988: Refactor the cron script 2017-04-13 08:53:47 -04:00
Biblio Bug 18951: Adjust Isbd.t 2017-08-03 09:48:06 +02:00
Circulation Bug 19004: Adjust AddReturn for retrieving item type 2017-10-03 11:50:57 +02:00
Creators Bug 18044: Add a test 2017-02-07 17:46:00 +00:00
Exporter Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Holds Bug 19437: Rearranging tests for CancelExpiredReserves 2017-10-13 09:47:11 +02:00
Items Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Koha Bug 19004: Patrons.t should create its own data for enrollment fees. 2017-10-03 11:49:55 +02:00
LDAP
…
Labels Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Letters Bug 17762: Update the letter form interface 2017-05-09 20:56:41 +00:00
Members Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
OAI Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios 2017-06-15 14:14:57 +02:00
Patron Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Record Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests 2016-10-21 15:13:55 +00:00
Reports Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
Reserves Bug 19437: (followup) Rearrange CancelExpiredReserves tests - fix typos 2017-10-13 09:47:59 +02:00
SIP Bug 18812 - SIP Patron status does not respect OverduesBlockCirc 2017-10-03 10:22:13 +02:00
Search Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup 2017-07-31 09:21:30 +02:00
Serials Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Template/Plugin Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Utils Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
XSLT_Handler
…
api/v1 Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
data
…
selenium Bug 18982: Remove data in the correct order 2017-07-27 15:54:47 +02:00
www Bug 19391: (bug 19128 follow-up) Fix failing tests from auth_values_input_www.t 2017-10-03 08:50:47 +02:00
00-strict.t Bug 18897: Skipping t/db_dependend/00-strict elastic search stuffs as needed 2017-10-03 17:00:04 +02:00
Accounts.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Acquisition.t Bug 18554: Adjust a few typos including responsability 2017-05-09 21:03:22 +00:00
AdditionalField.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
ArticleRequests.t Bug 18766: Remove itemtype-related warnings from ArticleRequests.t 2017-06-12 11:59:19 +02:00
AudioAlerts.t
…
Auth.t Bug 18976: Fix t/db_dependent/Auth.t cleanup 2017-07-31 09:20:47 +02:00
Auth_with_cas.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-18 16:42:44 +02:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Biblio.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Bookseller.t Bug 19130: Remove ->search() overloading and adjust tests 2017-09-29 15:21:13 +02:00
Breeding.t
…
Budgets.t Bug 18941 - Unit tests 2017-09-29 11:51:39 +02:00
Calendar.t Bug 12063 - Fix QA failures 2017-05-09 08:59:39 -04:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
Circulation.t Bug 19076 - followup - delete fines from additional renewal 2017-10-10 11:05:17 +02:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
DecreaseLoanHighHolds.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Fines.t
…
FrameworkPlugin.t Bug 14199: Unify marc orgcode plugins, not overwriting existing values 2016-02-26 14:04:28 +00:00
Heading_MARC21.t
…
Hold.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Holds.t Bug 12063: Change date calculation for reserve expiration to skip all holiday 2017-05-09 08:59:39 -04:00
HoldsQueue.t Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm 2017-07-31 10:01:04 +02:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-09-06 15:27:05 +02:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 17512: Improve handling dates in C4::Items 2017-02-14 13:57:49 +00:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Koha_Elasticsearch_Indexer.t Bug 18897: Use Module::Load::Conditional::can_load 2017-10-03 17:00:03 +02:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 18897: Add skipping to t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t 2017-10-03 17:00:34 +02:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 19042: Add mock IndependentBranches=0 for the other test 2017-09-29 11:27:27 +02:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-31 10:46:17 +02:00
MarcModificationTemplates.t Bug 15669: Add a test for GetModificationTemplates 2016-03-03 22:11:44 +00:00
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-09-29 15:25:44 +02:00
MungeMarcPrice.t Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Patrons.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Plugins.t Bug 15879: Add Tests 2017-01-11 14:03:00 +00:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Reports.t
…
Reserves.t Bug 19437: Rearranging tests for CancelExpiredReserves 2017-10-13 09:47:11 +02:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Search.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-10 12:02:34 +02:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
…
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-09-29 11:31:42 +02:00
Sitemapper.t Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions 2017-01-20 14:04:21 +00:00
Stats.t
…
SuggestionEngine_ExplodedTerms.t Bug 9857: Fix failing tests 2017-10-03 11:13:53 +02:00
Suggestions.t Bug 18420: Use TestBuilder to create a patron category in Suggestions.t 2017-04-21 10:49:25 -04:00
Tags.t
…
Templates.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
TestBuilder.t Bug 18182: Tests all Koha::Objects-based modules 2017-04-21 00:10:50 +00:00
Upload.t Bug 18300: [QA Follow-up] Fix return value inconsistency 2017-04-21 00:11:40 +00:00
UsageStats.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Virtualshelves.t Bug 19343: [17.05.X] Add tests 2017-10-10 10:30:15 +02:00
XISBN.t Bug 19440: Identify overlimit problems in XISBN tests 2017-10-17 09:00:31 +02:00
XSLT_Handler.t
…
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
rollingloans.t Bug 17578: GetMemberDetails - Remove GetMemberDetails 2016-12-16 13:12:44 +00:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
zebra_config.pl
…