Bug 18292: Remove return 1 statements in tests

The test files do not need to return 1

Patch generated with:
perl -p -i -e "s/^1;\n//xsm" t/**/*.t

Test plan:
  git grep '^1;$' t/**/*.t
should not return any results

NOTE: does not fix C4/SIP/t, nor xt tests.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b1ba7fac2c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

t/00-load.t

@@ -109,4 +109,3 @@ sub is_testable {
 
 done_testing();
 
-1;

t/Auth_with_shibboleth.t

@@ -321,4 +321,3 @@ sub reset_config {
     return 1;
 }
 
-1;

t/Biblio.t

@@ -197,4 +197,3 @@ warnings_like { $ret = UpdateTotalIssues() }
 
 ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist');
 
-1;

t/Biblio/TransformHtmlToXml.t

@@ -77,4 +77,3 @@ subtest "->TransformHtmlToXml (NORMARC) tests" => sub {
     run_tests('NORMARC');
 };
 
-1;

t/Boolean.t

@@ -37,4 +37,3 @@ warning_like { $result = true_p([]) }
              'Invalid boolean (reference) raises warning';
 is( $result, undef, 'recognizes a reference as not a boolean' );
 
-1;

t/Calendar.t

@@ -335,4 +335,3 @@ my $holiday_for_another_branch = DateTime->new(
     is ( $cal->is_holiday($holiday_for_another_branch), 1, 'Holiday defined for CPL should be defined as an holiday' );
 }
 
-1;

t/Charset.t

@@ -70,5 +70,3 @@ ok( Encode::is_utf8($record->subfield('100','a')) &&
     'SetUTF8Flag sets the UTF-8 flag to all subfields' );
 
 is( nsb_clean("˜Leœ Moyen Âge"), "Le Moyen Âge", "nsb_clean removes ˜ and œ" );
-
-1;

t/Circulation_barcodedecode.t

@@ -61,4 +61,3 @@ foreach my $filter (@filters) {
 #  ~ T, P or X followed by numeric characters
 #  ~ No checkdigit
 
-1;

t/Images.t

@@ -74,4 +74,3 @@ is( $imagenumbers[1], 3, 'imagenumber is 3' );
 
 is( $imagenumbers[4], undef, 'imagenumber undef' );
 
-1;

t/Koha.t

@@ -155,4 +155,3 @@ ok($@ eq '', 'NormalizeISSN does not throw exception when parsing invalid ISSN')
 is($issns[0], 'abc', 'Original ISSN passed through even if invalid');
 is(scalar(@issns), 1, 'zero additional variations returned of invalid ISSN');
 
-1;

t/Koha/Config.t

@@ -59,4 +59,3 @@ subtest 'read_from_file() tests' => sub {
     is( $result, undef, 'Returns undef on error confition' );
 };
 
-1;

t/Koha/Util/Normalize.t

@@ -82,4 +82,3 @@ subtest 'lower_case() normalizer' => sub {
         'The \'lower_case\' normalizer only makes characters lower-case' );
 };
 
-1;

t/Koha_MetadataRecord.t

@@ -141,4 +141,3 @@ subtest "new() tests" => sub {
     is( $metadata_record, undef, 'record object mandatory')
 };
 
-1;

t/Koha_Template_Plugin_Koha.t

@@ -76,4 +76,3 @@ subtest "Koha::Template::Plugin::Koha::Version tests" => sub {
 
 };
 
-1;

t/Letters.t

@@ -69,4 +69,3 @@ t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', 1);
 $letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
 is( ref($letter), 'HASH');
 
-1;

t/Logger.t

@@ -74,4 +74,3 @@ sub mytempfile {
     return $fn;
 }
 
-1;

t/Matcher.t

@@ -316,4 +316,3 @@ sub get_authors_matchpoint {
     return $matchpoint;
 }
 
-1;

t/Patron.t

@@ -324,4 +324,3 @@ subtest 'Set tests' => sub {
     is( $patron->privacy,             '667789',                           'privacy field set ok' );
 };
 
-1;

t/SIP/Sip.t

@@ -55,4 +55,3 @@ warning_is { $invalidTest = C4::SIP::Sip::Checksum::verify_cksum("1234567") }
             'verify_cksum prints the expected warning for an invalid checksum';
 is($invalidTest, 0, "Checksum: 1234567 is invalid as expected");
 
-1;

t/SMS.t

@@ -60,4 +60,3 @@ $send_sms = C4::SMS->send_sms({
 });
 is( $send_sms, 1, 'send_sms returns 1' );
 
-1;

t/Search.t

@@ -160,4 +160,3 @@ subtest "_build_initial_query tests" => sub {
 };
 
 
-1;

t/SocialData.t

@@ -76,4 +76,3 @@ is( $report->{'without'}->[0]->{'original'},
 is( $report->{'without'}->[0]->{'isbn'}, '9780596526740',
     'testing get_report' );
 
-1;

t/SuggestionEngine_AuthorityFile.t

@@ -59,4 +59,3 @@ is_deeply($result, [ { 'search' => 'an=1234', 'relevance' => 1, 'label' => 'Cook
 
 done_testing();
 
-1;

t/XSLT.t

@@ -86,4 +86,3 @@ my $matching_string = q{<syspref name="singleBranchMode">0</syspref>};
 my $sysprefs_xml = C4::XSLT::get_xslt_sysprefs();
 ok( $sysprefs_xml =~ m/$matching_string/, 'singleBranchMode has a value of 0');
 
-1;

t/db_dependent/Accounts.t

@@ -478,4 +478,3 @@ subtest 'balance' => sub {
     $patron->delete;
 };
 
-1;

t/db_dependent/Auth_with_cas.t

@@ -67,4 +67,3 @@ is(C4::Auth_with_cas::_url_with_get_params($cgi, 'intranet'),
 
 $dbh->rollback;
 
-1;

t/db_dependent/Auth_with_ldap.t

@@ -503,4 +503,3 @@ sub is_admin_bind {
 
 $schema->storage->txn_rollback();
 
-1;

t/db_dependent/Barcodes_ValueBuilder.t

@@ -77,4 +77,3 @@ is($scr, undef, 'annual javascript');
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Biblio.t

@@ -389,4 +389,3 @@ subtest 'deletedbiblio_metadata' => sub {
     is( $moved, $biblionumber, 'Found in deletedbiblio_metadata' );
 };
 
-1;

t/db_dependent/Circulation/Branch.t

@@ -280,4 +280,3 @@ t::lib::Mocks::mock_preference( 'item-level_itypes', 0 );
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/CheckIfIssuedToPatron.t

@@ -130,4 +130,3 @@ is( $check_if_issued, 1, 'CheckIfIssuedToPatron returns true' );
 
 $dbh->rollback();
 
-1;

t/db_dependent/Circulation/CheckValidBarcode.t

@@ -84,4 +84,3 @@ is( $check_valid_barcode, 0, 'CheckValidBarcode with an invalid barcode returns
 
 $dbh->rollback();
 
-1;

t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t

@@ -82,4 +82,3 @@ is( scalar @$onsite_checkouts, 1, "There is 1 pending on-site checkout" );
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/IsItemIssued.t

@@ -92,4 +92,3 @@ is(
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/MarkIssueReturned.t

@@ -58,4 +58,3 @@ unlike ( $@, qr<Fatal error: the patron \(\d+\) .* AnonymousPatron>, );
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/NoIssuesChargeGuarantees.t

@@ -65,4 +65,3 @@ is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, "Patron cannot check
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/Returns.t

@@ -328,4 +328,3 @@ subtest 'Handle ids duplication' => sub {
     is( Koha::Checkouts->find( $issue_id )->issue_id, $issue_id, 'The issues entry should not have been removed' );
 };
 
-1;

t/db_dependent/Circulation/StoreLastBorrower.t

@@ -141,4 +141,3 @@ subtest 'Test StoreLastBorrower' => sub {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/SwitchOnSiteCheckouts.t

@@ -160,4 +160,3 @@ is( exists $impossible->{TOO_MANY}, '', 'Specific case 2 - Switch is allowed' );
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/TooMany.t

@@ -413,4 +413,3 @@ sub teardown {
     $dbh->do(q|DELETE FROM issuingrules|);
 }
 
-1;

t/db_dependent/Circulation/dateexpiry.t

@@ -120,4 +120,3 @@ sub calc_date_due {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Circulation/transfers.t

@@ -194,4 +194,3 @@ cmp_deeply(
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Clubs.t

@@ -231,4 +231,3 @@ is( $patron->get_enrollable_clubs->count,
 is( $club->club_enrollments->count, 1, 'There is 1 enrollment for club' );
 
 $schema->storage->txn_rollback();
-1;

t/db_dependent/Context.t

@@ -149,4 +149,3 @@ sub TransformVersionToNum {
     $version =~ s/XXX$/999/;
     return $version;
 }
-1;

t/db_dependent/DecreaseLoanHighHolds.t

@@ -190,4 +190,3 @@ ok( $needsconfirmation->{HIGHHOLDS}, "High holds checkout needs confirmation" );
 ok( !$needsconfirmation->{HIGHHOLDS}, "High holds checkout does not need confirmation" );
 
 $schema->storage->txn_rollback();
-1;

t/db_dependent/Exporter/Record.t

@@ -213,4 +213,3 @@ subtest 'export without record_type' => sub {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Filter_MARC_ViewPolicy.t

@@ -206,4 +206,3 @@ subtest 'Koha::Filter::MARC::ViewPolicy intranet tests' => sub {
     $schema->storage->txn_rollback();
 };
 
-1;

t/db_dependent/Hold.t

@@ -172,4 +172,3 @@ subtest "delete() tests" => sub {
     $schema->storage->txn_rollback();
  };
 
-1;

t/db_dependent/Holidays.t

@@ -203,4 +203,3 @@ sub _add_exception {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/ILSDI_Services.t

@@ -198,4 +198,3 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes
     $schema->storage->txn_rollback;
 };
 
-1;

t/db_dependent/Items/MoveItemFromBiblio.t

@@ -95,4 +95,3 @@ is( $get_item_level_hold_2->{biblionumber}, $to_biblio->{biblionumber},   'MoveI
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Items_DelItemCheck.t

@@ -167,4 +167,3 @@ is( $test_item->{itemnumber}, undef,
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/BiblioUtils.t

@@ -57,4 +57,3 @@ is( $subtitles[1], 'Another Test Record Subtitle', 'Got second subtitle correctl
 
 $schema->storage->txn_rollback();
 
-1;

t/db_dependent/Koha/Biblios.t

@@ -82,4 +82,3 @@ subtest 'subscriptions' => sub {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Checkouts.t

@@ -105,4 +105,3 @@ is( Koha::Checkouts->search->count, $nb_of_checkouts + 1, 'Delete should have de
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Cities.t

@@ -56,4 +56,3 @@ is( Koha::Cities->search->count, $nb_of_cities + 1, 'Delete should have deleted
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/CsvProfiles.t

@@ -54,4 +54,3 @@ is( Koha::CsvProfiles->search->count, $nb_of_csv_profiles + 1, 'Delete should ha
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Filter/EmbedItemsAvailability.t

@@ -150,4 +150,3 @@ subtest 'EmbedItemsAvailability tests' => sub {
     $schema->storage->txn_rollback();
 };
 
-1;

t/db_dependent/Koha/IssuingRules.t

@@ -250,4 +250,3 @@ sub _row_match {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Item/Transfers.t

@@ -66,4 +66,3 @@ is( $retrieved_transfer_1->itemnumber, $new_transfer_1->itemnumber, 'Find a tran
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Items.t

@@ -123,4 +123,3 @@ is( Koha::Items->search->count, $nb_of_items + 1, 'Delete should have deleted th
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Libraries.t

@@ -87,4 +87,3 @@ $retrieved_category_2->delete;
 is( Koha::LibraryCategories->search->count, $nb_of_categories + 2, 'Delete should have deleted the library category' );
 
 $schema->storage->txn_rollback;
-1;

t/db_dependent/Koha/MarcSubfieldStructures.t

@@ -54,4 +54,3 @@ is( Koha::MarcSubfieldStructures->search->count, $nb_of_fields + 1, 'Delete shou
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/News.t

@@ -56,4 +56,3 @@ is( Koha::News->search->count, $nb_of_news + 1, 'Delete should have deleted the
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Notices.t

@@ -68,4 +68,3 @@ is( Koha::Notice::Templates->search->count,
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Objects.t

@@ -214,4 +214,3 @@ subtest 'Exceptions' => sub {
 };
 
 $schema->storage->txn_rollback;
-1;

t/db_dependent/Koha/Patron/Attribute/Types.t

@@ -336,4 +336,3 @@ subtest 'search() with branch limits tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;

t/db_dependent/Koha/Patron/Attributes.t

@@ -275,4 +275,3 @@ subtest 'type() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;

t/db_dependent/Koha/Patron/Categories.t

@@ -115,4 +115,3 @@ is( Koha::Patron::Categories->search->count, $nb_of_categories + 2, 'upperagelim
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Patron/Images.t

@@ -51,4 +51,3 @@ is( Koha::Patron::Images->search->count, $nb_of_images, 'Delete should have dele
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Patron/Messages.t

@@ -93,4 +93,3 @@ sub get_nb_of_logactions {
     return scalar( @{ C4::Log::GetLogs( undef, undef, undef, ['MEMBERS'] ) } );
 }
 
-1;

t/db_dependent/Koha/Patron/Modifications.t

@@ -370,4 +370,3 @@ subtest 'pending_count() and pending() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;

t/db_dependent/Koha/Patrons.t

@@ -913,4 +913,3 @@ is( Koha::Patrons->search->count, $nb_of_patrons + 1, 'Delete should have delete
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Ratings.t

@@ -57,4 +57,3 @@ is( Koha::Ratings->search( { biblionumber => $biblionumber } )->count, 0, 'Delet
 
 is( int(Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating), 0, 'get_avg_rating should return 0 if no rating exist' );
 
-1;

t/db_dependent/Koha/Reviews.t

@@ -70,4 +70,3 @@ is( Koha::Reviews->search->count, $nb_of_reviews + 2, 'Delete should have delete
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/SMS_Providers.t

@@ -72,4 +72,3 @@ is( Koha::SMS::Providers->search->count,
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha/Suggestions.t

@@ -78,4 +78,3 @@ is( Koha::Suggestions->search->count, $nb_of_suggestions + 1, 'Delete should hav
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Koha_Elasticsearch.t

@@ -151,5 +151,3 @@ subtest 'get_fixer_rules() tests' => sub {
     $schema->storage->txn_rollback;
 
 };
-
-1;

t/db_dependent/Koha_Elasticsearch_Indexer.t

@@ -122,5 +122,3 @@ subtest '_convert_marc_to_json() tests' => sub {
 
     $schema->storage->txn_rollback;
 };
-
-1;

t/db_dependent/Koha_Misc_Files.t

@@ -87,4 +87,3 @@ is(scalar @{$mf_b_221->GetFilesInfo()}, 0, "GetFilesInfo() result count after De
 
 $dbh->rollback;
 
-1;

t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t

@@ -103,4 +103,3 @@ subtest 'build_query tests' => sub {
         'holdingbranch not added to facets if DisplayLibraryFacets=home' );
 };
 
-1;

t/db_dependent/Labels/t_Layout.t

@@ -109,4 +109,3 @@ is($updated_layout->get_text_wrap_cols(label_width => 180, left_text_margin => 1
 my $del_results = $updated_layout->delete();
 ok( ! defined($del_results) , "Layout->delete() success");
 
-1;

t/db_dependent/Labels/t_Profile.t

@@ -95,4 +95,3 @@ is_deeply($updated_profile, $saved_profile, "Updated layout object verify succes
 my $del_results = $updated_profile->delete();
 ok($del_results ne -1, "Profile->delete() success");
 
-1;

t/db_dependent/Labels/t_Template.t

@@ -135,4 +135,3 @@ foreach my $key (keys %{$expect_conv}) {
 my $del_results = $updated_template->delete();
 ok($del_results ne -1, "Template->delete() success");
 
-1;

t/db_dependent/Members/GetAllIssues.t

@@ -111,4 +111,3 @@ is( $issues->[0]->{itemnumber}, $itemnumber3, '' );
 
 $schema->storage->txn_begin;
 
-1;

t/db_dependent/Members/GetPendingIssues.t

@@ -127,4 +127,3 @@ is( @$issues, 0,
 
 $schema->storage->txn_begin;
 
-1;

t/db_dependent/Members/IssueSlip.t

@@ -403,4 +403,3 @@ subtest 'bad calls' => sub {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Passwordrecovery.t

@@ -194,4 +194,3 @@ ok( scalar @$letters == 2, "[SendPasswordRecoveryEmail] UPDATE == ON sends a new
 
 $schema->storage->txn_rollback();
 
-1;

t/db_dependent/Patron/Borrower_Discharge.t

@@ -128,4 +128,3 @@ is( ref(Koha::Patron::Discharge::request({ borrowernumber => $patron->{borrowern
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Patron/Borrower_PrevCheckout.t

@@ -445,4 +445,3 @@ map {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Patron/Housebound.t

@@ -36,4 +36,3 @@ is(
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Patron/HouseboundProfiles.t

@@ -72,4 +72,3 @@ is(
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Patron/HouseboundRoles.t

@@ -85,4 +85,3 @@ isa_ok(Koha::Patrons->search_housebound_deliverers->next, "Koha::Patron");
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Patron/HouseboundVisits.t

@@ -86,4 +86,3 @@ isa_ok( $result->chooser, "Koha::Patron");
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/PatronLists.t

@@ -102,4 +102,3 @@ ok( !@lists, 'DelPatronList works' );
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Patrons.t

@@ -105,4 +105,3 @@ foreach my $b ( $patrons->as_list() ) {
 
 $schema->storage->txn_rollback();
 
-1;

t/db_dependent/QueryParser.t

@@ -68,4 +68,3 @@ sub get_default_search_class {
     return $default_search_class;
 }
 
-1;

t/db_dependent/RefundLostItemFeeRule.t

@@ -280,4 +280,3 @@ subtest 'Koha::RefundLostItemFeeRules::should_refund() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;

t/db_dependent/Reserves/GetReserveFee.t

@@ -222,4 +222,3 @@ sub addreserve {
 
 $schema->storage->txn_rollback;
 
-1;

t/db_dependent/Reserves/MultiplePerRecord.t

@@ -285,4 +285,3 @@ is( $can, 'tooManyHoldsForThisRecord', 'Third hold exceeds limit of holds per re
 
 $schema->storage->txn_rollback;
 
-1;