gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/opac
History
Jonathan Druart 029ccc0d51 Bug 16179: Do not crash if "rate me" is clicked and not rate selected 
If JS is disabled and a user clicks on the "Rate me" button, Koha will
crashes with:
DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
at /usr/share/koha/lib/C4/Ratings.pm line 208

To avoid that, opac-ratings.pl will check if a rate has been selected.

Test plan:
Disable JS
On a record detail page, click on the "Rate me" button

TESTED PLAN:
1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1
   -- kaboom as above.
2) apply patch
3) refresh
   -- either login screen (don't know why)
   -- or if already logged in, detail page.
4) koha qa test tool

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I tested successfully by temporarily removing the modification made by
Bug 16210.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
(cherry picked from commit b679cac964)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit a965702c08)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
 		2016-04-27 17:02:34 +02:00
..
errors Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
rss
…
sco Bug 14298: Use the new permission in the sco scripts 2015-09-23 06:07:21 +12:00
svc Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
ilsdi.pl Bug 6679 - Fixing code so it passes basic Perl:::Critic tests 2016-02-11 18:55:50 +01:00
maintenance.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
oai.pl Bug 15946 Valid namespace for OAI marcxml schema (3.22/3.20) 2016-03-23 13:50:56 +01:00
opac-ISBDdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-MARCdetail.pl Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl 2015-12-31 18:39:28 +01:00
opac-account.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
opac-addbybiblionumber.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-20 08:39:19 +01:00
opac-alert-subscribe.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-authorities-home.pl Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl 2016-04-27 16:38:45 +02:00
opac-authoritiesdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-basket.pl Bug 5371: Force no caching for private pages at the OPAC 2015-12-04 20:24:56 +01:00
opac-blocked.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-browser.pl Bug 5371: Force no caching for private pages at the OPAC 2015-12-04 20:24:56 +01:00
opac-changelanguage.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-details.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-reserves.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-detail.pl Bug 14496: Improving opac-detail.pl performances 2015-07-15 08:53:20 +12:00
opac-discharge.pl Bug 5371: Force no caching for private pages at the OPAC 2015-12-04 20:24:56 +01:00
opac-downloadcart.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-downloadshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-20 08:39:19 +01:00
opac-export.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-ics.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
opac-idref.pl Bug 8992: Interfacing with the Idref webservice 2015-04-28 15:46:26 -03:00
opac-image.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-imageviewer.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-main.pl Bug 15613: Fix 2 other occurrences of paramter vs parameter 2016-02-11 20:07:25 +01:00
opac-memberentry.pl Bug 5371: Force no caching for private pages at the OPAC 2015-12-04 20:24:56 +01:00
opac-messaging.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
opac-modrequest-suspend.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-modrequest.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-mymessages.pl Bug 5371: Force no caching for private pages at the OPAC 2015-12-04 20:24:56 +01:00
opac-news-rss.pl Bug 7843: (QA followup) Make news selection persistant 2015-04-30 16:33:21 -03:00
opac-overdrive-search.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-passwd.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
opac-patron-image.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-privacy.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
opac-ratings-ajax.pl Bug 14553: Silencing warn triggered when clearing item rating on OPAC 2015-11-29 21:55:24 +01:00
opac-ratings.pl Bug 16179: Do not crash if "rate me" is clicked and not rate selected 2016-04-27 17:02:34 +02:00
opac-readingrecord.pl Bug 5371: (follow-up) Force no caching for private pages at the OPAC 2015-12-04 20:25:22 +01:00
opac-registration-verify.pl Bug 11693: Default emailing preferences not loaded for self registering patron 2015-08-10 09:33:36 +12:00
opac-renew.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-reserve.pl Bug 15375 [QA Followup] - Fix non-functional restriction message and date 2016-02-11 20:10:58 +01:00
opac-review.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-search-history.pl Bug 5371: Force no caching for private pages at the OPAC 2015-12-04 20:24:56 +01:00
opac-search.pl Bug 15818 - OPAC search with utf-8 characters and without results generates encoding error 2016-03-01 14:39:44 +01:00
opac-sendbasket.pl Bug 14330: Remove unused email_sender from sendbasket/sendshelf 2015-06-09 08:38:40 +12:00
opac-sendshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-20 08:39:19 +01:00
opac-serial-issues.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-shareshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-20 08:39:19 +01:00
opac-shelves.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-20 08:39:19 +01:00
opac-showmarc.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-showreviews.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-suggestions.pl Bug 15035: Anti-spam for opac-suggestions - FOLLOW-UP 2015-11-29 21:32:18 +01:00
opac-tags.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-tags_subject.pl Bug 14412: SQL injection possible 2015-06-23 10:11:53 +12:00
opac-topissues.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-user.pl Bug 14930 [QA Followup] - Allow OpacFineNoRenewals to be 0 2016-03-01 14:51:17 +01:00
tracklinks.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
unapi Bug 15190: Bad utf8 decode to unapi and fixing status code 200 2016-02-11 20:09:55 +01:00