gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 14330: Remove unused email_sender from sendbasket/sendshelf 

The sendbasket/sendshelf scripts and templates do not use email_sender
as a cgi parameter or as a template var. Probably a leftover from previous
changes.
Let's make Koha cleaner :)

Test plan:
[1] Send your cart from opac or staff.
[2] Send a shelf from opac or staff.
[3] Git grep email_sender. No results.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 0114465ced)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
Marcel de Rooy 2015-06-04 12:47:13 +02:00 committed by Chris Cormack
parent 6406398495
commit 431310eb0b
4 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
basket/sendbasket.pl
View File

@ -46,7 +46,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
my $bib_list = $query->param('bib_list');
my $email_add = $query->param('email_add');
my $email_sender = $query->param('email_sender');
my $dbh = C4::Context->dbh;
@ -101,7 +100,6 @@ if ( $email_add ) {
my $resultsarray = \@results;
$template2->param(
BIBLIO_RESULTS => $resultsarray,
email_sender => $email_sender,
comment => $comment
);

2
opac/opac-sendbasket.pl
View File

@ -49,7 +49,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
my $bib_list = $query->param('bib_list');
my $email_add = $query->param('email_add');
my $email_sender = $query->param('email_sender');
my $dbh = C4::Context->dbh;
@ -117,7 +116,6 @@ if ( $email_add ) {
$template2->param(
BIBLIO_RESULTS => $resultsarray,
email_sender => $email_sender,
comment => $comment,
firstname => $user->{firstname},
surname => $user->{surname},

1
opac/opac-sendshelf.pl
View File

@ -111,7 +111,6 @@ if ( $email ) {
$template2->param(
BIBLIO_RESULTS => \@results,
email_sender => $mail{'from'},
comment => $comment,
shelfname => $shelf[1],
firstname => $user->{firstname},

1
virtualshelves/sendshelf.pl
View File

@ -103,7 +103,6 @@ if ($email) {
$template2->param(
BIBLIO_RESULTS => \@results,
email_sender => $mail{'from'},
comment => $comment,
shelfname => $shelf[1],
);