Koha-clms/Koha
Pedro Amorim c81a4bb213
Bug 34920: Ensure 'description' property is an empty string if 'lib' is null
Test plan:
1. Enable ERM module
2. Confirm that you can open the ERM module in the staff interface.
3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit the 'Cancelled' authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error.
4. Go back to the ERM module and notice that there is an error. 'Something went wrong: Error: Expected string - got null.'
5. Apply patch. Run yarn js:build. Repeat test plan
6. Create a new agreement. Pick status 'Closed'.
7. Open 'Closure reason'. Confirm there is an entry for 'Expired' and an empty entry below that.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-07-01 18:55:48 +02:00
..
Account Bug 28664: (follow-up) Throw exception if debt if VOID 2024-06-28 13:49:19 +02:00
Acquisition Bug 36018: (follow-up) Disambiguate quantity 2024-05-10 16:45:48 +02:00
App
…
ArticleRequest
…
Auth Bug 37157: Fix Malformed UTF-8 character in JSON string before decode_json 2024-06-27 11:50:06 +02:00
Authority
…
BackgroundJob Bug 34788: (follow-up): Fix translations 2024-05-10 17:46:15 +02:00
Biblio Bug 31791: Add Koha::Biblio::Metadata->record_source 2024-04-26 20:15:38 +02:00
Cache
…
Cash Bug 36481: (QA follow-up) Rename branch_default to library_default 2024-05-01 13:51:41 +01:00
Charges
…
Checkouts
…
Club Bug 29523: (QA follow-up) Fix failing test in club holds 2023-10-27 16:40:43 -03:00
CodeList/Unimarc
…
Config
…
Course Bug 33568: Course reserves 2024-04-05 15:34:52 +02:00
Database Bug 32313: Update issues to checkouts and copies to items 2024-06-25 18:34:16 +02:00
DateTime/Format Bug 36432: Remove circular dependency from Koha::Object 2024-04-04 15:24:32 +02:00
ERM Bug 34788: (QA follow-up) 2024-05-10 15:19:09 +02:00
Edifact Bug 35724: (QA follow-up) Also account for port in FTP 2024-04-19 18:31:37 +02:00
Exceptions Bug 32610: (QA follow-up) Tidy exceptions file 2024-04-30 17:09:52 +02:00
Exporter Bug 31286: (QA follow-up): tidy up code 2024-03-25 09:53:24 +01:00
ExternalContent
…
Filter/MARC Bug 34481: Tidy altered code 2024-06-27 14:04:50 +02:00
Hold Bug 28966: (QA follow-up) Changes for Koha objects 2023-07-25 16:25:39 -03:00
ILL Bug 34838: Use ->set to avoid method redefinition warnings 2024-06-11 13:28:16 +01:00
Import
…
Indexer
…
Installer Bug 35681: Add Koha::Installer::Output 2024-05-02 16:47:40 +02:00
Item Bug 33568: Display library names instead of codes for transfers 2024-04-05 15:34:56 +02:00
Library Bug 6796: Add library_hours table and set opening hours for library 2024-04-12 11:26:03 +02:00
List
…
MetadataRecord Bug 35345: Add --where option to rebuild_elasticsearch.pl 2024-04-22 12:39:26 +02:00
Middleware Bug 36367: Remove _new_userenv 2024-06-14 11:17:17 +01:00
Misc
…
Notice Bug 36815: (follow-up) Use correct language for default 2024-06-27 14:04:53 +02:00
Number
…
OAI/Server Bug 34467: OAI GetRecord bad encoding for Unimarc 2023-10-09 16:41:29 -03:00
Object
…
Objects
…
Old Bug 35353: Add REST API endpoint to retrieve old holds 2024-04-26 18:06:09 +02:00
Patron Bug 34597: Add 'ill_request' to patron category admin page 2024-06-11 10:43:55 +01:00
Patrons Bug 34621: implement Patron import option to 'Renew existing patrons' 'from the current membership expiry date' 2024-04-12 14:02:41 +02:00
Plugins Bug 35536: Add RemovePlugins calls in plugin unit tests 2024-03-22 12:26:39 +01:00
Policy Bug 30825: Move holds_control_library to Koha::Policy::Holds 2023-09-22 12:35:46 -03:00
Preservation Bug 33547: (QA follow-up) Tidy 2023-10-23 11:33:53 -03:00
REST Bug 34920: Return sorted av_cats to be able to test 2024-07-01 18:55:47 +02:00
RecordProcessor
…
Result
…
SMS
…
SMTP Bug 29523: (QA follow-up) Catch remaining SUPER::to_api cases 2023-10-27 16:40:42 -03:00
Schema Bug 36330: Change 'reseve' to 'reserve' 2024-06-13 14:27:15 +01:00
SearchEngine Bug 34481: Tidy altered code 2024-06-27 14:04:50 +02:00
Serial Bug 33568: enumchron/volinfo 2024-04-05 15:34:47 +02:00
Sitemapper Bug 33870: Make $MAX in Sitemapper::Writer global 2023-09-01 11:23:23 -03:00
Subscription
…
SuggestionEngine
…
Tags
…
Template/Plugin Bug 36941: Limit login branch list when IP restriction enabled 2024-06-28 13:49:26 +02:00
Ticket Bug 35657: Add support for assignee_id to ticket_updates endpoint 2024-05-02 15:03:35 +02:00
UI Bug 36794: Illegitimate modification of biblionumber subfield content (999 $c) 2024-05-13 10:36:11 +02:00
Util Bug 36976: Warning 'Argument "" isn't numeric in numeric' in log when merging bibliographic records 2024-06-28 13:49:24 +02:00
XSLT
…
Z3950Responder
…
pdfformat Bug 33393: tidy layout1page.pm 2024-04-19 19:54:46 +02:00
Account.pm Bug 31427: Remove a few refs to CanBookBeRenewed 2024-03-07 16:36:44 +01:00
ActionLog.pm
…
ActionLogs.pm
…
AdditionalContent.pm Bug 36875: (follow-up) Modify query in translated_content 2024-06-20 17:55:39 +02:00
AdditionalContents.pm Bug 31383: Use one query in search_for_display instead of four 2023-10-20 14:44:02 -03:00
AdditionalContentsLocalization.pm Bug 31383: (QA follow-up) Tidy 2023-10-20 14:44:03 -03:00
AdditionalContentsLocalizations.pm Bug 31383: Create a parent-child DB relation for additional content 2023-10-20 14:43:56 -03:00
AdditionalField.pm Bug 35197: Rename to 'Extended attribute types' 2024-06-27 14:04:58 +02:00
AdditionalFieldValue.pm
…
AdditionalFieldValues.pm
…
AdditionalFields.pm
…
AdvancedEditorMacro.pm
…
AdvancedEditorMacros.pm
…
ApiKey.pm
…
ApiKeys.pm
…
ArticleRequest.pm Bug 35030: Add 'article' to patron activity triggers 2023-10-24 10:05:26 -03:00
ArticleRequests.pm
…
AudioAlert.pm
…
AudioAlerts.pm
…
AuthUtils.pm
…
AuthorisedValue.pm Bug 34920: Ensure 'description' property is an empty string if 'lib' is null 2024-07-01 18:55:48 +02:00
AuthorisedValueCategories.pm
…
AuthorisedValueCategory.pm
…
AuthorisedValues.pm Bug 35579: Cache authorised value lookup by MARC field 2023-12-28 12:16:09 +01:00
Authorities.pm
…
Authority.pm Bug 29948: OPACAuthorIdentifiersAndInformation 2024-05-13 14:00:10 +02:00
BackgroundJob.pm Bug 36367: Remove _new_userenv 2024-06-14 11:17:17 +01:00
BackgroundJobs.pm
…
Biblio.pm Bug 35994: Add $biblio->acq_status 2024-05-10 16:45:53 +02:00
BiblioFramework.pm
…
BiblioFrameworks.pm
…
BiblioUtils.pm Bug 35345: Add --where option to rebuild_elasticsearch.pl 2024-04-22 12:39:26 +02:00
Biblioitem.pm Bug 32711: Add 'public_read_list' appropriately 2023-07-24 13:58:25 -03:00
Biblioitems.pm
…
Biblios.pm
…
Booking.pm Bug 36120: Add pickup_library support to bookings API 2024-05-03 16:02:46 +02:00
Bookings.pm Bug 36428: (QA follow-up) Remove filter_by_future 2024-06-21 15:02:51 +02:00
Cache.pm
…
Caches.pm
…
Calendar.pm Bug 27249: Prevent infinite loop when searching for an open day 2023-10-17 14:45:31 -03:00
Checkout.pm Bug 34924: Handle final renewal errors 2023-10-31 11:02:47 -03:00
Checkouts.pm Bug 33887: (QA follow-up) Perltidy and fix some formatting issues 2023-10-25 12:09:53 -03:00
CirculationRule.pm
…
CirculationRules.pm Bug 8367: Add holds_pickup_period circulation rule 2023-11-01 18:01:30 -03:00
Cities.pm
…
City.pm
…
ClassSortRule.pm
…
ClassSortRules.pm
…
ClassSource.pm
…
ClassSources.pm
…
ClassSplitRule.pm
…
ClassSplitRules.pm
…
Club.pm
…
Clubs.pm
…
Config.pm Bug 31393: Koha::Config: handle the special case for 'content' attribute 2023-10-30 09:02:17 -03:00
CookieManager.pm
…
Course.pm
…
Courses.pm
…
CoverImage.pm
…
CoverImages.pm
…
CsvProfile.pm
…
CsvProfiles.pm
…
CurbsidePickup.pm Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
CurbsidePickupIssue.pm
…
CurbsidePickupIssues.pm
…
CurbsidePickupOpeningSlot.pm
…
CurbsidePickupOpeningSlots.pm
…
CurbsidePickupPolicies.pm
…
CurbsidePickupPolicy.pm
…
CurbsidePickups.pm
…
Database.pm Bug 36367: Remove schema_stack 2024-06-14 11:17:18 +01:00
DateUtils.pm Bug 36432: Remove circular dependency from Koha::Object 2024-04-04 15:24:32 +02:00
Desk.pm Bug 36480: Add GET /libraries/:library_id/desks 2024-04-26 18:06:10 +02:00
Desks.pm
…
EDI.pm Bug 19097: Adjust some GetMarcFromKohaField calls 2024-04-29 09:35:47 +02:00
Edifact.pm
…
Email.pm Bug 31627: (follow-up) Update -Id to -ID 2024-05-10 14:11:50 +02:00
Encryption.pm
…
Exception.pm
…
Exceptions.pm Bug 28869: Implement authorised_value_categories.is_integer_only 2024-05-17 10:36:23 +02:00
ExternalContent.pm
…
FrameworkPlugin.pm Bug 35012: Apply change to all events 2023-11-14 10:32:40 -03:00
Hold.pm Bug 25159: Implement diffs in action logs for holds 2024-05-02 16:47:43 +02:00
Holds.pm
…
I18N.pm Bug 35174: Do not explode if po dir does not exist 2023-11-16 08:56:36 +01:00
ImportBatch.pm
…
ImportBatchProfile.pm
…
ImportBatchProfiles.pm
…
ImportBatches.pm
…
Item.pm Bug 36535: (bug 33568 follow-up) Add missing tests 2024-04-26 14:14:48 +02:00
ItemType.pm Bug 34008: Harmonize attribute names 2023-11-01 17:23:15 -03:00
ItemTypes.pm
…
Items.pm Bug 34360: Get distinct biblionumber 2024-05-10 14:11:42 +02:00
KeyboardShortcut.pm
…
KeyboardShortcuts.pm
…
Libraries.pm
…
Library.pm Bug 36480: Add Koha::Library->desks 2024-04-26 18:06:09 +02:00
Linktracker.pm
…
Localization.pm
…
Localizations.pm
…
Logger.pm Bug 35907: Add ability to log all custom report runs with or without query 2024-05-10 16:45:45 +02:00
Manual.pm Bug 35463: More preservation manual links 2023-12-20 15:13:45 +01:00
MarcOverlayRule.pm
…
MarcOverlayRules.pm
…
MarcSubfieldStructure.pm
…
MarcSubfieldStructures.pm
…
MetaSearcher.pm
…
MetadataIterator.pm
…
MetadataRecord.pm Bug 33749: Use TrimFields instead of stripWhitespaceChars 2023-11-03 12:08:06 -03:00
MoreUtils.pm
…
OAuth.pm
…
OAuthAccessToken.pm
…
OAuthAccessTokens.pm
…
Object.pm Bug 36432: Remove circular dependency from Koha::Object 2024-04-04 15:24:32 +02:00
Objects.pm Bug 36873: Make Koha::Objects->delete pass parameters to the underlying method 2024-07-01 18:55:43 +02:00
OverdueRule.pm Bug 29145: (QA follow-up) Use objects instead of straight SQL queries 2023-10-03 09:24:41 -04:00
OverdueRules.pm Bug 29145: (QA follow-up) Use objects instead of straight SQL queries 2023-10-03 09:24:41 -04:00
Patron.pm Bug 19613: Use the 'note' profile 2024-05-14 15:04:35 -03:00
Patrons.pm Bug 36508: Refresh patron object when updating category 2024-04-30 14:32:05 +02:00
Plugins.pm Bug 30897: Remove recursive parent identification loop 2024-04-11 16:53:43 +02:00
ProblemReport.pm
…
ProblemReports.pm
…
PseudonymizedTransaction.pm Bug 34611: Add pseudonymize routine to Koha::Statistics 2024-03-19 10:25:05 +01:00
PseudonymizedTransactions.pm
…
Quote.pm
…
Quotes.pm
…
Rating.pm
…
Ratings.pm
…
Recall.pm Bug 33568: Display library names instead of codes for recall 2024-04-05 15:34:57 +02:00
Recalls.pm
…
RecordProcessor.pm
…
RecordSource.pm Bug 35919: Add Koha::RecordSource(s) classes 2024-04-26 17:06:03 +02:00
RecordSources.pm Bug 35919: Add Koha::RecordSource(s) classes 2024-04-26 17:06:03 +02:00
Report.pm Bug 35746: add multiselect to report dropdowns 2024-04-26 18:06:19 +02:00
Reports.pm
…
Review.pm
…
Reviews.pm
…
Schema.pm
…
Script.pm Bug 36367: Remove _new_userenv 2024-06-14 11:17:17 +01:00
SearchEngine.pm
…
SearchField.pm Bug 20388: (QA follow-up) Tidy 2024-04-16 17:59:47 +02:00
SearchFields.pm
…
SearchFilter.pm
…
SearchFilters.pm
…
SearchMarcMap.pm
…
SearchMarcMaps.pm
…
Serial.pm
…
Serials.pm
…
Session.pm Bug 36098: Default to 'file' if pref does not exist 2024-03-01 10:55:51 +01:00
SharedContent.pm
…
SimpleMARC.pm Bug 35993: Add SimpleMarc::update_last_transaction_time 2024-04-29 09:35:55 +02:00
Sitemapper.pm Bug 33871: Use Koha object in Sitemapper, add optional filter 2023-09-01 11:23:25 -03:00
Statistic.pm Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed 2024-06-27 11:50:03 +02:00
Statistics.pm
…
StockRotationItem.pm
…
StockRotationItems.pm
…
StockRotationRota.pm
…
StockRotationRotas.pm
…
StockRotationStage.pm
…
StockRotationStages.pm
…
Subscription.pm
…
Subscriptions.pm
…
Suggestion.pm Bug 35597: Move modification logging to Koha::Suggestion 2024-06-13 14:08:33 +01:00
SuggestionEngine.pm
…
Suggestions.pm
…
Tag.pm
…
Tags.pm
…
TemplateUtils.pm
…
Ticket.pm Bug 36612: (QA follow-up) Add 'source' to public_read_list 2024-05-07 15:54:03 +02:00
Tickets.pm
…
Token.pm Bug 36102: If CSRF check fails, try with anonymous 2024-03-01 11:00:34 +01:00
TrackedLink.pm
…
TrackedLinks.pm
…
UploadedFile.pm
…
UploadedFiles.pm
…
Uploader.pm Bug: 36818 Escape characters in file names uploaded 2024-06-20 17:55:37 +02:00
Virtualshelf.pm
…
Virtualshelfcontent.pm
…
Virtualshelfcontents.pm
…
Virtualshelfshare.pm
…
Virtualshelfshares.pm
…
Virtualshelves.pm
…
Z3950Responder.pm
…
Z3950Server.pm
…
Z3950Servers.pm
…