gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 33568: Display library names instead of codes for transfers 

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2023-05-23 13:31:25 +02:00 committed by Katrin Fischer
parent 5f497eb58e
commit dfe71bac8d
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
3 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Koha/Item/Transfer.pm
View File

@ -176,6 +176,21 @@ sub cancel {
return $self;
}
=head3 strings_map
Returns a map of column name to string representations including the string.
=cut
sub strings_map {
my ($self) = @_;
return {
from_library => { str => $self->from_library->branchname, type => 'library' },
to_library => { str => $self->to_library->branchname, type => 'library' },
};
}
=head3 type
=cut

1
api/v1/swagger/paths/biblios.yaml
View File

@ -426,6 +426,7 @@
- checkout
- checkout.patron
- transfer
- transfer+strings
- first_hold
- first_hold.patron
- recall

6
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
View File

@ -2173,7 +2173,7 @@
[%# In case or SeparateHoldings we may need to display the number of biblios in each tab %]
[%# Do we need separate/new endpoints or do we hack the somewhere client-side? %]
let item_table_url = "/api/v1/biblios/[% biblio.biblionumber | uri %]/items?";
let embed = ["+strings,checkout,checkout.patron,transfer,first_hold,first_hold.patron,item_type"];
let embed = ["+strings,checkout,checkout.patron,transfer,transfer+strings,first_hold,first_hold.patron,item_type"];
[% IF Koha.Preference('LocalCoverImages') %]
embed.push('cover_image_ids');
[% END %]
@ -2397,9 +2397,9 @@
nodes += "</span>"
} else if ( row.transfer ) {
if ( row.transfer.datesent ) {
nodes += '<span class="intransit">%s</span>'.format(_("In transit from %s to %s since %s").format(escape_str(row.transfer.frombranch), escape_str(row.transfer.tobranch), $date(row.transfer.datesent))); [%# FIXME display library names, not codes, do we use _strings here? %]
nodes += '<span class="intransit">%s</span>'.format(_("In transit from %s to %s since %s").format(escape_str(row.transfer._strings.from_library.str), escape_str(row.transfer._strings.to_library.str), $date(row.transfer.datesent)));
} else {
nodes += '<span class="transitrequested">%s</span>'.format(_("Transit pending from %s to %s since %s").format(escape_str(row.transfer.frombranch), escape_str(row.transfer.tobranch), $date(row.transfer.daterequested))); [%# FIXME See above %]
nodes += '<span class="transitrequested">%s</span>'.format(_("Transit pending from %s to %s since %s").format(escape_str(row.transfer._strings.from_library_.str), escape_str(row.transfer._strings.to_library.str), $date(row.transfer.daterequested)));
}
}