Go to file
Slava Shishkin 99f69e987f Bug 35004: Set row.quantity_received to 1 if row.quantity_received is empty and we're in 'cataloguing' mode
Before the code changes only field value was set to 1,
but "row.quantity_received" still had an undefined value.
After correction row.quantity_received set to 1 if it is empty,
but only when effective_create_items == 'cataloguing',
and after that its value assigned to the form field.

To test:
1. Add a new basket.
2. Create an order line
3. Receive shipment and create an invoice
4. Start receiving your order:
    Verify:
    - Quantity ordered: X
    - Quantity received: 1 (pre-filled, don't touch or change it)
5. Click "Confirm"
6. Observe the Receive error popup: "Order ZZZ: No quantity to receive
   set. No items will be created."
7. Verify that "Order receive" was not happen (received orders remains
   empty)
8. Apply the patch and make sure your order is received correctly after
   step 5.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9110547de0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2023-11-09 16:20:46 -10:00
C4 Bug 34678: Allow new entries to overwrite hold_fill_targets 2023-11-07 21:37:08 -10:00
Koha Bug 24480: (follow-up) Shift new fields into array and add after all are copied 2023-11-09 15:58:08 -10:00
acqui Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket 2023-10-25 22:40:04 -10:00
admin Bug 34369: Require CSRF token for updating system preferences 2023-09-26 21:29:27 -10:00
api Bug 34008: Harmonize attribute names 2023-11-07 22:41:49 -10:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-17 22:49:50 -10:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
bin
…
catalogue Bug 33047: Return 404 instead of 500 when biblio does not exist 2023-07-18 10:28:24 +01:00
cataloguing Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl 2023-11-07 22:04:16 -10:00
circ Bug 35003: Make cancelled hold requests filter by branch 2023-11-07 21:40:50 -10:00
clubs
…
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 34204: Fix koha-shell under debian 12 2023-10-24 21:31:49 -10:00
docs Bug 34424: Add Emily Lamancusa to QA Team 2023-11-07 22:28:02 -10:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors
…
etc Bug 30843: Add mfa_range configuration option for TOTP 2023-10-05 08:36:20 -10:00
ill
…
installer Bug 35185: Remove is_html flag from sample notices that are plain text 2023-11-09 15:59:58 -10:00
koha-tmpl Bug 35004: Set row.quantity_received to 1 if row.quantity_received is empty and we're in 'cataloguing' mode 2023-11-09 16:20:46 -10:00
labels
…
lib/CGI/Session/Serialize
…
members Bug 34910: (follow-up) alert in patron details 2023-11-07 21:09:50 -10:00
misc Bug 35043: Use Locale::PO->quote 2023-11-08 11:00:50 +01:00
offline_circ Bug 33961: Remove built-in offline circ tool 2023-07-17 08:18:59 +01:00
opac Bug 33074: Take ReservesControlBranch into account in opac-reserve.pl 2023-10-09 09:56:08 -10:00
patron_lists
…
patroncards
…
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-05 10:18:57 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-07-17 14:51:00 +01:00
reports Bug 34859: Remove unnecessary params from reports-home.pl 2023-10-05 14:52:14 -10:00
reserve Bug 34634: Show expirationdate of expired holds on reserve/request.pl 2023-09-07 20:13:21 -10:00
reviews
…
rotating_collections
…
serials Bug 35073: perltidy subscription-batchedit.pl 2023-11-09 16:06:34 -10:00
services
…
skel
…
suggestion Bug 26994: List names in alphabetical order in Suggestion filter 2023-10-25 20:14:28 -10:00
svc Bug 34014: (follow-up) No need to parse old record before updating 2023-10-25 11:58:38 -10:00
t Bug 24480: (follow-up) Adjust tests 2023-11-09 15:58:08 -10:00
tags
…
tools Bug 26978: Add item type option to batch extend due date tool 2023-10-12 13:58:06 -10:00
virtualshelves Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-05 09:38:43 -10:00
.editorconfig
…
.eslintrc.json
…
.gitignore Bug 33710: Ignore how-to related files 2023-05-12 17:50:01 -03:00
.htaccess
…
.mailmap Update .mailmap 2023-07-17 08:12:22 +01:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-07-12 07:55:00 +01:00
.proverc.dist
…
.stylelintrc.json
…
INSTALL
…
Koha.pm Increment version for 23.05.05 release 2023-11-07 20:34:30 -10:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 26700: Remove occurrences in Makefile.PL 2023-07-17 11:01:46 +01:00
README
…
README.md
…
README.robots
…
about.pl Bug 35033: (QA follow-up): tidy up code 2023-11-07 22:29:10 -10:00
app.psgi
…
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
…
cpanfile Bug 33964: (QA follow-up) Remove library from cpanfile 2023-08-07 20:05:46 -10:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-04-13 11:48:00 -03:00
fix-perl-path.PL
…
gulpfile.js Bug 35079: Replace --force-extract by --generate-pot={always,auto,never} 2023-11-08 11:00:59 +01:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-25 20:22:12 -10:00
package.json Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00
rewrite-config.PL
…
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-27 11:12:01 -03:00
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo