Bug 35004: Set row.quantity_received to 1 if row.quantity_received is empty and we're in 'cataloguing' mode

Before the code changes only field value was set to 1,
but "row.quantity_received" still had an undefined value.
After correction row.quantity_received set to 1 if it is empty,
but only when effective_create_items == 'cataloguing',
and after that its value assigned to the form field.

To test:
1. Add a new basket.
2. Create an order line
3. Receive shipment and create an invoice
4. Start receiving your order:
    Verify:
    - Quantity ordered: X
    - Quantity received: 1 (pre-filled, don't touch or change it)
5. Click "Confirm"
6. Observe the Receive error popup: "Order ZZZ: No quantity to receive
   set. No items will be created."
7. Verify that "Order receive" was not happen (received orders remains
   empty)
8. Apply the patch and make sure your order is received correctly after
   step 5.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9110547de0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Slava Shishkin 2023-10-06 19:25:30 +03:00 committed by Fridolin Somers
parent 3621e32bd1
commit 99f69e987f
1 changed files with 4 additions and 1 deletions

View File

@ -1171,7 +1171,10 @@
$("#creator").html(_("Account has been deleted"));
}
$("#quantity_to_receive").val(row.quantity).prop('readonly', !row.subscription_id);
$("#quantity").val( effective_create_items == 'cataloguing' ? row.quantity_received || 1 : row.quantity_received )
if (effective_create_items == 'cataloguing' && ! row.quantity_received) {
row.quantity_received = 1;
}
$("#quantity").val( row.quantity_received )
.prop('readonly', !row.subscription_id && effective_create_items == 'receiving');
[% IF only_one_order %]
$(".modal-save").prop('disabled', $("#quantity").val() == 0);