Koha-clms/koha-tmpl/intranet-tmpl/prog/js
Owen Leonard a230878b6f Bug 21296: suspend hold ignores system preference on intranet
This patch modifies the DataTable configuration for the table of holds
which displays under the "Holds" tab on the patron's checkout and
details pages. A variable is now defined in the JavaScript with the
value of the "SuspendHoldsIntranet" system preference. This variable is
passed to the DataTable configuration to determine whether the column is
visible or not.

One of the changes made in this patch moves a <script> block so that it
appears before some of the JS includes on the page. This helps keep the
string-defining JS together in one block.

To test, apply the patch and set the "SuspendHoldsIntranet" system
preference to "Allow."

 - Open the checkout page for a patron with one or more holds.
 - Under the "Holds" tab, the table of holds should have a "Suspend"
   column with controls for suspending or resuming holds.
 - Check that the same is true on the patron detail page.
 - Set the "SuspendHoldsIntranet" system preference to "Don't allow."
 - Test the checkout and detail pages again and confirm that the
   "Suspend" column does not appear.

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 541dfa7dde)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit cc87e68e0d)
Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
2020-03-16 13:08:06 +13:00
..
pages Bug 19490: Add a 'Holds' column to the items batchmodification tool 2018-11-05 14:41:04 +00:00
acq.js Bug 18639: (follow-up) Populate replacement price from list price during ordering 2018-08-31 12:46:51 +00:00
acquisitions-menu.js Bug 20931: JS error "ReferenceError: $ is not defined" when CircSidebar is turned on 2018-07-02 11:10:00 +00:00
additem.js Bug 10442: Remove references to non-standard "error" class 2018-10-31 13:34:02 +00:00
admin-menu.js Bug 20931: JS error "ReferenceError: $ is not defined" when CircSidebar is turned on 2018-07-02 11:10:00 +00:00
ajax.js
…
audio_alerts.js Bug 16310 - Remove the use of "onclick" from audio alerts template 2016-08-01 14:35:27 +00:00
auth-finder-search.js Bug 20273: (follow-up) Autocomplete use start instead of contains 2018-07-19 17:25:16 +00:00
automatic_item_modification_by_age.js Bug 18752 - Automatic item modifications by age should allow 'blank' values 2017-06-13 16:21:37 -03:00
background-job-progressbar.js Bug 18707: Background jobs post disabled inputs 2019-08-06 04:40:27 +00:00
basket.js Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-07-19 16:12:56 +00:00
basketgroup.js Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
biblio_framework.js Bug 8558: (QA follow-up) a little more text clean up 2019-06-12 22:41:37 +00:00
cart.js Bug 22419: Records listed twice when select/unselect all from the cart 2019-03-12 08:44:29 +00:00
catalog.js Bug 21556: Deleting same record twice leads to fatal software error 2018-11-01 19:05:12 +00:00
cataloging.js Bug 23183: Reindent cataloging.js 2019-07-26 02:40:09 +00:00
categories.js Bug 20781: Set a minimum enrollemnt period 'in months' of 1 2018-05-29 13:56:00 +00:00
charts.js Bug 17282: Ability to create charts for SQL reports 2018-10-01 13:56:35 +00:00
checkouts.js Bug 24166: Do not hang when displaying checkout list if barcode is not set 2020-01-16 10:28:44 +13:00
circ-patron-search-results.js Bug 20221: Fix for JavaScript error during checkout patron search 2018-02-16 13:00:57 -03:00
commons.js Bug 19290: Browse selected bibliographic records - Staff interface 2018-02-19 16:13:30 -03:00
datatables.js Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons 2018-10-09 12:57:41 +00:00
file-upload.js
…
funds_sorts.js Bug 15184: Prepare the ground - Move funds and sort fields autoupdate 2018-11-08 15:52:56 +00:00
holds.js Bug 21296: suspend hold ignores system preference on intranet 2020-03-16 13:08:06 +13:00
item_search_fields.js
…
letter.js Bug 23278: Reopen last panel upon "Save and continue" in notices 2019-08-13 21:12:14 +00:00
localcovers.js Bug 19511: Local cover images not centered in table column in staff client search results 2018-08-21 12:48:36 +00:00
marc_modification_templates.js Bug 15814: Handle correctly MMTA edit button 2019-07-19 18:40:50 +00:00
marc_subfields_structure.js
…
members-menu.js Bug 14794: (follow-up) Add tooltip to filter box 2019-06-26 14:32:07 +00:00
members.js Bug 19907: Fix email validation in patron edit form 2018-04-02 18:07:45 -03:00
merge-record.js
…
messaging-preference-form.js Bug 22744: Changes for opac and remove JS 2019-10-17 00:40:22 +00:00
offlinecirc.js
…
onboarding.js Bug 19514: Add client-side check 2017-12-14 16:58:13 -03:00
prevent_submit.js
…
rotating-collections.js Bug 19656: Move rotating collections templates JS to the footer 2017-12-11 11:34:22 -03:00
serials-toolbar.js Bug 20778: (bug 19777 follow-up) Fix subscription deletion 2018-06-08 09:48:12 -04:00
showpredictionpattern.js Bug 19778: Move template JavaScript to the footer: Serials, part 4 2017-12-14 16:58:13 -03:00
sms_providers.js Bug 17012 - Remove more event attributes from administration templates 2016-09-09 13:29:52 +00:00
staff-global.js Bug 20312: Add a link to last consulted patron 2018-11-08 15:38:20 +00:00
subscription-add.js Bug 19778: Move template JavaScript to the footer: Serials, part 4 2017-12-14 16:58:13 -03:00
table_filters.js Bug 24046: Untranslatable 'Activate filters' 2020-01-14 17:18:49 +13:00
tools-menu.js Bug 11897: (QA follow-up) Update of tools-menu.js 2018-10-09 15:46:08 +00:00
xmlControlfield.js
…
z3950_search.js Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif' and removing loading-small.gif file. 2016-12-28 13:43:20 +00:00