gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24046: Untranslatable 'Activate filters' 

Bug 9573 moved the code for the table filters activation to it's
own javascript file. The strings contained in this file are not
translatable. This patch moves the strings to the datatables
include file since the filters are related to datatables.

Test plan:
Visit the catalogue/detail.pl and reports/itemslost.pl and test
that the 'Activate/Deactivate filters' option still work correctly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 423cc1053d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 1bafa0e1ea)
Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
This commit is contained in:
Maryse Simard 2019-11-18 08:50:52 -05:00 committed by Hayley Mapley
parent ad87192f72
commit 17a3709aee
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
View File

@ -28,5 +28,8 @@
var MSG_DT_COPY_KEYS = _("Press ctrl or ⌘ + C to copy the table data<br>to your system clipboard.<br><br>To cancel, click this message or press escape.");
var MSG_DT_COPY_SUCCESS_ONE = _("Copied one row to clipboard");
var MSG_DT_COPY_SUCCESS_X = _("Copied %d rows to clipboard");
var MSG_CLEAR_FILTER = _("Clear filter");
var MSG_ACTIVATE_FILTERS = _("Activate filters");
var MSG_DEACTIVATE_FILTERS = _("Deactivate filters");
</script>
[% Asset.js("js/datatables.js") | $raw %]

4
koha-tmpl/intranet-tmpl/prog/js/table_filters.js
View File

@ -23,7 +23,7 @@ function activate_filters(id) {
}
$('#' + id + '_activate_filters')
.html('<i class="fa fa-filter"></i> ' + _("Deactivate filters") )
.html('<i class="fa fa-filter"></i> ' + MSG_DEACTIVATE_FILTERS )
.unbind('click')
.click(function() {
deactivate_filters(id);
@ -41,7 +41,7 @@ function deactivate_filters(id) {
filters_row.hide();
$('#' + id + '_activate_filters')
.html('<i class="fa fa-filter"></i> ' + _("Activate filters") )
.html('<i class="fa fa-filter"></i> ' + MSG_ACTIVATE_FILTERS )
.unbind('click')
.click(function() {
activate_filters(id);