Koha-clms/C4
Katrin Fischer 3e33394757 Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted
The numerical restricted value was overwritten in GetItemsInfo
with the description. So OpacHiddenItems would only work for
restricted using the description, not the numerical value
of the authorised value like for other similar status fields.

This changes GetItemsInfo to use a separate variable for
the description, as it's already done for notforloan and
changes the template files where the variable is used
accordingly.

To test
- Before applying patch
- Configure OpacHiddenItems with:
  restricted: [1]
- Find a record with more than one item and mark one of the items
  as "Restricted Access"
  (assume standard sample data - check authorised value if status doesn't exist)
- Verify the item is still shown in OPAC.
- Apply patch
- Verify that the item is now hidden
- Verify that the status still displays nicely in the staff detail page
- Delete OpacHiddenItems
- Verify that the status is showing nicely in the OPAC detail page

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 39d2885d13)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit ceb74447df)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-03-05 15:56:20 +00:00
..
AuthoritiesMarc
…
Barcodes Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead 2016-09-13 17:21:05 +00:00
ClassSortRoutine
…
Creators Bug 21281: (QA follow-up) Introduce _add_backtics 2018-09-27 13:08:15 +01:00
External Bug 20737: Use https for baker and taylor cover images 2018-05-11 11:36:23 -03:00
Form
…
Heading
…
ILSDI Bug 21199: (QA follow-up) Add show_attributes to perldoc 2018-08-29 16:25:47 +00:00
Installer Bug 21955: Remove Cache::Memory as fallback for L2 cache 2018-12-18 18:51:10 +00:00
Labels Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
Linker
…
Members Bug 20444: Remove sub GetAttributes 2018-05-03 13:26:49 -03:00
OAI Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios 2017-06-13 16:18:59 -03:00
Output
…
Patroncards Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts 2018-07-15 19:44:34 +01:00
Reports Bug 20663: Add some POD, so koha test tools don't complain 2018-05-04 09:19:26 -03:00
SIP Bug 21486: Only fetch the items' barcodes 2018-11-06 10:20:52 +00:00
Search Bug 17323: Column search_history.time cannot be null 2016-11-18 13:51:37 +00:00
Serials Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:53 -03:00
Utils Bug 20455: Fix sort patrons by date expired 2018-03-28 15:25:46 -03:00
Accounts.pm Bug 18677: Remove new issue_id param from charlostitem 2018-12-03 19:05:32 +00:00
Acquisition.pm Bug 21725: Use full statement in HAVING rather than constructed column 2018-11-09 16:15:49 +00:00
Auth.pm Bug 21911: Fix OPAC scoping to work with new group system 2018-12-18 19:07:34 +00:00
Auth_cas_servers.yaml.sample Bug 17065 - Rename C4/Auth_cas_servers.yaml.orig 2016-08-08 13:16:36 +00:00
Auth_with_cas.pm Bug 19160: Add POD 2018-03-23 11:45:38 -03:00
Auth_with_ldap.pm Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-24 09:58:21 +01:00
Auth_with_shibboleth.pm Bug 12026: [QA Follow-up] Fix a POD line 2017-03-31 14:28:18 +00:00
AuthoritiesMarc.pm Bug 21962: Fix authority search using 'all' 2018-12-18 19:20:07 +00:00
BackgroundJob.pm
…
Barcodes.pm
…
Biblio.pm Bug 21556: Do not crash if a biblio is deleted twice 2018-11-09 16:31:27 +00:00
Bookseller.pm Bug 14535: Update the supplier filter too 2017-03-31 12:38:44 +00:00
Boolean.pm
…
Breeding.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Budgets.pm Bug 21604: Fix add/edit fund/budget 2018-11-09 16:36:44 +00:00
Calendar.pm Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT 2017-07-06 14:29:04 -03:00
Charset.pm Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag" 2017-07-26 14:01:51 -03:00
Circulation.pm Bug 21849: Two useless Koha::Account::Offset->new calls need attention 2018-12-17 09:40:47 +00:00
ClassSortRoutine.pm
…
ClassSource.pm Bug 17208: Checking if classification source or filing rule already exists before adding 2016-12-23 11:33:48 +00:00
Context.pm Bug 18674: TZ error handling 2018-04-11 16:45:08 -03:00
Contract.pm
…
CourseReserves.pm Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-11-06 11:56:12 +00:00
Creators.pm
…
Debug.pm
…
HTML5Media.pm Bug 21742: Fix YouTube variable propagation 2018-11-09 16:11:46 +00:00
Heading.pm
…
HoldsQueue.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Images.pm
…
ImportBatch.pm Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT 2018-02-13 13:58:54 -03:00
ImportExportFramework.pm Bug 21749: Fix import of CSV biblio framework 2018-11-23 16:10:37 +00:00
InstallAuth.pm Bug 19514: Add client-side check 2017-12-14 16:58:13 -03:00
Installer.pm Bug 21654: Remove refund_lost_item_fee_rules.sql from the installer process 2018-11-06 15:23:00 +00:00
ItemCirculationAlertPreference.pm Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
Items.pm Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted 2019-03-05 15:56:20 +00:00
Koha.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Labels.pm
…
Languages.pm Bug 20115: Set the languages order with the pref values 2018-04-04 15:45:43 -03:00
Letters.pm Bug 21829: Correctly format dateexpiry in notices (date only) 2019-02-14 22:34:50 +00:00
Linker.pm
…
Log.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
MarcModificationTemplates.pm Bug 20144: [sql_modes] Set default value for marc_modification_template_actions 2018-02-13 13:58:55 -03:00
Matcher.pm Bug 21606: [sql_modes] Fix matching rules insert 2018-11-16 12:07:34 +00:00
Members.pm Bug 19920: Removed unnecessary code from C4/Members.pm 2019-02-01 21:10:17 +00:00
Message.pm
…
NewsChannels.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Output.pm Bug 20661: (QA follow-up) Add POD for output_and_exit 2018-08-13 09:23:05 +01:00
Overdues.pm Bug 21196: Use replacement cost from the item type if not set at item level 2018-09-27 13:27:05 +01:00
Patroncards.pm
…
Print.pm
…
Record.pm Bug 20097: Use same regex in marc2dcxml and opac-export 2018-03-19 12:23:19 -03:00
Reports.pm
…
Reserves.pm Bug 21075: AutoUnsuspendHolds should unsuspend holds <= today 2018-08-09 11:22:50 +01:00
Ris.pm Bug 10306: Core module changes for multiple mappings 2017-12-07 14:44:15 -03:00
RotatingCollections.pm
…
SMS.pm Bug 19134: C4::SMS falils on long driver name 2017-08-25 10:51:24 -03:00
Scheduler.pm
…
Scrubber.pm
…
Search.pm Bug 20151: always use current language for stemming 2018-10-15 13:49:00 +01:00
Serials.pm Bug 20351: Shortcut serials scripts if a blocking error appeared 2018-10-26 14:15:15 +01:00
Service.pm Bug 7550: [QA Follow-up] Resolve param warning from sco-patron-image 2017-05-08 09:00:26 -04:00
ShelfBrowser.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
SocialData.pm
…
Stats.pm Bug 20510: Remove unused sub TotalPaid from C4::Stats 2018-04-05 14:17:36 -03:00
Suggestions.pm Bug 13287: (QA follow-up) Extend Suggestions.t for DelSuggestionsOlderThan 2018-02-26 13:24:45 -03:00
TTParser.pm
…
Tags.pm
…
Templates.pm Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
TmplToken.pm
…
TmplTokenType.pm
…
UsageStats.pm Bug 21226: Remove xISBN services 2018-08-16 15:32:27 +01:00
XISBN.pm Bug 21235: Remove table services_throttle 2018-09-11 09:41:10 +01:00
XSLT.pm Bug 18921: Resolve a few warnings in C4/XSLT.pm 2017-09-07 14:34:42 -03:00