gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts 

== Test plan ==
This is an oversimplification of a full patron card setup used in production.

1. Create a batch with 1 patron
2. Create a layout and set
     the name
     "Print card number as barcode"
     "Barcode type:" to "Code 39"
3. Create a card template without filling anything
4. Export the batch using the layout and template
5. You should have a white page with a barcode
     And no errors in the relevant log file
     This show that this setup isn't completely bogus
     (although Code 39 is the only type working...)
6. Layout: set "Barcode type:" to Industrial2of5
7. Export the batch
8. You should have a white page with no barcode
     And errors in the relevant log file
     "Invalid Characters"
     This is the bug.
9. Layout: set "Barcode type:" to COOP2of5
10. Export the batch
11. You should have a white page with no barcode
      And errors in the relevant log file
      "Invalid Characters"
      This is the bug.
12. Apply this patch
13. Retry with both non-working patches
    1. You should have a white page with a barcode
    2. And no errors in the relevant log file

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Victor Grousset 2018-01-25 14:37:56 +01:00 committed by Martin Renvoize
parent d9a94cc7e5
commit 2e237ce6fb
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
C4/Patroncards/Patroncard.pm
View File

@ -394,7 +394,7 @@ sub _draw_barcode { # this is cut-and-paste from Label.pm because there is no
PDF::Reuse::Barcode::COOP2of5(
x => $params{'llx'}* $self->{'unitvalue'},
y => $params{'lly'}* $self->{'unitvalue'},
value => "*$params{barcode_data}*",
value => $params{barcode_data},
xSize => $x_scale_factor,
ySize => $params{'y_scale_factor'},
mode => 'graphic',
@ -412,7 +412,7 @@ sub _draw_barcode { # this is cut-and-paste from Label.pm because there is no
PDF::Reuse::Barcode::Industrial2of5(
x => $params{'llx'}* $self->{'unitvalue'} ,
y => $params{'lly'}* $self->{'unitvalue'},
value => "*$params{barcode_data}*",
value => $params{barcode_data},
xSize => $x_scale_factor,
ySize => $params{'y_scale_factor'},
mode => 'graphic',