Koha-clms/C4/SIP/ILS/Transaction
Kyle M Hall 7b4ee00a58 Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly
If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.

Test Plan:
1) Set the checked_in_ok sip account flag to 1 for an account
2) Check in an already checked in item via SIP
3) Note the alert flag is set to Y
4) Apply this patch
5) Restart SIP
6) Check the item in again
7) Note the alert flag is set to N

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-15 12:10:46 +00:00
..
Checkin.pm Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly 2019-03-15 12:10:46 +00:00
Checkout.pm Bug 19832: (QA follow-up) Remove obsolete pending_queue call 2019-02-15 18:42:45 +00:00
FeePayment.pm Bug 16899: Add ability to disallow overpayments 2017-10-27 14:10:29 -03:00
Hold.pm Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Renew.pm Bug 15494: Update display of renewal errors 2018-11-07 21:39:38 +00:00
RenewAll.pm Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00