Koha-clms/C4/SIP/ILS
Kyle M Hall 7b4ee00a58 Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly
If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.

Test Plan:
1) Set the checked_in_ok sip account flag to 1 for an account
2) Check in an already checked in item via SIP
3) Note the alert flag is set to Y
4) Apply this patch
5) Restart SIP
6) Check the item in again
7) Note the alert flag is set to N

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-15 12:10:46 +00:00
..
Transaction Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly 2019-03-15 12:10:46 +00:00
Item.pm Bug 19651: SIP/ILS/Item misses title and author 2017-11-26 12:59:31 -03:00
Item.pod
…
Patron.pm Bug 21486: Only fetch the items' barcodes 2018-10-24 12:40:18 +00:00
Patron.pod Bug 14383: C4: Fix some typos (mostly in comments and documentation) 2015-06-22 17:34:45 -03:00
Transaction.pm Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls 2017-07-10 12:06:37 -03:00