gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4/SIP
History
Jonathan Druart 82d6e097f5 Bug 9823: Refactor return from GetReservesFromBiblionumber 
The return from GetReservesFromBiblionumber contains an unnecessary
extra variable. In scalar context an array returns its element count.
Maintaining a separate count can lead to unforeseen bugs
and imposes ugly constructions on the subroutine's users.

Remove the useless count variable from the return

This patch also changes the parameters: now the routine takes a hashref.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Placed biblio holds, future holds and item holds. Works as expected.
Tested Holds.t and Reserves.t. Pass.
Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on
one item. Fine.
C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find
them anymore. Looks good.
Handled a few unneeded calls in QA follow-up.
Left only one point to-do for serials/routing-preview.pl. See Bugzilla.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 8b685c1e80)

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2014-05-27 12:17:44 +02:00
..
ILS Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-05-27 12:17:44 +02:00
Sip Bug 9252 - Add option to send patron's home branch in AF field - QA Followup 2013-09-08 06:08:07 +00:00
t Bug 9845: correct SIP 08checkin.t 2013-09-08 06:03:11 +00:00
ILS.pm Bug 10445: make SIP Server respect maxoutstanding system preference 2013-10-31 18:05:25 +00:00
ILS.pod
…
Makefile bug 3435: SIP2 - 3M extension for SmartChute checkin. 2009-07-30 11:06:53 -04:00
README bug 2509: fix file permissions 2008-08-21 18:55:02 -05:00
SIPServer.pm Bug 8271 teach SIPServer.pm to set its own lib path 2012-07-06 18:28:11 +02:00
Sip.pm Bug 9531: Make SIP2 message terminator configurable via SIPconfig.xml 2013-09-08 05:44:09 +00:00
acstest.py
…
example_institution_dump.sh Bug 2968 - SIP ACS_STATUS message (98) misreported config. 2009-02-26 14:57:22 -06:00
interactive_item_dump.pl Expand interactive SIP tests. 2009-06-17 11:42:44 -05:00
interactive_members_dump.pl Modifying Members : Add Mod and GetMember 2009-09-30 11:29:23 +02:00
interactive_patron_check_password.pl Interactive tests for SIP abstraction representation and Members. 2008-06-25 11:45:30 -05:00
interactive_patron_dump.pl Expand interactive SIP tests. 2009-06-17 11:42:44 -05:00
interactive_renew_all_dump.pl Interactive debugging aides for SIP abstraction layer. 2008-06-05 22:43:44 -05:00
test.txt
…
xmlparse.pl Bug 2505 - Add commented use warnings where missing in the C4/ directory 2010-04-21 20:25:32 +12:00

README 

README for Open NSIP 3M-SIP Server

DEPENDENCIES

SIPServer is written entirely in Perl, but it require these CPAN
perl modules to run:

     Net::Server - The SIP server is a Net::Server::Prefork server
     XML::LibXML
     XML::Parser
     XML::Simple - for parsing the config file
     UNIVERSAL::require - for loading the correct ILS interface module
     Clone - for running the test cases

LOGGING

SIPServer uses syslog() for status and debugging messages.  All
syslog messages are logged using the syslog facility 'local6'.
If you need to change this, because something else on your system
is already using that facililty, just change the definition of
'LOG_SIP' at the top of the file SIPServer.pm

Make sure to update your syslog configuration to capture facility
'local6' and record it.