gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 9845: correct SIP 08checkin.t 

The tests were too restrictive. It should be possible to pass
a checkin/checkout test with different values defined for
magnetic media.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Adrien Saurat 2013-03-21 11:58:29 +01:00 committed by Galen Charlton
parent 90e2aafeb5
commit 6f5eef782c
1 changed files with 25 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
C4/SIP/t/08checkin.t
View File

@ -8,10 +8,33 @@ use Clone qw(clone);
use Sip::Constants qw(:all);
use SIPtest qw(:basic :user1 :item1);
# Checkout response, format:
# code: 12
# success: 0 or 1
# renewal ok: Y or N
# magnetic media: Y, N or U
# desensitize: Y or N
# date
# Checkin response, format:
# code: 10
# success: 0 or 1
# resensitize: Y or N
# magnetic media: Y, N or U
# alert: Y or N
# date
my $checkout_template = {
id => "Checkin: prep: check out item ($item_barcode)",
msg => "11YN20060329 203000 AO$instid|AA$user_barcode|AB$item_barcode|AC|",
pat => qr/^121N[NYU][NY]$datepat/,
fields => [],
};
my $checkin_test_template = {
id => "Checkin: Item ($item_barcode) is checked out",
msg => "09N20060102 08423620060113 084235AP$item_owner|AO$instid|AB$item_barcode|AC$password|",
pat => qr/^101YNN$datepat/,
pat => qr/^101[NY][NYU]N$datepat/,
fields => [
$SIPtest::field_specs{(FID_INST_ID )},
$SIPtest::field_specs{(FID_SCREEN_MSG)},
@ -33,13 +56,6 @@ my $checkin_test_template = {
required => 0, }, # 3M Extension
],};
my $checkout_template = {
id => "Checkin: prep: check out item ($item_barcode)",
msg => "11YN20060329 203000 AO$instid|AA$user_barcode|AB$item_barcode|AC|",
pat => qr/^121NNY$datepat/,
fields => [],
};
my @tests = (
$SIPtest::login_test,
$SIPtest::sc_status_test,
@ -54,7 +70,7 @@ my $test;
# the ILS didn't check the item in, and there's no patron id.
$test = clone($checkin_test_template);
$test->{id} = 'Checkin: Item not checked out';
$test->{pat} = qr/^100YNN$datepat/o;
$test->{pat} = qr/^100[NY][NYU][NY]$datepat/o;
$test->{fields} = [grep $_->{field} ne FID_PATRON_ID, @{$test->{fields}}];
push @tests, $test;