Go to file
Tomas Cohen Arazi 68f549fbb6 Bug 23246: (follow-up) Hardcoding tab position is not enough
There are many conditions that determine the tab number for 'media'.
Translated into variables that hold the tabs count on each condition, it
is clear that '3' was not good enough:
            [%- holdings      = (SeparateHoldings)   ? 2 : 1
                notes         = (MARCNOTES || notes) ? 1 : 0
                acq           = (Koha.Preference('AcquisitionDetails')) ? 1 : 0
                frbr          = (FRBRizeEditions  && XISBNS) ? 1 : 0
                local_covers  = (LocalCoverImages && (localimages || CAN_user_tools_upload_local_cover_images)) ? 1 : 0
                media_tab     = holdings + notes + acq + frbr + local_covers
            -%]

This patch gets rid of the hardcoded value, adds an id to the 'media'
tab (i.e. 'media_tab') and uses JS to get the right index.

To test:
- Play with the different options governing those variables
=> FAIL: 3 is not always the 'media' tab
- Apply this patch
- Repeat your tests
=> SUCCESS: It always picks the 'media' tab
- Sign off :-D

Sponsored-by: American Numismatics Society
Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 0e21de15d6)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-12-20 15:34:21 +00:00
C4 Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly 2019-12-16 21:48:38 +00:00
Koha Bug 23089: Fix sorting on sum and regular fields 2019-12-17 22:46:18 +00:00
OpenILS
…
acqui Bug 23863: Editing a basket clears create_items value 2019-11-08 16:16:50 +01:00
admin Bug 23089: Fix sorting on sum and regular fields 2019-12-17 22:46:18 +00:00
api/v1 Bug 23607: Make /patrons/:patron_id/account staff only 2019-10-08 09:07:15 +02:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
catalogue Bug 23846: Display degraded view when MARCXML is invalid (staff detail) 2019-11-15 11:27:07 +01:00
cataloguing Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items 2019-11-15 11:21:37 +01:00
circ Revert "Bug 23484: Update pendingreserves.pl to use circulation_rules" 2019-11-15 08:34:29 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace 2019-11-15 11:17:27 +01:00
docs Update teams for 20.05 cycle 2019-11-28 18:56:59 +00:00
errors Bug 23329: Move error page to its own subroutine 2019-11-22 10:35:05 +00:00
etc Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace 2019-11-15 11:17:27 +01:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 13958: DBRev 19.05.05.001 2019-12-10 23:05:53 +00:00
koha-tmpl Bug 23246: (follow-up) Hardcoding tab position is not enough 2019-12-20 15:34:21 +00:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 21939: Fix permissions for holds history tab 2019-12-12 22:48:26 +00:00
misc Bug 24072: Typos in advance_notices.pl causes DUEDGST not to be sent 2019-12-16 21:41:50 +00:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 23836: exit after output_error 2019-11-22 10:35:06 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 22053: ability to enable/disable some plugins 2019-05-09 18:54:44 +00:00
reports Bug 23389: Add 'All' option to report dropdowns 2019-12-16 21:24:13 +00:00
reserve Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold 2019-12-20 15:06:12 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 23126: Remove more unnecessary linebreak processing from serial collection 2019-07-25 13:37:16 +02:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
…
suggestion Bug 23854: Fix failure on dates when editing a suggestion 2019-11-15 13:39:04 +01:00
svc Bug 23427: Simplify sort logic 2019-12-16 22:06:19 +00:00
t Bug 23089: Fix QueryBuilder tests. 2019-12-17 22:40:54 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
tmp/modified_authorities
…
tools Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del 2019-12-20 15:22:47 +00:00
virtualshelves Bug 22941: Do not return 500 if sortfield contain parenthesis 2019-06-20 14:24:59 +02:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL
…
Koha.pm Increment version for 19.05.05 release 2019-11-22 12:08:18 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 21626: (QA follow-up) Embed teams.yaml for debian packages 2019-05-17 14:46:10 +00:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 23445: (RM follow-up) Add warning for unexpected lengthunit 2019-09-05 16:49:01 +02:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl
…
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo