gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23854: Fix failure on dates when editing a suggestion 

- Watch plack-error-log
- Change an accepted suggestion to 'No Status'
- Verify error in the logs (use strict mode, depending on DBMS version)
- Status changed was not saved
- Apply patch
- Verify the error is gone, change is saved now.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 73198bc4bd)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Jonathan Druart 2019-10-22 11:10:59 +02:00 committed by Fridolin Somers
parent 9b18a475a5
commit 556aa6f65e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
suggestion/suggestion.pl
View File

@ -123,8 +123,11 @@ my $branchfilter = $input->param('branchcode') || C4::Context->userenv->{'branch
## Operations
##
if ( $op =~ /save/i ) {
$suggestion_only->{suggesteddate} = dt_from_string( $suggestion_only->{suggesteddate} )
if $suggestion_only->{suggesteddate};
for my $date_key ( qw( suggesteddate manageddate accepteddate rejecteddate ) ) {
$suggestion_only->{$date_key} = dt_from_string( $suggestion_only->{$date_key} )
if $suggestion_only->{$date_key};
}
if ( $suggestion_only->{"STATUS"} ) {
if ( my $tmpstatus = lc( $suggestion_only->{"STATUS"} ) =~ /ACCEPTED|REJECTED/i ) {