Go to file
David Kuhn 67610fe524 Bug 17309 - Renewing and HomeOrHoldingBranch syspref
The AddRenewal subroutine currently uses the circulation rules for the branch
stored in the Issues table (which is the holding branch) when calculating the new due date.

This patch replaces using the branch from the Issues table with the branch
specified by the HomeOrHoldingBranch syspref.

To test:
1. Set up 2 branches, Branch1 and Branch2
2. Set up a loan rule in Branch1 for DVDs with a 21 day loan period and a
   21 day renewal period.
3. Set up a loan rule in Branch2 for DVDs with a 14 day loan period and a
   14 day renewal period.
4. Checkout a DVD belonging to Branch1 while logged into Branch2. It will
   receive the correct 21 day loan period.
5. Renewing the same DVD while logged into either Branch1 or Branch2
   will give a 14 day due date, rather than 21 days.
6. Checkout a DVD belonging to Branch2 while logged into Branch1. It will
   receive the correct 14 day loan period.
7. Renewing the same DVD while logged into either Branch1 or Branch2
   will give a 21 day due date, rather than 14 days.
8. Apply the patch and repeat steps 4-7. The correct due date should be given
   when the item is renewed, regardless of where it is checked out or renewed.

This update removes reassignment of $branch variable.

Signed-off-by: Cédric Vita <cedric.vita@dracenie.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 7d35bdf58a)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(cherry picked from commit 0a26e824ae)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
2017-04-21 12:48:51 +02:00
C4 Bug 17309 - Renewing and HomeOrHoldingBranch syspref 2017-04-21 12:48:51 +02:00
Koha Revert "Bug 17494: Prevent duplicate tokens from getting stored" 2017-01-25 16:15:32 +01:00
OpenILS
…
acqui Bug 14535: Update the supplier filter too 2017-04-21 12:06:30 +02:00
admin Bug 18111: Swap framework_name and frameworkcode 2017-03-15 12:06:31 +01:00
api/v1 Bug 13799: Add types for patron's fields in Swagger spec 2015-11-04 13:47:33 -03:00
authorities Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
basket Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-16 11:37:09 +02:00
catalogue Bug 16951: Replace some more 2017-01-02 12:46:15 +01:00
cataloguing Bug 17922: Use correct number of digits when replacing date placeholders 2017-02-09 10:35:59 +01:00
circ Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen 2017-04-21 11:32:19 +02:00
course_reserves Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
debian Bug 17871: (followup) Remove zebra::* from the packages templates 2017-02-09 10:34:19 +01:00
docs Bug 7143: Updates for the 3.22 release 2015-11-10 11:01:07 -03:00
errors Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
etc Bug 17838 Availability limit broken until an item has been checked out. 2017-02-20 10:33:19 +01:00
install_misc Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl 2016-08-16 15:33:27 +02:00
installer Increment version for 3.22.19 2017-03-31 16:03:25 +02:00
koha-tmpl Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables 2017-04-21 12:29:08 +02:00
labels Bug 17900: Fix possible SQL injection in patron cards template editing 2017-01-30 16:25:01 +01:00
members Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl 2016-11-30 14:36:08 +01:00
misc Bug 18058: Allow borrower_message_preferences to be truncated 2017-04-21 11:26:56 +02:00
offline_circ Bug 15764: Fix timestamp sent by KOCT 2016-02-26 15:47:37 +01:00
opac Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl 2017-04-21 12:41:30 +02:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
patroncards Bug 18246: Patron card creator: Unit not always displays properly in layouts 2017-03-31 14:57:25 +02:00
plugins Bug 14951: Remove C4::Dates from plugins/*.pl files 2015-10-06 10:29:42 -03:00
reports Bug 8306: Patrons statistics, fix for patron activity choice 2017-02-20 10:55:18 +01:00
reserve Bug 17028: Fix XSS in reserve/request.pl 2016-08-17 14:14:48 +02:00
reviews Bug 14779: Cannot paginate reviews 2015-09-07 11:38:26 -03:00
rotating_collections Bug 15066: Make transfer rotating collection works under Plack 2015-11-05 09:50:09 -03:00
selenium
…
serials Bug 12178: Update serial status to "claimed" when exporting to CSV 2016-08-17 11:33:26 +02:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel
…
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-31 14:32:53 +01:00
suggestion Bug 16154: CGI->multi_param - Declare a list 2016-05-16 14:38:51 +02:00
svc Bug 17375: Search by dateofbirth - handle invalid dates 2016-11-08 10:17:35 +01:00
t Bug 18010: Unit test for gettemplate 2017-03-31 15:19:19 +02:00
tags Bug 16154: CGI->multi_param - Assign a list 2016-05-16 14:42:51 +02:00
test Bug 14321: Final cleanup, removing obsolete files 2015-09-25 12:02:52 -03:00
tmp/modified_authorities
…
tools Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status 2017-04-21 12:03:29 +02:00
virtualshelves Bug 17901: Fix possible SQL injection in shelf editing 2017-01-30 16:28:57 +01:00
xt Bug 13632: (QA followup) remove xt/permissions.t 2015-10-19 12:42:59 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
…
.mailmap (RM followup) .mailmap updates 2015-05-22 17:02:21 -03:00
INSTALL
…
INSTALL.debian
…
INSTALL.fedora7 Bug 9809: Remove one more occurrence of reserveconstraints 2015-08-26 10:27:01 -03:00
INSTALL.opensuse
…
INSTALL.ubuntu
…
Koha.pm Increment version for 3.22.19 2017-03-31 16:03:25 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 17044: Fix wrong destination for 'api' directory 2016-08-17 15:47:12 +02:00
README
…
README.robots
…
about.pl Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences 2016-05-09 10:40:44 +02:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-23 17:39:21 +02:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-16 11:37:09 +02:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 14812: Display the help in the correct language 2015-10-02 15:06:08 -03:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl
…
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 10904: (QA followup) Use branch limit if either IndependentBranches or IndependentBranchesPatronModifications is enabled 2015-11-02 12:34:46 -03:00
rewrite-config.PL Bug 16222: (QA followup) Add /api dir for the API 2016-04-21 09:33:01 +02:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/