gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18010: Unit test for gettemplate 

A trivial test, similar to the ones in Auth.t.
Without the check in gettemplate (added in the second patch), the passwd
file will be exposed and the test fails.

Test plan:
Run t/db_dependent/Templates.t without second patch. The two tests in the
last subtest should fail.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 5508897d5a)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Conflicts:
	t/db_dependent/Templates.t

(cherry picked from commit 1161a67476)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
This commit is contained in:
Marcel de Rooy 2017-01-29 15:52:22 +01:00 committed by Julian Maurice
parent f23c922540
commit 65b29fdda5
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
t/db_dependent/Templates.t
View File

@ -19,8 +19,12 @@ use Modern::Perl;
use CGI;
use Test::More tests => 5;
use Test::More tests => 6;
use Test::Deep;
use Test::MockModule;
use Test::Warn;
use t::lib::Mocks;
BEGIN {
use_ok( 'C4::Templates' );
@ -46,4 +50,12 @@ my @tables = ( 'biblio', 'biblioitems', 'borrowers', 'items', 'statistics', 'sub
cmp_deeply( \@keys, \@tables, "GetColumnDefs returns the expected tables");
subtest 'Testing gettemplate' => sub {
plan tests => 2;
my $template;
warning_like { eval { $template = C4::Templates::gettemplate( '/etc/passwd', 'opac', CGI->new, 1 ) }; warn $@ if $@; } qr/bad template/, 'Bad template check';
is( $template ? $template->output: '', '', 'Check output' );
};
1;