Go to file
Colin Campbell 60e9074bec Bug 15209 Validate passed MARC::Record objs in C4::Koha
Ensure that a passed MARC::Record is defined before calling
its methods. Otherwise you are open to occurences of the
error 'Can't call method "field" on an undefined value'
In a CGI environment you can live with such sloppiness but
in a persistent environment the error can cause the instance
to abort.
Made all routines passed a MARC::Record validate it before calling
its methods. Changed the parameter name from the meaningless
record to marcrecord to indicate its content. Added an explicit return
for all cases where no valid data returned. Cleaned up some logic for
clarity. I think we can assume that GetNormalizedOCLCNumber meant to
look at all 035s till it found an OCLC number not just the first.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 960458dee4)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 958985b2ff)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
2016-02-11 19:33:50 +01:00
C4 Bug 15209 Validate passed MARC::Record objs in C4::Koha 2016-02-11 19:33:50 +01:00
Koha Bug 15270: Make Koha::Objects->find return undef instead of crashing 2015-12-07 07:32:03 +01:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 9184: Acq - Don't show authority batches when ordering from staged file 2015-12-11 18:02:35 +01:00
admin Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
authorities Bug 15572: Follow-up to fix error on authority creation 2016-01-25 16:42:19 +01:00
basket Bug 14330: Remove unused email_sender from sendbasket/sendshelf 2015-06-09 08:38:40 +12:00
catalogue Bug 14636: Remove debug message 2015-12-31 18:31:11 +01:00
cataloguing Bug 15572: Follow-up to fix error on authority creation 2016-01-25 16:42:19 +01:00
circ Bug 12045 - Transfer impossible if barcode includes spaces 2016-02-11 19:10:26 +01:00
course_reserves Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
debian new Debian package maintainer 2015-12-05 01:28:41 +00:00
docs Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
errors Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
etc Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux 2015-12-31 18:38:03 +01:00
install_misc Bug 14066: Removing more Readonly 2015-05-06 11:05:22 -03:00
installer RMaint Increment version to 3.20.8 2016-01-25 19:49:10 +01:00
koha-tmpl Bug 2669: Change checkboxes to radio buttons on dictionary 2016-02-11 18:51:59 +01:00
labels Bug 12911: batch_id for new labels batches can be asssigned to several batches 2015-05-14 11:11:03 -03:00
members Bug 14349: Checkouts and Fines tab missing category description on the left 2015-12-11 17:58:50 +01:00
misc Bug 15240: [QA Follow-up] Minor adjustments 2016-02-11 19:31:26 +01:00
offline_circ Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
opac Bug 6679 - Fixing code so it passes basic Perl:::Critic tests 2016-02-11 18:55:50 +01:00
patron_lists Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
patroncards Bug 15109: Make name the default sort order for all patron searches 2015-11-29 22:09:58 +01:00
plugins Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
reports Bug 2669: Change checkboxes to radio buttons on dictionary 2016-02-11 18:51:59 +01:00
reserve Bug 14634: Warns when placing hold on record with no items 2015-09-22 13:11:32 +12:00
reviews Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
rotating_collections Bug 15066: Make transfer rotating collection works under Plack 2015-11-29 21:20:44 +01:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Revert "Bug 15171: Display subscriptions which will expire in the future" 2015-12-29 10:44:44 +01:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
suggestion Bug 10752: Alert the librarian if the suggestion has not been added 2015-04-28 15:11:42 -03:00
svc Bug 15431: svc/checkouts dies due to undefined variable (13024 merge problem) 2015-12-29 10:34:28 +01:00
t Bug 15530 - Add Unit Test 2016-02-11 19:00:14 +01:00
tags Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
test Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 15607: batch patron mod - do not update dates if not given 2016-01-25 16:37:24 +01:00
virtualshelves Bug 15137: Display ISBN and author info when sending list by email 2015-11-29 21:59:24 +01:00
xt Bug 13941: [1/2] Test <body> tag with id/class attributes 2015-04-24 09:47:28 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap (RM followup) .mailmap updates 2015-05-27 16:03:00 +12:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
Koha.pm RMaint Increment version to 3.20.8 2016-01-25 19:49:10 +01:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 13758: (QA followup) Make Makefile.PL aware of Koha.pm 2015-05-07 11:42:12 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 14298: Add warning to the about page if the sco user does not have correct permissions 2015-09-23 06:07:21 +12:00
changelanguage.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
edithelp.pl Bug 14813: Fix encoding issues on editing help pages 2015-09-23 05:36:42 +12:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 14812: Display the help in the correct language 2015-10-24 00:43:58 +13:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 8007: Discharge - Glue 2015-04-30 12:33:53 -03:00
rewrite-config.PL Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/