5f4fc10df5
The migration from SIPconfig.xml to the database ( bug 37893 ) leaves holds_get_captured NULL for any account that didn't define it in the config file. At SIP checkin an unset holds_get_captured defaults to on, but the REST API returns NULL boolean columns as false, so the SIP account editor shows "No" selected. Saving the account without touching the option then stores 0 and holds are no longer captured at SIP checkin. This patch changes the column default to 1 and sets existing NULL values to 1 so the stored value matches the actual checkin behavior. Test Plan: 1) If you have no SIP accounts, create one 2) Simulate an account migrated from a SIPconfig.xml that doesn't define holds_get_captured: UPDATE sip_accounts SET holds_get_captured = NULL; 3) Edit the account, note "Holds get captured" shows "No" even though holds *are* captured at SIP checkin while the value is unset 4) Apply this patch 5) Run updatedatabase.pl 6) SELECT login_id, holds_get_captured FROM sip_accounts; 7) Note holds_get_captured is now 1! 8) Edit the account again, note "Yes" is now selected for "Holds get captured"! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> |
||
|---|---|---|
| .. | ||
| atomicupdate | ||
| db_revs | ||
| en | ||
| localization | ||
| mandatory | ||
| backfill_statistics.pl | ||
| fix_unclosed_nonaccruing_fines_bug17135.pl | ||
| kohastructure.sql | ||
| labels_upgrade.pl | ||
| needs_update.pl | ||
| patroncards_upgrade.pl | ||
| update22to30.pl | ||
| updatedatabase.pl | ||