gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Kenza Zaki 5ff99f63e3 Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch 
Test plan :
Check if the regression tests still works
prove t/db_dependent/Branch.t
t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207.
t/db_dependent/Branch.t .. ok
All tests successful.
Files=1, Tests=36,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.00 csys =  0.16 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

From the man page

finsh()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 4287fd9d1c)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
 		2013-09-13 14:20:28 -03:00
..
AuthoritiesMarc Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Barcodes Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm 2012-09-20 12:01:36 +02:00
ClassSortRoutine Bug 9770: fix sorting of Dewey call numbers that contain prefixes 2013-07-25 11:54:35 -03:00
Creators Bug 10763 - [SIGNED-OFF] Update POD of C4::Creators::Lib::html_table() to use TT syntax 2013-09-13 11:30:31 -03:00
External Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm 2012-09-20 11:38:45 +02:00
Form Talking Tech Support - Phase I - Followup - Fix Messaging Preferences 2012-06-10 17:46:58 +02:00
Heading Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ILSDI bug 10549: make the ILS-DI services advertise that they return UTF-8 2013-08-13 13:37:54 -03:00
Installer bug 6281: add Library::CallNumber::LC as a required Perl dependency 2013-06-28 11:07:26 -03:00
Labels bug 9370: improve splitting of LC call numbers for labels 2013-06-28 11:20:41 -03:00
Linker Bug 8447: Make sure we have enough subfields for broader_headings 2012-09-14 14:56:48 +02:00
Members Bug 7919: Fix unit test (Members_AttributeTypes.t) 2012-12-07 18:26:37 -05:00
OAI Bug 6440: Implement OAI-PMH Sets 2012-03-20 11:38:26 +01:00
Output
…
Patroncards Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Reports Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports 2013-04-26 08:09:32 -04:00
SIP Bug 9838: fix on 04patron_status.t 2013-04-02 08:30:21 -04:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Utils Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
VirtualShelves Bug 10466: fix glitch in OPAC display of titles saved to list 2013-07-02 14:09:41 -03:00
Accounts.pm Bug 9293 - action_logs not tracking payments 2013-03-11 17:59:17 -04:00
Acquisition.pm Bug 10028: fix how ModReceiveOrder() calls NewOrder() 2013-09-13 10:41:40 -03:00
Auth.pm Bug 10552: make several sysprefs available to the OPAC login page 2013-08-15 15:08:29 -03:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 10029 - CAS authentication fails in OPAC reserve 2013-07-15 20:09:32 -03:00
Auth_with_ldap.pm Bug 10384: fall back to normal authentication if LDAP server is not available 2013-07-15 20:30:48 -03:00
AuthoritiesMarc.pm Bug 5635: bulkmarcimport new parameters & features 2013-03-21 20:21:54 -04:00
BackgroundJob.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm 2012-09-20 12:01:40 +02:00
Barcodes.pm Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm 2012-09-20 12:01:36 +02:00
Biblio.pm Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
Bookseller.pm Bug 10557: remove unused branch parameter from GetBooksellersWithLateOrders 2013-09-13 13:53:58 -03:00
Boolean.pm Bug 9827: remove 'insecure' system preference 2013-03-19 21:46:34 -04:00
Branch.pm Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch 2013-09-13 14:20:28 -03:00
Breeding.pm Bug 9986: Two fixes for Z3950 search 2013-04-15 08:49:52 -04:00
Budgets.pm Bug 10535: by default sort funds by name 2013-07-16 14:55:34 -03:00
Calendar.pm Bug 7351 : feature that allows to delete a range of dates 2012-09-28 12:19:45 +02:00
Category.pm Bug 7919: FIX the "all" categories method 2013-01-02 16:50:52 -05:00
Charset.pm Bug 8347 - Koha forces UNIMARC 100 field code language to 'fre' 2013-02-20 09:06:57 -05:00
Circulation.pm Bug 10081: add library name to IndependentBranches error message 2013-09-13 11:20:34 -03:00
ClassSortRoutine.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ClassSource.pm Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm 2013-08-16 12:14:32 -03:00
Context.pm Revert "Merge branch 'bug_6554' into 3.12-master" 2013-04-25 22:37:54 -04:00
Contract.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Creators.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Csv.pm Bug 7986: Export issues for patron 2012-09-13 17:58:30 +02:00
Dates.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Debug.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
HTML5Media.pm Bug 8377: Followup move style in a css file and do not pass template to a pm 2012-12-27 09:28:00 -05:00
Heading.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
HoldsQueue.pm Bug 10628: make sure AutomaticItemReturn doesn't prevent holds queue from filling local holds with local items 2013-09-13 12:28:50 -03:00
Images.pm Bug 8710 - Don't show the images tab in the OPAC if the record has no local images 2012-11-28 18:54:40 -05:00
ImportBatch.pm Bug 10230: Don't limit valid matches to bibs 2013-05-19 08:41:20 -04:00
ImportExportFramework.pm Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm 2012-09-20 12:00:55 +02:00
Input.pm Bug 7919 : Display of values depending on the connexion library 2012-12-05 10:10:57 -05:00
Installer.pm Bug 9752: Set marcflavour to NORMARC when NORMARC is chosen 2013-03-30 22:51:17 -04:00
ItemCirculationAlertPreference.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm 2012-09-20 12:01:39 +02:00
ItemType.pm Revert "Merge branch 'bug_6554' into 3.12-master" 2013-04-25 22:37:54 -04:00
Items.pm Bug 10764 - Update POD of C4::Items::GetItemStatus() to use TT syntax 2013-09-13 11:30:00 -03:00
Koha.pm Bug 10765 - [SIGNED-OFF] Update POD of C4::Koha::GetSupportList() to use TT syntax 2013-09-13 11:23:39 -03:00
Labels.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-20 14:39:56 -05:00
Letters.pm Bug 10621: use correct from-address for subscription alert emails 2013-08-16 11:51:35 -03:00
Linker.pm Bug 7284: Fix unit test broken by erroneous POD 2012-03-08 15:24:18 +01:00
Log.pm Bug 7067 - OPAC Borrower Self Registration 2012-12-14 08:08:59 -05:00
Maintainance.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Matcher.pm Bug 10230: no need to use SimpleSearch for matching auths 2013-05-19 08:41:14 -04:00
Members.pm Bug 10481: (follow-up) fix typo in POD 2013-09-11 14:34:34 -03:00
Message.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm 2012-09-20 12:01:39 +02:00
NewsChannels.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Output.pm Revert "Merge branch 'bug_6554' into 3.12-master" 2013-04-25 22:37:54 -04:00
Overdues.pm Bug 10030: QA Followup for trivial false warning detected while testing 2013-05-15 21:52:05 -04:00
Patroncards.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Print.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm 2012-09-20 12:17:43 +02:00
Ratings.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Record.pm Bug 9274: Software error in bibtex export 2013-03-30 20:59:41 -04:00
Reports.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Reserves.pm Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved 2013-09-10 12:59:09 -03:00
Review.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Ris.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
RotatingCollections.pm Bug 10642: fix inappropriate uses of $sth->finish() in C4::RotatingCollections.pm 2013-09-11 14:48:34 -03:00
SMS.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
SQLHelper.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm 2012-09-20 12:01:38 +02:00
Scheduler.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Scrubber.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Search.pm Bug 10741: reformat test for displaying place hold link in OPAC search results 2013-09-13 12:42:56 -03:00
Serials.pm bug 10356: improve display of serial issue dates in staff bib details page 2013-07-25 11:47:10 -03:00
Service.pm
…
ShelfBrowser.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm 2012-09-20 12:01:37 +02:00
SocialData.pm bug 7470 follow-up, fix POD doc 2012-03-26 17:53:28 +02:00
Stats.pm Bug 4118 - Add Collection Code to Statistics Table 2012-09-13 18:42:46 +02:00
Suggestions.pm Bug 10072 - "my suggestions" always says "There are no pending purchase suggestions." 2013-04-19 23:17:06 -04:00
TTParser.pm Bug 5327 : Follow up for TTParser test 2012-07-12 16:06:21 +02:00
Tags.pm Bug 9136: C4::Tags not Plack-compatible 2012-12-22 15:47:48 -05:00
Templates.pm Bug 10560: make it possible for default interface language to not be English 2013-07-16 15:00:15 -03:00
TmplToken.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
TmplTokenType.pm Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm" 2012-09-20 13:29:59 +02:00
UploadedFile.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Utils.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm 2012-09-20 12:01:39 +02:00
VirtualShelves.pm Bug 10386: improvements to VirtualShelves.t 2013-07-15 14:41:03 -03:00
XISBN.pm Bug 9726: XISBN service throttle not initialized 2013-03-30 22:05:15 -04:00
XSLT.pm bug 10292: improve fallback logic for picking XSLT 2013-06-04 12:40:21 -03:00