gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
root 0a47d3444d Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm 
This patch gets rid of finish() and replace prepare_cached by prepare.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 5cba6457aa)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit cfb48010ad)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit cfb48010ad)
 		2013-09-13 19:17:01 -03:00
..
AuthoritiesMarc Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Barcodes Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm 2012-09-20 12:01:36 +02:00
ClassSortRoutine Bug 9770: fix sorting of Dewey call numbers that contain prefixes 2013-08-04 18:56:07 -03:00
Creators Bug 9535 - Patron card creator "Remove duplicates" function doesn't work 2013-04-14 19:26:09 +12:00
External Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm 2012-09-20 11:38:45 +02:00
Form Talking Tech Support - Phase I - Followup - Fix Messaging Preferences 2012-06-10 17:46:58 +02:00
Heading Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ILSDI bug 10549: make the ILS-DI services advertise that they return UTF-8 2013-09-13 17:54:14 -03:00
Installer bug 6281: add Library::CallNumber::LC as a required Perl dependency 2013-07-08 11:11:11 -03:00
Labels bug 9370: improve splitting of LC call numbers for labels 2013-07-13 09:05:45 -03:00
Linker Bug 8447: Make sure we have enough subfields for broader_headings 2012-09-14 14:56:48 +02:00
Members Bug 7955: Followup : Check the syspref value (avoid sql injection) 2012-08-01 16:06:38 +02:00
OAI Bug 6440: Implement OAI-PMH Sets 2012-03-20 11:38:26 +01:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Reports Bug 7993 follow-up to fix POD DOC 2012-09-19 12:12:43 +02:00
SIP Bug 9838: fix on 04patron_status.t 2013-04-14 18:14:28 +12:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Utils Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
VirtualShelves Bug 9458 - Add sorting to lists - QA Followup 3 2013-07-14 18:02:17 -03:00
Accounts.pm Bug 9122: fix the problem when writing-off a fine 2012-11-23 09:09:53 -05:00
Acquisition.pm Bug 10504: Remove the unused C4::Acq::ModOrderItem routine 2013-08-04 20:21:33 -03:00
Auth.pm Bug 10553: make public lists available on OPAC login page 2013-09-13 18:05:22 -03:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 10029 - CAS authentication fails in OPAC reserve 2013-08-02 17:27:17 -03:00
Auth_with_ldap.pm Bug 10384: fall back to normal authentication if LDAP server is not available 2013-08-03 16:01:50 -03:00
AuthoritiesMarc.pm BUG 9145: Authorities: standard language for UNIMARC 2013-02-21 18:44:16 +13:00
BackgroundJob.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm 2012-09-20 12:01:40 +02:00
Barcodes.pm Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm 2012-09-20 12:01:36 +02:00
Biblio.pm Bug 9147: OPAC hidden fields are not hidden in ISBD view 2013-02-01 20:59:53 +13:00
Bookseller.pm Bug 10556: The delivery time is not inserted on adding a supplier. 2013-08-04 20:43:09 -03:00
Boolean.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Branch.pm Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-08-04 20:02:23 -03:00
Breeding.pm Normalize records imported from Z39.50 servers. 2012-10-08 18:46:56 +02:00
Budgets.pm Bug 10535: by default sort funds by name 2013-08-04 10:47:19 -03:00
Calendar.pm Bug 7351 : feature that allows to delete a range of dates 2012-09-28 12:19:45 +02:00
Category.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-28 17:54:25 +02:00
Charset.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Circulation.pm Bug 9362: fix query that finds upcoming due loans 2013-09-13 17:52:28 -03:00
ClassSortRoutine.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ClassSource.pm Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm 2013-09-13 19:17:01 -03:00
Context.pm Bug 9085 - Installer will not run with DEBUG set 2012-11-20 06:50:08 -05:00
Contract.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Creators.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Csv.pm Bug 7986: Export issues for patron 2012-09-13 17:58:30 +02:00
Dates.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Debug.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Heading.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
HoldsQueue.pm Bug 10311 - Holds queue ignores item-level holds where only one items exists 2013-07-08 10:05:55 -03:00
Images.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
ImportBatch.pm Bug 9523: importing staged bib records hangs if a matched bib has been deleted 2013-04-27 18:07:41 +12:00
ImportExportFramework.pm Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm 2012-09-20 12:00:55 +02:00
Input.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Installer.pm Bug 9752: Set marcflavour to NORMARC when NORMARC is chosen 2013-03-31 19:49:10 +13:00
ItemCirculationAlertPreference.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm 2012-09-20 12:01:39 +02:00
ItemType.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-28 17:54:25 +02:00
Items.pm Bug 10088: FIX adding an order from a staged file. 2013-08-03 16:01:50 -03:00
Koha.pm Bug 10463: ensure that Quote of the Day feature selects random quotes 2013-09-13 19:00:30 -03:00
Labels.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-20 14:39:56 -05:00
Letters.pm Bug 10621: use correct from-address for subscription alert emails 2013-09-13 18:58:26 -03:00
Linker.pm Bug 7284: Fix unit test broken by erroneous POD 2012-03-08 15:24:18 +01:00
Log.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Maintainance.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Matcher.pm Bug 7475: Teach matching rules to handle authorities 2012-09-19 17:15:56 +02:00
Members.pm Bug 8682 - Renewals do not appear on quick slips 2013-03-11 21:45:54 +13:00
Message.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm 2012-09-20 12:01:39 +02:00
NewsChannels.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Output.pm Bug 9504: URL escape in OPAC more searches 2013-03-29 19:44:19 +13:00
Overdues.pm Bug 8939 : Fines being charged during the grace period 2012-10-26 17:26:07 +02:00
Patroncards.pm Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
Print.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm 2012-09-20 12:17:43 +02:00
Ratings.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Record.pm Bug 9274: Software error in bibtex export 2013-03-31 18:53:29 +13:00
Reports.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Reserves.pm Bug 8559 - conflicting item statuses - QA Followup 2012-11-29 20:39:32 +13:00
Review.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Ris.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
RotatingCollections.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
SMS.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
SQLHelper.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm 2012-09-20 12:01:38 +02:00
Scheduler.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Scrubber.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Search.pm Bug 10176: Solve the Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols 2013-05-11 11:18:45 +12:00
Serials.pm Bug 8896 QA Followup for regex 2013-05-12 15:09:12 +12:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm 2012-09-20 12:01:37 +02:00
SocialData.pm bug 7470 follow-up, fix POD doc 2012-03-26 17:53:28 +02:00
Stats.pm Bug 4118 - Add Collection Code to Statistics Table 2012-09-13 18:42:46 +02:00
Suggestions.pm Bug 10072 - "my suggestions" always says "There are no pending purchase suggestions." 2013-04-27 17:31:56 +12:00
TTParser.pm Bug 5327 : Follow up for TTParser test 2012-07-12 16:06:21 +02:00
Tags.pm Bug 9136: C4::Tags not Plack-compatible 2012-12-27 08:40:31 +13:00
Templates.pm Bug 10560: make it possible for default interface language to not be English 2013-08-04 10:48:51 -03:00
TmplToken.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
TmplTokenType.pm Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm" 2012-09-20 13:29:59 +02:00
UploadedFile.pm Bug 7941 : Fix version numbers in modules 2012-06-11 17:29:38 +02:00
Utils.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm 2012-09-20 12:01:39 +02:00
VirtualShelves.pm Bug 10386: improvements to VirtualShelves.t 2013-07-16 09:19:55 -03:00
XISBN.pm Bug 9726: XISBN service throttle not initialized 2013-03-31 19:39:52 +13:00
XSLT.pm bug 10292: improve fallback logic for picking XSLT 2013-06-10 20:02:49 -03:00