gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Galen Charlton df13c5e14c do some validation of the KohaOpacRecentSearches cookie 
Add validation of the value of the KohaOpacRecentSearches.  In
particular, this patch avoids the generation of an internal server
error when the OPAC is presented with an old cookie that uses the
old Storable-based serialization.

This patch also moves parsing of the cookie value into a
new routine in C4::Auth, ParseSearchHistoryCookie, and adds
a test case.

To test (in conjunction with the previous patch):

Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:

- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Apply this patch and the previous one.
- Do *not* clear the KohaOpacRecentSearches cookie
- Check the search history and verify that no searches
  are listed any more
- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Log into the OPAC
- Verify that current and past searches are listed in
  search history.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 89792b97cacb01fc6f7d2380a4c8f21703d79e72)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit 89792b97cacb01fc6f7d2380a4c8f21703d79e72)
 		2013-07-28 18:30:15 -03:00
..
AuthoritiesMarc
…
Barcodes Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm 2012-09-20 12:01:36 +02:00
ClassSortRoutine bug 6281: introduce LC::CallNumber::LC for sorting LC call numbers 2013-07-08 10:55:10 -03:00
Creators Bug 9535 - Patron card creator "Remove duplicates" function doesn't work 2013-04-14 19:26:09 +12:00
External Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm 2012-09-20 11:38:45 +02:00
Form
…
Heading
…
ILSDI Bug 9019: Return item fields in ILS-DI GetRecords 2013-04-24 21:11:33 +12:00
Installer bug 6281: add Library::CallNumber::LC as a required Perl dependency 2013-07-08 11:11:11 -03:00
Labels bug 9370: improve splitting of LC call numbers for labels 2013-07-13 09:05:45 -03:00
Linker Bug 8447: Make sure we have enough subfields for broader_headings 2012-09-14 14:56:48 +02:00
Members Bug 7955: Followup : Check the syspref value (avoid sql injection) 2012-08-01 16:06:38 +02:00
OAI
…
Output
…
Patroncards
…
Reports Bug 7993 follow-up to fix POD DOC 2012-09-19 12:12:43 +02:00
SIP Bug 9838: fix on 04patron_status.t 2013-04-14 18:14:28 +12:00
Search
…
Utils
…
VirtualShelves Bug 9458 - Add sorting to lists - QA Followup 3 2013-07-14 18:02:17 -03:00
Accounts.pm Bug 9122: fix the problem when writing-off a fine 2012-11-23 09:09:53 -05:00
Acquisition.pm Bug 10381: POD lines of GetBasketsInfosByBookseller 2013-06-13 22:34:39 -03:00
Auth.pm do some validation of the KohaOpacRecentSearches cookie 2013-07-28 18:30:15 -03:00
Auth_cas_servers.yaml.orig
…
Auth_with_cas.pm
…
Auth_with_ldap.pm Bug 8919 - ExtendedPatronAttributes not populated from LDAP 2012-11-08 12:42:52 -05:00
AuthoritiesMarc.pm BUG 9145: Authorities: standard language for UNIMARC 2013-02-21 18:44:16 +13:00
BackgroundJob.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm 2012-09-20 12:01:40 +02:00
Barcodes.pm Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm 2012-09-20 12:01:36 +02:00
Biblio.pm Bug 9147: OPAC hidden fields are not hidden in ISBD view 2013-02-01 20:59:53 +13:00
Bookseller.pm
…
Boolean.pm
…
Branch.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm 2012-09-20 12:01:37 +02:00
Breeding.pm Normalize records imported from Z39.50 servers. 2012-10-08 18:46:56 +02:00
Budgets.pm Bug 5339: Invoices management improvement 2012-09-18 22:42:15 +02:00
Calendar.pm Bug 7351 : feature that allows to delete a range of dates 2012-09-28 12:19:45 +02:00
Category.pm
…
Charset.pm
…
Circulation.pm Bug 10262 - fine calculation at checkin not respecting CircControl 2013-06-10 19:46:21 -03:00
ClassSortRoutine.pm
…
ClassSource.pm
…
Context.pm Bug 9085 - Installer will not run with DEBUG set 2012-11-20 06:50:08 -05:00
Contract.pm
…
Creators.pm
…
Csv.pm Bug 7986: Export issues for patron 2012-09-13 17:58:30 +02:00
Dates.pm
…
Debug.pm
…
Heading.pm
…
HoldsQueue.pm Bug 10311 - Holds queue ignores item-level holds where only one items exists 2013-07-08 10:05:55 -03:00
Images.pm
…
ImportBatch.pm Bug 9523: importing staged bib records hangs if a matched bib has been deleted 2013-04-27 18:07:41 +12:00
ImportExportFramework.pm Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm 2012-09-20 12:00:55 +02:00
Input.pm
…
Installer.pm Bug 9752: Set marcflavour to NORMARC when NORMARC is chosen 2013-03-31 19:49:10 +13:00
ItemCirculationAlertPreference.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm 2012-09-20 12:01:39 +02:00
ItemType.pm
…
Items.pm Bug 10033 - dangerous query in _koha_modify_item 2013-05-09 19:23:26 +12:00
Koha.pm Bug 9341: Problem with UNIMARC authors facets 2013-03-29 19:08:15 +13:00
Labels.pm
…
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-20 14:39:56 -05:00
Letters.pm Bug 9348 - Format dates in HOLD notices consistently 2013-02-01 21:11:44 +13:00
Linker.pm
…
Log.pm
…
Maintainance.pm
…
Matcher.pm Bug 7475: Teach matching rules to handle authorities 2012-09-19 17:15:56 +02:00
Members.pm Bug 8682 - Renewals do not appear on quick slips 2013-03-11 21:45:54 +13:00
Message.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm 2012-09-20 12:01:39 +02:00
NewsChannels.pm
…
Output.pm Bug 9504: URL escape in OPAC more searches 2013-03-29 19:44:19 +13:00
Overdues.pm Bug 8939 : Fines being charged during the grace period 2012-10-26 17:26:07 +02:00
Patroncards.pm
…
Print.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm 2012-09-20 12:17:43 +02:00
Ratings.pm
…
Record.pm Bug 9274: Software error in bibtex export 2013-03-31 18:53:29 +13:00
Reports.pm
…
Reserves.pm Bug 8559 - conflicting item statuses - QA Followup 2012-11-29 20:39:32 +13:00
Review.pm
…
Ris.pm
…
RotatingCollections.pm
…
SMS.pm
…
SQLHelper.pm Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm 2012-09-20 12:01:38 +02:00
Scheduler.pm
…
Scrubber.pm
…
Search.pm Bug 10176: Solve the Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols 2013-05-11 11:18:45 +12:00
Serials.pm Bug 8896 QA Followup for regex 2013-05-12 15:09:12 +12:00
Service.pm
…
ShelfBrowser.pm Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm 2012-09-20 12:01:37 +02:00
SocialData.pm
…
Stats.pm Bug 4118 - Add Collection Code to Statistics Table 2012-09-13 18:42:46 +02:00
Suggestions.pm Bug 10072 - "my suggestions" always says "There are no pending purchase suggestions." 2013-04-27 17:31:56 +12:00
TTParser.pm
…
Tags.pm Bug 9136: C4::Tags not Plack-compatible 2012-12-27 08:40:31 +13:00
Templates.pm Bug 8623: Move YUI out of prog 2012-09-05 12:04:13 +02:00
TmplToken.pm
…
TmplTokenType.pm Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm" 2012-09-20 13:29:59 +02:00
UploadedFile.pm
…
Utils.pm Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm 2012-09-20 12:01:39 +02:00
VirtualShelves.pm Bug 10386: improvements to VirtualShelves.t 2013-07-16 09:19:55 -03:00
XISBN.pm Bug 9726: XISBN service throttle not initialized 2013-03-31 19:39:52 +13:00
XSLT.pm bug 10292: improve fallback logic for picking XSLT 2013-06-10 20:02:49 -03:00