Koha-clms/t/db_dependent
Nick Clemens e3f20fa795 Bug 18990: Overdue Notices are not sending through SMS correctly
Bug 18478 fixed sms via email problems under the assumption that
to_address was either smsalertnumber or blank.

It seems overdues set the to_address to email. This patch changes the
code to enforce that an sms sent with emial driver will use the
smsalertnumebr and provider defined for the borrower, regardless of what
is set in the queue

To test:
 1 - Define a messaging prefs for a patron to recieve hold notices via
  SMS
 2 - Ensure you have defined an SMS message for an overdue letter
 3 - Set an SMS alert number for patron
 4 - Set the SMS::Send driver to 'Email'
 5 - Checkout an item as overdue to trigger notice above
 6 - Run overdue_notices.pl
 6 - Check the db and note the address is email
 7 - run process_message_queue.pl
 8 - Check db - address is email followed by service provider
 9 - Apply patch
 10 - repeat
 11 - Message to_address should be populated with smsalertnumber

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit a7aab6d30b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-12-20 12:06:34 +01:00
..
Acquisition Bug 19120: Add tests to reproduce the problem 2017-10-17 09:49:41 +02:00
Auth
…
Authority Revert "Bug 17380: (QA followup) Fix parameter in tests" 2017-10-23 16:12:48 +02:00
Biblio Bug 18951: Adjust Isbd.t 2017-08-03 09:48:06 +02:00
Circulation Bug 19487: Fix MarkIssueReturned.t 2017-11-20 14:06:33 +01:00
Creators Bug 18044: Add a test 2017-02-07 17:46:00 +00:00
Exporter Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Holds Bug 19437: Rearranging tests for CancelExpiredReserves 2017-10-13 09:47:11 +02:00
Items Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Koha Bug 19004: Patrons.t should create its own data for enrollment fees. 2017-10-03 11:49:55 +02:00
LDAP
…
Labels Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Letters Bug 17762: Update the letter form interface 2017-05-09 20:56:41 +00:00
Members Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
OAI Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios 2017-06-15 14:14:57 +02:00
Patron Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Record
…
Reports Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems' and 'marcxml' 2017-11-20 14:03:32 +01:00
Reserves Bug 19437: (followup) Rearrange CancelExpiredReserves tests - fix typos 2017-10-13 09:47:59 +02:00
SIP Bug 19386: [QA Follow-up] Remove some default values 2017-10-27 15:20:37 +02:00
Search Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup 2017-07-31 09:21:30 +02:00
Serials Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Template/Plugin Bug 19655: Add tests 2017-12-11 09:23:46 +01:00
Utils Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
XSLT_Handler
…
api/v1 Bug 19405: Prevent api/v1/holds.t to fail randomly 2017-10-27 15:08:20 +02:00
data
…
selenium Bug 19337: Make basic_workflow.t configurable through ENV 2017-10-23 16:39:18 +02:00
www Bug 19392: Clean-up behind auth_values_input_www.t 2017-10-27 14:39:34 +02:00
00-strict.t Bug 18897: Skipping t/db_dependend/00-strict elastic search stuffs as needed 2017-10-03 17:00:04 +02:00
Accounts.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Acquisition.t Bug 18554: Adjust a few typos including responsability 2017-05-09 21:03:22 +00:00
AdditionalField.t
…
Amazon.t
…
ArticleRequests.t Bug 18766: Remove itemtype-related warnings from ArticleRequests.t 2017-06-12 11:59:19 +02:00
AudioAlerts.t
…
Auth.t Bug 18976: Fix t/db_dependent/Auth.t cleanup 2017-07-31 09:20:47 +02:00
Auth_with_cas.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-18 16:42:44 +02:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t
…
Barcodes.t
…
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Biblio.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Bookseller.t Bug 19130: Remove ->search() overloading and adjust tests 2017-09-29 15:21:13 +02:00
Breeding.t
…
Budgets.t Bug 18999: (17.05.x followup) Koha::Acquisition::Order is not an object yet 2017-10-25 11:03:00 +02:00
Calendar.t Bug 12063 - Fix QA failures 2017-05-09 08:59:39 -04:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
Circulation.t Bug 19403: Prevent Circulation.t to fail randomly 2017-10-27 15:02:21 +02:00
ClassSource.t
…
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
ColumnsSettings.t
…
Context.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Contract.t
…
CourseReserves.t
…
DecreaseLoanHighHolds.t Bug 19423: Prevent DecreaseLoanHighHolds.t to fail randomly 2017-10-27 15:34:17 +02:00
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Fines.t
…
FrameworkPlugin.t
…
Heading_MARC21.t
…
Hold.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Holds.t Bug 12063: Change date calculation for reserve expiration to skip all holiday 2017-05-09 08:59:39 -04:00
HoldsQueue.t Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm 2017-07-31 10:01:04 +02:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-09-06 15:27:05 +02:00
Installer.t
…
Items.t Bug 19350: Add tests 2017-10-17 09:25:43 +02:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
KitchenSinkPlugin.kpz
…
Koha.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Koha_Elasticsearch_Indexer.t Bug 18897: Use Module::Load::Conditional::can_load 2017-10-03 17:00:03 +02:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 18374: (QA follow-up) Fix auto truncation for field:"value" 2017-10-25 10:00:24 +02:00
Languages.t
…
Letters.t Bug 18990: Overdue Notices are not sending through SMS correctly 2017-12-20 12:06:34 +01:00
Linker_FirstMatch.t
…
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-31 10:46:17 +02:00
MarcModificationTemplates.t
…
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-09-29 15:25:44 +02:00
MungeMarcPrice.t
…
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t
…
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Patrons.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Plugins.t
…
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Record.t
…
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Reports.t
…
Reserves.t Bug 19437: Rearranging tests for CancelExpiredReserves 2017-10-13 09:47:11 +02:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
Search.t Bug 17664: Silence non-zebra warnings in t/db_dependent/Search.t 2017-10-27 15:25:48 +02:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-10 12:02:34 +02:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
…
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-09-29 11:31:42 +02:00
Sitemapper.t Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions 2017-01-20 14:04:21 +00:00
Stats.t
…
SuggestionEngine_ExplodedTerms.t Bug 9857: Fix failing tests 2017-10-03 11:13:53 +02:00
Suggestions.t Bug 18420: Use TestBuilder to create a patron category in Suggestions.t 2017-04-21 10:49:25 -04:00
Tags.t
…
Templates.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
TestBuilder.t Bug 18182: Tests all Koha::Objects-based modules 2017-04-21 00:10:50 +00:00
Upload.t Bug 18300: [QA Follow-up] Fix return value inconsistency 2017-04-21 00:11:40 +00:00
UsageStats.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Virtualshelves.t Bug 19343: [17.05.X] Add tests 2017-10-10 10:30:15 +02:00
XISBN.t Bug 19440: Identify overlimit problems in XISBN tests 2017-10-17 09:00:31 +02:00
XSLT_Handler.t
…
check_sysprefs.t
…
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-09-29 12:02:21 +02:00
default_search_class.pl
…
rollingloans.t
…
sysprefs.t
…
zebra_config.pl
…