Aleisha Amohia 9fa02f8212 Bug 33364: Prevent Holds to Pull from including items with pending recalls ... This patch checks for waiting or in_transit items allocated to recalls, and excludes them from the Holds to Pull report. To test: 1. Enable UseRecalls and set the recalls-related circulation rules 2. Check out an item to Patron A 3. Place an item-level hold on the item for Patron B 4. Log into the OPAC as Patron C and search for the item. Place an item-level recall on the item. 5. Go back to the staff interface and check in the item. This should prompt a pop-up to confirm the recall as waiting. Confirm the recall as waiting. 6. Go to Circulation -> Holds to pull. 7. Notice that even though the item is allocated for a recall, the hold is showing. It should not be showing in this page. 8. Apply the patch, restart services and refresh the page 9. The item allocated to a recall should no longer be showing in the Holds to pull report 10. Go to the record detail page and go to the Recalls tab 11. Revert the recall from its waiting status 12. Go back to the Holds to pull page. The record will now show for the hold. 13. Go to the Circulation -> Check in page 14. Go to the menu in the top-right of the page and click Set library 15. Change your library to a different one 16. Check in the item to confirm the recall as waiting and trigger a transfer 17. Go back to the Holds to pull page 19. The item should no longer show on the Holds to pull report 20. Confirm tests pass t/db_dependent/Koha/Holds.t Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>		2026-08-13 08:53:20 -06:00
..
Acquisition	Bug 42749: Prevent SQL injection from GetInvoices (order_by)	2026-08-10 08:18:08 -06:00
Auth	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
AuthoritiesMarc	…
Authority	Bug 40577: Bulk biblio ES index update after auth change	2026-04-15 14:10:14 -06:00
Biblio	Bug 42764: Fix spelling errors across the codebase	2026-06-11 09:53:34 -06:00
Budgets	…
Circulation	Bug 42764: Fix spelling errors across the codebase	2026-06-11 09:53:34 -06:00
CourseReserves	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Creators	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Exporter	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Holds	Bug 40058: Adjust existing tests	2025-08-14 16:06:00 -06:00
HoldsQueue	Bug 43033: Sort unallocated task indices before compacting the retry matrix	2026-08-10 14:56:39 -06:00
Items	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha	Bug 33364: Prevent Holds to Pull from including items with pending recalls	2026-08-13 08:53:20 -06:00
LDAP	…
Labels	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Letters	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Members	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
OAI	Bug 40962: Apply ViewPolicy filter consistently in OAI Server test setup	2026-03-23 07:54:05 +01:00
Patron	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Record	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Reports	Bug 42359: Fix Guided.t update_sql test input	2026-04-23 09:24:59 -06:00
Reserves	Bug 41983: (QA follow-up): Rebuild the holds queue when groups are edited	2026-05-06 15:20:58 -06:00
SIP	Bug 42847: (QA follow-up) Clear session state on all login_core exit paths	2026-08-10 08:18:07 -06:00
Search	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Serials	Bug 37796: (QA follow-up) nextpublisheddate in t/db../GetNextSeq.t	2025-12-17 13:24:24 -07:00
Template/Plugin	Bug 39781: (RM follow-up) Fix wrong mock_userenv key in test	2026-03-26 09:32:23 +01:00
Utils	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
api/v1	Bug 42868: (follow-up) Add regression test for non-UTC library timezone	2026-08-10 15:52:50 -06:00
cronjobs	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
data	Bug 39345: (QA follow-up): Add exception handling for unsupported counter release	2025-09-05 15:10:31 -06:00
misc/translator	Bug 41216: (follow-up) Fix path to sample.tt in xgettext-tt2.t	2026-04-13 09:52:55 +01:00
mojo	Bug 39055: Add change to Koha::App::Plugin::CSRF and fix unit test	2026-03-19 10:51:41 +00:00
selenium	Bug 41604: (follow-up) Wait for the page to be ready before searching in patrons_search.t	2026-08-10 15:52:38 -06:00
www	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
00-strict.t	Bug 42937: Remove unneeded flag in 00-strict.t	2026-08-10 15:52:44 -06:00
Accounts.t	Bug 35612: (QA follow-up) Add test for undefined LostChargesControl preference	2026-02-27 11:38:54 -07:00
Acquisition.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Amazon.t	…
ArticleRequests.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
AudioAlerts.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Auth.t	Bug 40286: Make C4::Auth::checkpw_internal use Koha::Patrons->find_by_identifier	2026-03-23 08:01:01 +01:00
AuthUtils.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Auth_with_cas.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Auth_with_ldap.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Auth_with_shibboleth.t	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
AuthorisedValues.t	Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings	2025-07-28 16:26:36 -06:00
AuthoritiesMarc.t	Bug 42032: (follow-up) Eliminate phantom indicator diffs on authority MODIFY	2026-05-05 13:42:06 -06:00
AuthoritiesMarc_GetTagsLabels.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Barcodes.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Barcodes_ValueBuilder.t	Bug 42221: Fix EAN-13 autoBarcode not incrementing	2026-04-16 15:54:09 -06:00
Biblio.t	Bug 42188: (follow-up) Update ModBiblio test for new info format	2026-05-06 09:52:11 -06:00
Biblio_holdsqueue.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Breeding.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Breeding_Auth.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Budgets.t	Bug 40371: Remove warnings from Budgets.t output	2025-07-23 16:36:30 -06:00
Cache.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Calendar.t	Bug 42545: (RM follow-up) Tidy test file	2026-05-20 09:04:54 -06:00
Charset.t	…
Circulation.t	Bug 41358: Always store circulation logs in consistent JSON format	2026-08-10 14:56:40 -06:00
ClassSources.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Clubs.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Context.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Contract.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
CourseReserves.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
DecreaseLoanHighHolds.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Filter_MARC_ViewPolicy.t	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
Fines.t	…
FrameworkPlugin.t	Bug 38365: Require a non-empty nonce in FrameworkPlugin.t	2026-03-17 09:38:49 +01:00
Heading.t	Bug 42764: Fix spelling errors across the codebase	2026-06-11 09:53:34 -06:00
Heading_MARC21.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Hold.t	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
Holds.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
HoldsQueue.t	Bug 40680: Fix C4::Calendar imports	2025-12-01 08:34:00 -07:00
Holidays.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
ILSDI_Services.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
ImportBatch.t	Bug 42098: (follow-up) Enable plugin in ImportBatch.t test	2026-03-20 07:51:01 +00:00
ImportExportFramework.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Installer.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Items.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha.t	…
Koha_Database.t	…
Koha_Elasticsearch.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha_ExternalContent_OverDrive.t	…
Koha_MetadataRecord_Authority.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha_Misc_Files.t	Bug 42764: Fix spelling errors across the codebase	2026-06-11 09:53:34 -06:00
Languages.t	Bug 41440: (QA follow-up) Add unit tests	2026-04-15 14:10:32 -06:00
Letters.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
LibraryGroups.t	…
Linker_Default.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Linker_FirstMatch.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Log.t	Bug 20956: BorrowersLog is not logging permission changes	2026-03-23 10:41:51 +01:00
MarcModificationTemplates.t	Bug 16994: (QA follow-up) Align overwrite result key across module, template and tests	2026-04-17 09:18:17 -06:00
Matcher.t	Bug 42764: Fix spelling errors across the codebase	2026-06-11 09:53:34 -06:00
Members.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Message.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
MungeMarcPrice.t	…
Output.t	Bug 38936: Use https in license	2025-10-01 08:32:49 -06:00
Overdues.t	Bug 35612: Add tests for branch context recording in OVERDUE fees	2026-02-27 11:38:50 -07:00
Passwordrecovery.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
PatronLists.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Patroncards.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Patrons.t	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
Prices.t	…
Realtime_holdsqueue.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Record.t	Bug 41690: (follow-up) Add test	2026-05-01 11:04:35 -06:00
RecordProcessor_EmbedSeeFromHeadings.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Reports.t	…
Reserves.t	Bug 41358: Apply consistent JSON logging to holds (Bug 40866)	2026-08-10 14:56:42 -06:00
RotatingCollections.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Search.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Search_FacetSorting.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Serials.t	Bug 37796: Pass correct publication date when generating the next serial form the serial collection page	2025-12-17 13:24:17 -07:00
Serials_2.t	…
Service.t	…
ShelfBrowser.t	…
Sitemapper.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
SocialData.t	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
StockRotationItems.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
StockRotationRotas.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
StockRotationStages.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
SuggestionEngine_ExplodedTerms.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Suggestions.t	Bug 42645: Add tests for FallbackToSMSIfNoEmail with alternate email fields	2026-07-13 16:10:31 -06:00
TablesSettings.t	Bug 41042: default_save_state is enabled by default	2025-10-23 11:33:32 -06:00
Tags.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Templates.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
TestBuilder.t	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
Upload.t	…
UsageStats.t	Bug 42764: Fix spelling errors across the codebase	2026-06-11 09:53:34 -06:00
Virtualshelves.t	Bug 18148: Add unit tests	2025-11-05 07:12:35 -07:00
XISBN.t	…
XSLT.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
check_kohastructure.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
check_sysprefs.t	Bug 42734: Add autoMemberNumValue to patrons sysprefs UI with caution note	2026-07-09 13:06:39 -06:00
db_structure.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
rollingloans.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
sysprefs.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
yaml.t	…
zebra_config.pl	…