gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16994: (QA follow-up) Align overwrite result key across module, template and tests 

The import result hash key was inconsistent: the module sets
$result->{overwrote}, but the test checked $result->{overwrite} and the
template wrapper used import_overwrite. The uninitialized key also
triggered a "Use of uninitialized value" warning when no templates were
overwritten.

- Initialize overwrote => 0 in ImportModificationTemplates result hash
- Update test to check $result->{overwrote}
- Fix template success-alert wrapper to gate on import_overwrote

Test plan:
- prove t/db_dependent/MarcModificationTemplates.t
- all 134 subtests pass

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Paul Derscheid 2026-04-17 16:47:18 +02:00 committed by Lucas Gass
parent 7e1aff13ef
commit a81b2cfe4f
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
C4/MarcModificationTemplates.pm
View File

@ -840,9 +840,10 @@ sub ImportModificationTemplates {
my ( $json, $skip_existing ) = @_;
my $result = {
success => 0,
skipped => 0,
errors => [],
success => 0,
skipped => 0,
overwrote => 0,
errors => [],
};
my $data;

2
koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
View File

@ -420,7 +420,7 @@
[% END %]
[% END %]
[% IF import_success || import_skipped || import_overwrite %]
[% IF import_success || import_skipped || import_overwrote %]
<div class="alert alert-success">
[% IF import_success %]
<p>Successfully imported [% import_success | html %] template(s).</p>

2
t/db_dependent/MarcModificationTemplates.t
View File

@ -1236,7 +1236,7 @@ subtest 'Import with skip_existing=0 overwrites existing templates' => sub {
my $result = ImportModificationTemplates( $json, 0 );
ok( $result->{success} == 1, "Template imported successfully with skip_existing=0" );
ok( $result->{skipped} == 0, "No templates skipped" );
ok( $result->{overwrite} == 1, "One template overwritten" );
ok( $result->{overwrote} == 1, "One template overwritten" );
ok( scalar( @{ $result->{errors} } ) == 0, "No import errors" );
# Verify the template was overwritten (should have only 1 action now)