gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent/Koha
History
Fridolin Somers 4077a6faa9 Bug 23630: Do not remove field 999 in Elasticsearch indexing 
Elasticsearch indexing uses 999$c to store record id by deleting the all field first !
So you can not store anything in field 999, even in UNIMARC and even in authorities records.

Looks like it is quick fix code added to start Elasticsearch use.

This behavior is disturbing and very strange for UNIMARC flavour.

This patch corrects by defining record ids mandatory in Koha::SearchEngine::Elasticsearch::Indexer::update_index().
This ids array is actually always given (except in UT).
I think it is useless to allow adding a record without its id.

Test plan :
1) Use Elasticsearch as SearchEngine
2) Create a subfield 999$z in default framework
3) Create a record with default framework
4) Enter a random string (never used in catalog) like "tototata" in 999$z
5) In Search engine configuration, define search field "subject" for 999$z
6) Rebuild record : misc/search_tools/rebuild_elasticsearch.pl -b -bn <biblionumber> -v
7) Search for the random string => You get a result
8) Optionnaly look at records in ES : <es server>:9200/<es index name>/data/<biblionumber>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit fb083813a8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2019-11-08 16:50:51 +01:00
..
Account Bug 22511: (follow-up) Fix test plans 2019-04-25 11:02:14 +00:00
Acquisition Bug 22541: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl 2019-04-11 11:45:24 +00:00
Biblio Bug 22144: (QA follow-up) Prepare the ground for other formats 2019-01-30 11:50:48 +00:00
BiblioUtils Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
Charges Bug 20912: (follow-up) Improve test coverage 2019-03-07 17:29:00 +00:00
Config Bug 15494: (follow-up) Move yaml syspref code to its own sub in SySpref object 2018-11-07 21:39:39 +00:00
Filter Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
IssuingRules Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl 2018-09-07 13:16:10 +00:00
Item Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Library Bug 21082: Add new admin page for overdrive 2018-10-09 11:04:23 +00:00
Objects/Mixin Bug 15774: (QA follow-up) Fix use statemenets 2019-03-07 20:37:06 +00:00
Patron Bug 23151: (follow-up) tweaked tests 2019-07-23 14:51:57 +02:00
Patrons Bug 23077: Fix import of cardnumber 0 2019-07-25 15:48:11 +02:00
REST Bug 22053: (QA follow-up) More tests 2019-05-09 18:54:45 +00:00
SearchEngine Bug 23630: Do not remove field 999 in Elasticsearch indexing 2019-11-08 16:50:51 +01:00
Subscription Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Tags Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) 2019-03-15 12:27:44 +00:00
Template/Plugin Bug 22053: (QA follow-up) Fix tests 2019-05-10 16:57:46 +00:00
Account.t Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit test 2019-06-11 15:44:15 +02:00
ActionLogs.t Bug 22363: Add tests 2019-03-11 11:22:00 +00:00
ApiKeys.t Bug 21597: Field 'description' doesn't have a default value 2018-10-18 14:18:00 +00:00
Authorities.t Bug 14769: Put ControlledIndicators to work 2018-04-12 10:50:35 -03:00
Biblio.t Bug 23225: Add a test 2019-07-25 14:01:39 +02:00
BiblioFrameworks.t Bug 16155: [QA Follow-up] Add transaction to BiblioFrameworks.t 2016-05-04 13:47:58 +00:00
BiblioUtils.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblios.t Bug 21798: (QA follow-up) Fix Biblios.t 2019-01-28 18:53:28 +00:00
Checkouts.t Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons 2018-10-03 17:18:44 +00:00
CirculationRules.t Bug 22679: Delete related CirculationRules when Removing IssuingRule 2019-04-24 10:35:38 +00:00
Cities.t Bug 20144: [sql_modes] Shorten cities.city_zipcode 2018-02-13 13:58:51 -03:00
ClassSortRules.t Bug 19929: Add Koha objects for class sources and sorters 2018-03-23 11:45:38 -03:00
ClassSources.t Bug 15836: Fix failing tests 2018-11-13 18:53:10 +00:00
ClassSplitRules.t Bug 15836: Handle non-existent regexs 2018-11-13 15:18:22 +00:00
CsvProfiles.t Bug 20144: [sql_modes] Add default values for export_format columns 2018-02-13 13:58:51 -03:00
Database.t Bug 21613: Add a test 2018-10-29 00:40:52 +00:00
GetDailyQuote.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Holds.t Bug 22008: (follow-up) Additional test fix and fix typo 2019-03-27 13:13:48 +00:00
IssuingRules.t Bug 22679: Delete related CirculationRules when Removing IssuingRule 2019-04-24 10:35:38 +00:00
Item.t Bug 22899: (QA follow-up) Change accessor name 2019-05-14 18:08:34 +00:00
ItemTypes.t Bug 20912: Move calculation to Koha::Fees 2019-03-07 17:27:36 +00:00
Items.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
KeyboardShortcuts.t Bug 21411: (QA follow-up) fix tests 2019-05-10 18:59:39 +00:00
Libraries.t Bug 7614: Add a new method Koha::Libraries->pickup_locations 2019-01-25 14:46:58 +00:00
MarcSubfieldStructures.t Bug 19096: Add update DB entry to sync kohafield in all frameworks 2017-12-11 11:34:08 -03:00
News.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Notices.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Object.t Bug 21610: Add tests 2019-02-01 20:19:54 +00:00
Objects.t Bug 21912: (QA follow-up) Do not delete existing patrons 2019-01-11 13:01:02 +00:00
Patrons.t Bug 23688: System preference uppercasesurnames broken by typo 2019-10-08 09:53:02 +02:00
Ratings.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t Bug 20052: (follow-up) Fix QA tool complaints and bad copy 2018-04-02 18:08:06 -03:00
Reviews.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
SMS_Providers.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
SearchField.t Bug 18316: (follow-up) Fix tests and update statement 2018-11-07 22:16:59 +00:00
SharedContent.t Bug 22249: Mana - Move comment process in a dedicated sub 2019-08-09 14:40:09 +02:00
Subscription.t Bug 17047: add a dedicated page for Mana setup 2019-01-23 14:39:26 +00:00
Suggestions.t Bug 22368: Make sure the tests will always pass 2019-03-11 12:53:29 +00:00
Tags.t Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) 2019-03-15 12:27:44 +00:00
Z3950Servers.t Bug 20047: Add Koha::Z3950Server Oject and use it to get server count 2018-04-20 13:34:41 -03:00