gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent
History
Fridolin Somers 4077a6faa9 Bug 23630: Do not remove field 999 in Elasticsearch indexing 
Elasticsearch indexing uses 999$c to store record id by deleting the all field first !
So you can not store anything in field 999, even in UNIMARC and even in authorities records.

Looks like it is quick fix code added to start Elasticsearch use.

This behavior is disturbing and very strange for UNIMARC flavour.

This patch corrects by defining record ids mandatory in Koha::SearchEngine::Elasticsearch::Indexer::update_index().
This ids array is actually always given (except in UT).
I think it is useless to allow adding a record without its id.

Test plan :
1) Use Elasticsearch as SearchEngine
2) Create a subfield 999$z in default framework
3) Create a record with default framework
4) Enter a random string (never used in catalog) like "tototata" in 999$z
5) In Search engine configuration, define search field "subject" for 999$z
6) Rebuild record : misc/search_tools/rebuild_elasticsearch.pl -b -bn <biblionumber> -v
7) Search for the random string => You get a result
8) Optionnaly look at records in ES : <es server>:9200/<es index name>/data/<biblionumber>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit fb083813a8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2019-11-08 16:50:51 +01:00
..
Acquisition Bug 21364: (follow-up) Check for standing status and uncertain prices 2019-04-30 12:45:42 +00:00
Auth Bug 20128: (QA follow-up) Corrections to haspermission 2019-04-17 12:25:26 +00:00
Authority Bug 14769: Put ControlledIndicators to work 2018-04-12 10:50:35 -03:00
Biblio Bug 20126: Add simple test for ModBiblioMarc 2018-02-02 12:08:42 -03:00
Circulation Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t 2019-10-08 09:46:00 +02:00
CourseReserves Bug 22142: Do not revert data if 'unchanged' was set 2019-08-28 15:26:51 +02:00
Creators Bug 21281: (QA follow-up) Introduce _add_backtics 2018-09-26 15:22:57 +00:00
Exporter Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Holds Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest 2019-05-10 18:57:20 +00:00
Illrequest Bug 20750: Add unit tests 2019-03-15 19:07:08 +00:00
Items Bug 21975: add Unit Test 2019-04-16 13:17:33 +00:00
Koha Bug 23630: Do not remove field 999 in Elasticsearch indexing 2019-11-08 16:50:51 +01:00
LDAP
…
Labels Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
Letters Bug 23579: (RM follow-up) Fix failing tests 2019-11-08 16:21:42 +01:00
Members Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
OAI Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Patron Bug 13515: Add unit tests 2019-02-15 13:12:22 +00:00
Record Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Reports Bug 23624: (QA follow-up) Test error cases 2019-10-08 09:24:50 +02:00
Reserves Bug 21765: Regression tests 2019-02-27 09:14:21 -05:00
SIP Bug 23211: Prevent SIP/Transaction.t to fail randomly 2019-07-25 13:41:06 +02:00
Search Bug 22048: Use set_password in tests 2019-01-25 20:15:31 +00:00
Serials Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Template/Plugin Bug 22688: (follow-up) Unit tests 2019-04-16 13:17:32 +00:00
Utils Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
XSLT_Handler
…
api/v1 Bug 23607: Make /patrons/:patron_id/account staff only 2019-10-08 09:07:15 +02:00
cronjobs Bug 20478: (QA follow-up) Make test more standard 2019-03-22 19:46:31 +00:00
data Bug 11677: Use zebra not-onloan-count index for availability limit 2019-09-05 15:08:23 +02:00
selenium Bug 23280: Silence warning 2019-07-30 07:26:58 +02:00
www Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests 2018-11-08 02:18:45 +00:00
00-strict.t Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 22511: (follow-up) Fix test plans 2019-04-25 11:02:14 +00:00
Acquisition.t Bug 22618: Move tests to t/db_dependent/Acquisition.t 2019-04-10 20:00:54 +00:00
Amazon.t
…
ArticleRequests.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
AudioAlerts.t
…
Auth.t Bug 22692: (RM follow-up) Adjust test count 2019-05-02 13:40:07 +00:00
Auth_with_cas.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Auth_with_ldap.t Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-20 14:40:13 +00:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Barcodes.t
…
Barcodes_ValueBuilder.t Bug 21937: Add test to show autoBarcode annual increment bug 2019-04-19 14:32:17 +00:00
Biblio.t Bug 8995: DBRev 18.12.00.066 2019-04-29 16:09:00 +00:00
Bookseller.t Bug 21817: Fix 2 failing tests 2019-01-02 20:18:30 +00:00
Breeding.t Bug 12747: Add extra column in Z3950 search 2018-10-01 13:56:26 +00:00
Budgets.t Bug 10577: Improve semantics of GetBudgetPeriod() 2019-03-28 12:46:14 +00:00
Cache.t Bug 22808: Move Cache.t to db_dependent 2019-05-07 10:50:00 +00:00
Calendar.t Bug 9031: (QA follow-up) Final changes to Calendar::days_between 2017-10-27 14:09:04 -03:00
Charset.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Circulation.t Bug 21985: Fix further occurences 2019-11-08 14:58:27 +01:00
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Context.t Bug 19788: Add a test 2017-12-22 13:15:37 -03:00
Contract.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
CourseReserves.t Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
DecreaseLoanHighHolds.t Bug 22493: Clean up DecreaseLoanHighHolds.t 2019-03-15 12:17:59 +00:00
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
FrameworkPlugin.t Bug 20204: Add TestBuilder to replace CPL branch 2018-02-15 11:15:53 -03:00
Heading.t Bug 21826: Move Heading tests to db_dependent since they require database connection 2019-01-25 20:13:39 +00:00
Heading_MARC21.t
…
Hold.t Bug 21478: (QA follow-up) Make sure tests don't fail randomly 2019-01-28 16:06:26 +00:00
Holds.t Bug 20837: (RM follow-up) fix test count 2019-04-25 14:25:06 +00:00
HoldsQueue.t Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs 2019-03-21 16:22:56 +00:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 23156: Add pagination to checkouts in ILS-DI GetPatronInfo service 2019-07-25 13:31:30 +02:00
Illcomments.t Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
Illrequestattributes.t Bug 7317: (followup) Make tests independent of data on the DB 2017-11-09 11:42:15 -03:00
Illrequests.t Bug 18837: (follow-up) Add additional tests 2019-03-15 19:33:36 +00:00
Images.t Bug 21987: (RM follow-up) Add text for simple tests 2019-03-15 12:22:32 +00:00
ImportBatch.t Bug 22053: (QA follow-up) Fix tests 2019-05-10 16:57:46 +00:00
ImportExportFramework.t Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Installer.t Bug 22472: Add tests 2019-04-11 13:34:09 +00:00
Items.t Bug 22899: (QA follow-up) Change accessor name 2019-05-14 18:08:34 +00:00
Items_DelItemCheck.t Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
KitchenSinkPlugin.kpz
…
Koha.t Bug 20144: [sql_modes] Correct quotes.timestamp values in tests 2018-02-13 13:58:54 -03:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 18235: (follow-up) fix tests and remove trailing space 2019-03-28 15:57:32 +00:00
Koha_ExternalContent_OverDrive.t Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent 2018-11-16 13:04:57 +00:00
Koha_ExternalContent_RecordedBooks.t Bug 17602: RecordedBooks Integration to Koha 2018-10-01 13:56:38 +00:00
Koha_Misc_Files.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Languages.t Bug 18213: Add language facets to Elasticsearch 2019-03-28 15:57:32 +00:00
Letters.t Bug 8000: (QA follow-up) Two lastminute fixes 2019-04-29 15:08:47 +00:00
LibraryGroups.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Linker_Default.t Bug 21450: (QA follow-up) remove a couple of unused variables to make QA script happy 2019-05-30 10:13:38 +00:00
Linker_FirstMatch.t
…
Log.t Bug 22917: Fix typo in another test file 2019-05-23 14:47:41 +00:00
MarcModificationTemplates.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Members.t Bug 23579: (RM follow-up) Fix failing tests 2019-11-08 16:21:42 +01:00
MungeMarcPrice.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
NewsChannels.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Overdues.t Bug 22521: Update fines handling to use accountline.status 2019-04-17 16:49:36 +00:00
Passwordrecovery.t Bug 20474: Mimick Letters.t 2018-03-27 12:21:44 -03:00
PatronLists.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Patroncards.t Bug 22878: Add tests 2019-05-15 12:10:52 +00:00
Patrons.t Bug 9302: (QA follow-up) Consistency follow-up 2018-04-20 13:34:41 -03:00
Plugins.t Bug 23230: (follow-up) Fix broken tests 2019-07-25 15:13:22 +02:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
…
Reserves.t Bug 14549: Unit tests 2019-08-09 16:51:35 +02:00
RotatingCollections.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Search.t Bug 11677: Use zebra not-onloan-count index for availability limit 2019-09-05 15:08:23 +02:00
Serials.t Bug 23416: Add PreserveSerialNotes system preference 2019-08-29 10:26:48 +02:00
Serials_2.t Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber 2018-07-18 15:49:47 +00:00
Service.t
…
ShelfBrowser.t Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Sitemapper.t Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ 2018-11-08 02:18:48 +00:00
Stats.t Bug 21683: (follow-up) Remove last occurences of statistics.proccode 2019-03-21 18:19:23 +00:00
StockRotationItems.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
SuggestionEngine_ExplodedTerms.t Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t 2017-11-01 13:10:18 -03:00
Suggestions.t Bug 23027: Make Suggestions.t pass even if no biblio in DB 2019-06-11 15:47:36 +02:00
Tags.t Bug 21846: Simplify ugly double for loops 2019-03-15 12:27:44 +00:00
Templates.t Bug 20727: Move temporary_directory() to C4::Context 2018-06-22 16:10:09 +00:00
TestBuilder.t Bug 22930: (QA follow-up) Add two test descriptions 2019-05-17 13:26:34 +00:00
Upload.t Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
UsageStats.t Bug 14576: Unit tests 2019-04-25 11:36:24 +00:00
Virtualshelves.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
XISBN.t Bug 12537: Don't retrieve XISBN results for the same biblionumber 2019-07-30 08:14:19 +02:00
XSLT_Handler.t Bug 20272: Replace error numbers by codes in XSLT_Handler 2018-07-02 12:12:48 +00:00
check_kohastructure.t Bug 19783: Move check_kohastructure.t to db_dependent 2018-01-19 15:13:56 -03:00
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl
…
rollingloans.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
sysprefs.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
zebra_config.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00